From: Philipp Hortmann <philipp.g.hortmann@gmail.com>
To: Oliver Neukum <oneukum@suse.com>,
corbet@lwn.net, linux-doc@vger.kernel.org,
linux-kernel@vger.kernel.org
Cc: linux-usb@vger.kernel.org, gregkh@linuxfoundation.org
Subject: Re: [PATCH v3 1/5] Docs: usb: update usb_bulk_msg receiving example
Date: Mon, 13 Dec 2021 06:06:34 +0100 [thread overview]
Message-ID: <8c11aa29-d935-94e4-9812-2c882d9e8c19@gmail.com> (raw)
In-Reply-To: <ec1a30b7-941c-331a-fbc1-02b907cb5788@suse.com>
On 12/7/21 9:55 AM, Oliver Neukum wrote:
>
> On 06.12.21 21:57, Philipp Hortmann wrote:
>> The :c:func:`usb_bulk_msg` function can be very useful for doing single reads
>> or writes to a device; however, if you need to read or write constantly to
>> a device, it is recommended to set up your own urbs and submit them to
>> -the USB subsystem.
>> +the USB subsystem. The template uses urbs for read and write.
>
> Hi,
>
> now that I read this, shouldn't we tell the reader why exactly the use
> of URBs is a good idea at that place?
>
> Regards
> Oliver
>
The Documentation/driver-api/usb/URB.rst does describe this well. We
could think about a link to it.
Regards
Philipp
next prev parent reply other threads:[~2021-12-13 5:06 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-12-06 20:57 [PATCH v3 0/5] Docs: usb: Code and text updates from usb-skeleton Philipp Hortmann
2021-12-06 20:57 ` [PATCH v3 1/5] Docs: usb: update usb_bulk_msg receiving example Philipp Hortmann
2021-12-07 8:55 ` Oliver Neukum
2021-12-13 5:06 ` Philipp Hortmann [this message]
2021-12-06 20:57 ` [PATCH v3 2/5] Docs: usb: update comment and code near decrement our usage count for the device Philipp Hortmann
2021-12-07 9:30 ` Oliver Neukum
2021-12-12 1:25 ` Philipp Hortmann
2021-12-06 20:58 ` [PATCH v3 3/5] Docs: usb: update comment and code of function skel_delete Philipp Hortmann
2021-12-06 20:58 ` [PATCH v3 4/5] Docs: usb: update explanation for device_present to disconnected Philipp Hortmann
2021-12-06 20:58 ` [PATCH v3 5/5] Docs: usb: correct format of function names in the explanations Philipp Hortmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8c11aa29-d935-94e4-9812-2c882d9e8c19@gmail.com \
--to=philipp.g.hortmann@gmail.com \
--cc=corbet@lwn.net \
--cc=gregkh@linuxfoundation.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=oneukum@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox