Re: [PATCH] ata: sata_gemini: Remove unused gemini_sata_reset_bridge()

Damien Le Moal
2024-12-11T22:53:44Z

On 12/12/24 06:49, Dr. David Alan Gilbert wrote:
> * Linus Walleij (linus.walleij@linaro.org) wrote:
>> On Wed, Dec 11, 2024 at 2:12 AM <linux@treblig.org> wrote:
>>
>>> From: "Dr. David Alan Gilbert" <linux@treblig.org>
>>>
>>> gemini_sata_reset_bridge() was added in 2017 by the initial
>>> commit be4e456ed3a5 ("ata: Add driver for Faraday Technology FTIDE010")
>>> but has never been used.
>>>
>>> Remove it.
>>>
>>> Signed-off-by: Dr. David Alan Gilbert <linux@treblig.org>
>>
>> Right it was never used because the corresponding reset in
>> the low-level PATA driver didn't work so I patched it out before
>> submitting.
>
> Ah right.
>
>> But should you not also remove sata0_reset and
>> sata1_reset from struct sata_gemini and the code fetching
>> the two reset lines? And even #include <linux/reset.h>?
>
> Oh I see, I was just looking for entirely unreferenced functions
> but that takes a little more following to notice.
>
> I'm happy to do that; are you OK with it as a follow up patch or
> do you want a v2? (And can you test it, I don't have the hardware).

I already applied your previous patch. But I can replace it. So either an
incremental patch or a v2 is fine with me. Thanks.

>
> Dave
>
>> Yours,
>> Linus Walleij

--
Damien Le Moal
Western Digital Research