Re: [PATCH] ata: sata_gemini: Remove unused gemini_sata_reset_bridge()

Linus Walleij
2024-12-11T10:34:47Z

On Wed, Dec 11, 2024 at 2:12 AM <linux@treblig.org> wrote:

> From: "Dr. David Alan Gilbert" <linux@treblig.org>
>
> gemini_sata_reset_bridge() was added in 2017 by the initial
> commit be4e456ed3a5 ("ata: Add driver for Faraday Technology FTIDE010")
> but has never been used.
>
> Remove it.
>
> Signed-off-by: Dr. David Alan Gilbert <linux@treblig.org>

Right it was never used because the corresponding reset in
the low-level PATA driver didn't work so I patched it out before
submitting.

But should you not also remove sata0_reset and
sata1_reset from struct sata_gemini and the code fetching
the two reset lines? And even #include <linux/reset.h>?

Yours,
Linus Walleij