Re: [PATCH net-next 02/16] net: dsa: add ports list in the switch fabric

Andrew Lunn
2019-10-21T12:37:45Z

> +static struct dsa_port *dsa_port_touch(struct dsa_switch *ds, int index)
> +{
> + struct dsa_switch_tree *dst = ds->dst;
> + struct dsa_port *dp;
> +
> + dp = &ds->ports[index];
> +
> + dp->ds = ds;
> + dp->index = index;
> +
> + INIT_LIST_HEAD(&dp->list);
> + list_add(&dp->list, &dst->ports);
> +
> + return dp;
> +}

Bike shedding, but i don't particularly like the name touch. How
about list. The opposite would then be delist, if we ever need it?

Otherwise:

Reviewed-by: Andrew Lunn <andrew@lunn.ch>

Andrew