From: Dongsheng Yang <dongsheng.yang@linux.dev>
To: Li Chen <me@linux.beauty>,
dm-devel@lists.linux.dev, linux-kernel@vger.kernel.org,
Zheng Gu <cengku@gmail.com>
Subject: Re: [PATCH v2 2/3] dm-pcache: reuse meta_addr in pcache_meta_find_latest
Date: Thu, 13 Nov 2025 14:40:02 +0800 [thread overview]
Message-ID: <8c7c6147-f49d-425d-820f-dfe4f04623cb@linux.dev> (raw)
In-Reply-To: <20251111121337.1063443-3-me@linux.beauty>
在 11/11/2025 8:13 PM, Li Chen 写道:
> From: Li Chen <chenl311@chinatelecom.cn>
>
> pcache_meta_find_latest() already computes the metadata address as
> meta_addr. Reuse that instead of recomputing.
>
> Signed-off-by: Li Chen <chenl311@chinatelecom.cn>
Reviewed-by： Dongsheng Yang <dongsheng.yang@linux.dev
> ---
> drivers/md/dm-pcache/pcache_internal.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/md/dm-pcache/pcache_internal.h b/drivers/md/dm-pcache/pcache_internal.h
> index d427e534727c..b7a3319d2bd3 100644
> --- a/drivers/md/dm-pcache/pcache_internal.h
> +++ b/drivers/md/dm-pcache/pcache_internal.h
> @@ -99,7 +99,7 @@ static inline void __must_check *pcache_meta_find_latest(struct pcache_meta_head
> /* Update latest if a more recent sequence is found */
> if (!latest || pcache_meta_seq_after(meta->seq, seq_latest)) {
> seq_latest = meta->seq;
> - latest = (void *)header + (i * meta_max_size);
> + latest = meta_addr;
> }
> }
>
next prev parent reply other threads:[~2025-11-13 6:40 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-11-11 12:13 [PATCH v2 0/3] dm-pcache: built-in support and metadata hardening Li Chen
2025-11-11 12:13 ` [PATCH v2 1/3] dm-pcache: allow built-in build and rename flush helper Li Chen
2025-11-13 6:39 ` Dongsheng Yang
2025-11-11 12:13 ` [PATCH v2 2/3] dm-pcache: reuse meta_addr in pcache_meta_find_latest Li Chen
2025-11-13 6:40 ` Dongsheng Yang [this message]
2025-11-11 12:13 ` [PATCH v2 3/3] dm-pcache: zero cache_info before default init Li Chen
2025-11-12 8:24 ` Zheng Gu
2025-11-13 6:40 ` Dongsheng Yang
2025-11-13 6:43 ` [PATCH v2 0/3] dm-pcache: built-in support and metadata hardening Dongsheng Yang
2025-11-18 18:05 ` Mikulas Patocka
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8c7c6147-f49d-425d-820f-dfe4f04623cb@linux.dev \
--to=dongsheng.yang@linux.dev \
--cc=cengku@gmail.com \
--cc=dm-devel@lists.linux.dev \
--cc=linux-kernel@vger.kernel.org \
--cc=me@linux.beauty \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox