From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.1 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E5914C54E49 for ; Thu, 7 May 2020 20:17:58 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id BE89A216FD for ; Thu, 7 May 2020 20:17:58 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="R8QxXSAb" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728720AbgEGUR6 (ORCPT ); Thu, 7 May 2020 16:17:58 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47210 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-FAIL-OK-FAIL) by vger.kernel.org with ESMTP id S1726367AbgEGUR5 (ORCPT ); Thu, 7 May 2020 16:17:57 -0400 Received: from mail-wm1-x342.google.com (mail-wm1-x342.google.com [IPv6:2a00:1450:4864:20::342]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 5EDD2C05BD43; Thu, 7 May 2020 13:17:57 -0700 (PDT) Received: by mail-wm1-x342.google.com with SMTP id r26so8305515wmh.0; Thu, 07 May 2020 13:17:57 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=RGbtCswDTgsFLypisMjHemhGa1gfh6xqfnI2J9mGaYg=; b=R8QxXSAb86c/ioq5vI1vsHGKZAkJnzS0DjY/yFt4eMsepV8vaoHS7ZCD83RtZ/885H TxzAt2Cte98AukbnMPo/tifw8WNX4jiywLIHbptOiZigyefuc0CvUA5MkOtVtBxaqIGq 28BfQPRl7QrOU5sTJBZUZkpEoXENQdthEOrYEBeA8BiI5nh9g32reDAGMkTQTBx51I2c iXasH7C4hOpwVoKs5JSUhkMUm2KlWVp3ZRyBYoSj3pQ3sL86cGXRr7U5edt3AT0+3i5Y tGijdyZsEJal8BjKIYa/ta6q2A7x0hPVAc5BhcrJyavNicNvpBoUBwphuj767IOzFX1/ xZWw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=RGbtCswDTgsFLypisMjHemhGa1gfh6xqfnI2J9mGaYg=; b=XBlM1dPQqrTbhOlzQ/g9qCU8NN01jD7F6bzIJybkgor87hs+g6TNXrNqbVK9k6MBxf IUjDWARtep77jv6uhmoRseucBWLQWlz4QwqVp8NNYYMq04VKp6DRCYhVPetGCcRstyOm 0SN5XYrF0Gvu3/DeDyb6mzIYR6nGZ7RAENcovibSIuNqVofLzA9PL6F8HFqPYv69ZYRq rt1SgVVWuCjxOciJ6VyP7OW/1oz+DagOWtFXrw5Kt6B8pxVHEWSkB5FP3y1KflY1z66I 98hReRVoySYFv1UVHK5i5qPjsWGOm5YwQKzSt04+cVCPzV7RFDDxVkMHXA51IzKemVnb WP8A== X-Gm-Message-State: AGi0PuaJ1c57BUoGK2pV5bBn7h0VGRxLLdb2DhB3V4UoyTUKMVsAoepd L64TmTzowof9B9H2qvnVN7pEIkug X-Google-Smtp-Source: APiQypKwYfOoUWjK0tabjGOtcz+Wjakktm4C1Yp0U1VLzErywtiaT2qObR3zUpmGxLPYLmn62ifkmA== X-Received: by 2002:a1c:4d18:: with SMTP id o24mr11401308wmh.141.1588882675802; Thu, 07 May 2020 13:17:55 -0700 (PDT) Received: from [10.230.188.43] ([192.19.223.252]) by smtp.gmail.com with ESMTPSA id u74sm9942459wmu.13.2020.05.07.13.17.52 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 07 May 2020 13:17:55 -0700 (PDT) Subject: Re: [PATCH v3 1/4] PCI: brcmstb: Don't clk_put() a managed clock To: Jim Quinlan Cc: Nicolas Saenz Julienne , Lorenzo Pieralisi , Rob Herring , Bjorn Helgaas , "maintainer:BROADCOM BCM7XXX ARM ARCHITECTURE" , "moderated list:BROADCOM BCM2711/BCM2835 ARM ARCHITECTURE" , "moderated list:BROADCOM BCM2711/BCM2835 ARM ARCHITECTURE" , "open list:PCI NATIVE HOST BRIDGE AND ENDPOINT DRIVERS" , open list References: <20200507201544.43432-1-james.quinlan@broadcom.com> <20200507201544.43432-2-james.quinlan@broadcom.com> From: Florian Fainelli Message-ID: <8c8ac461-c6e9-0362-a30c-eab48cfbdae1@gmail.com> Date: Thu, 7 May 2020 13:17:50 -0700 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:68.0) Gecko/20100101 Firefox/68.0 Thunderbird/68.7.0 MIME-Version: 1.0 In-Reply-To: <20200507201544.43432-2-james.quinlan@broadcom.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 5/7/2020 1:15 PM, Jim Quinlan wrote: > From: Jim Quinlan > > clk_put() was being invoked on a clock obtained by > devm_clk_get_optional(). > > Signed-off-by: Jim Quinlan > Acked-by: Florian Fainelli > Acked-by: Nicolas Saenz Julienne This one should also have: Fixes: c0452137034b ("PCI: brcmstb: Add Broadcom STB PCIe host controller driver") not sure if Bjorn can add it while applying. -- Florian