Re: [PATCH 1/5] dt-bindings: spi: zynqmp-qspi: Add reset

Michal Simek
2025-01-17T07:14:46Z

On 1/16/25 23:55, Sean Anderson wrote:
> Add a reset to help recover from cancelled operations.
>
> Signed-off-by: Sean Anderson <sean.anderson@linux.dev>
> ---
>
> Documentation/devicetree/bindings/spi/spi-zynqmp-qspi.yaml | 6 ++++++
> 1 file changed, 6 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/spi/spi-zynqmp-qspi.yaml b/Documentation/devicetree/bindings/spi/spi-zynqmp-qspi.yaml
> index 04d4d3b4916d..901e15fcce2d 100644
> --- a/Documentation/devicetree/bindings/spi/spi-zynqmp-qspi.yaml
> +++ b/Documentation/devicetree/bindings/spi/spi-zynqmp-qspi.yaml
> @@ -36,12 +36,16 @@ properties:
> power-domains:
> maxItems: 1
>
> + resets:
> + maxItems: 1
> +
> required:
> - compatible
> - reg
> - interrupts
> - clock-names
> - clocks
> + - resets

In 2/5 you are calling devm_reset_control_get_optional_exclusive() that's why I
expect reset is not really required property.

M