From: Ajay Kumar Nandam <ajay.nandam@oss.qualcomm.com>
To: Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com>
Cc: Bjorn Andersson <andersson@kernel.org>,
Linus Walleij <linusw@kernel.org>,
linux-arm-msm@vger.kernel.org, linux-gpio@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3 1/2] pinctrl: qcom: lpass-lpi: Enable runtime PM hooks on remaining SoCs
Date: Wed, 13 May 2026 19:25:09 +0530 [thread overview]
Message-ID: <8cdca0cf-7b36-4aef-bc93-c611611b32b7@oss.qualcomm.com> (raw)
In-Reply-To: <gkgffuxfown5esdo6s6yg4povzskhean5hzd2yowsiyxrpkd2h@oa2fs63ijmym>
On 5/13/2026 6:18 PM, Dmitry Baryshkov wrote:
> On Fri, May 08, 2026 at 05:06:35PM +0530, Ajay Kumar Nandam wrote:
>> The LPASS LPI core conversion to PM clock framework relies on variant
>> drivers wiring runtime PM callbacks.
>>
>> Hook up runtime PM callbacks for the remaining LPASS LPI variant
>> drivers so all SoCs using the common core get consistent pm_clk based
>> clock handling:
>> - milos
>> - sdm660
>> - sdm670
>> - sc8280xp
>> - sm4250
>> - sm6115
>> - sm8250
>> - sm8450
>> - sm8550
>> - sm8650
>>
>> This is a mechanical per-variant driver update that relies on the
>> same generic PM clock flow (of_pm_clk_add_clks() + pm_clk_suspend/
>> pm_clk_resume()) and DT-provided clocks.
>>
>> Runtime behavior was validated on Kodiak (sc7280).
>>
>> Signed-off-by: Ajay Kumar Nandam <ajay.nandam@oss.qualcomm.com>
>> ---
>> drivers/pinctrl/qcom/pinctrl-milos-lpass-lpi.c | 7 +++++++
>> drivers/pinctrl/qcom/pinctrl-sc8280xp-lpass-lpi.c | 11 +++++++++--
>> drivers/pinctrl/qcom/pinctrl-sdm660-lpass-lpi.c | 7 +++++++
>> drivers/pinctrl/qcom/pinctrl-sdm670-lpass-lpi.c | 7 +++++++
>> drivers/pinctrl/qcom/pinctrl-sm4250-lpass-lpi.c | 7 +++++++
>> drivers/pinctrl/qcom/pinctrl-sm6115-lpass-lpi.c | 7 +++++++
>> drivers/pinctrl/qcom/pinctrl-sm8250-lpass-lpi.c | 11 +++++++++--
>> drivers/pinctrl/qcom/pinctrl-sm8450-lpass-lpi.c | 11 +++++++++--
>> drivers/pinctrl/qcom/pinctrl-sm8550-lpass-lpi.c | 11 +++++++++--
>> drivers/pinctrl/qcom/pinctrl-sm8650-lpass-lpi.c | 11 +++++++++--
>> 10 files changed, 80 insertions(+), 10 deletions(-)
>>
>> @@ -173,10 +175,15 @@ static const struct of_device_id lpi_pinctrl_of_match[] = {
>> };
>> MODULE_DEVICE_TABLE(of, lpi_pinctrl_of_match);
>>
>> +static const struct dev_pm_ops lpi_pinctrl_pm_ops = {
>> + RUNTIME_PM_OPS(pm_clk_suspend, pm_clk_resume, NULL)
>> +};
>> +
>> static struct platform_driver lpi_pinctrl_driver = {
>> .driver = {
>> - .name = "qcom-sc8280xp-lpass-lpi-pinctrl",
>> - .of_match_table = lpi_pinctrl_of_match,
>> + .name = "qcom-sc8280xp-lpass-lpi-pinctrl",
>> + .of_match_table = lpi_pinctrl_of_match,
>> + .pm = pm_ptr(&lpi_pinctrl_pm_ops),
>
> Incorrect indentation
>
>> },
>> .probe = lpi_pinctrl_probe,
>> .remove = lpi_pinctrl_remove,
>
>> @@ -134,10 +136,15 @@ static const struct of_device_id lpi_pinctrl_of_match[] = {
>> };
>> MODULE_DEVICE_TABLE(of, lpi_pinctrl_of_match);
>>
>> +static const struct dev_pm_ops lpi_pinctrl_pm_ops = {
>> + RUNTIME_PM_OPS(pm_clk_suspend, pm_clk_resume, NULL)
>> +};
>> +
>> static struct platform_driver lpi_pinctrl_driver = {
>> .driver = {
>> - .name = "qcom-sm8250-lpass-lpi-pinctrl",
>> - .of_match_table = lpi_pinctrl_of_match,
>> + .name = "qcom-sm8250-lpass-lpi-pinctrl",
>> + .of_match_table = lpi_pinctrl_of_match,
>> + .pm = pm_ptr(&lpi_pinctrl_pm_ops),
>
> Incorrect indentation
ACK, fixed in V5.
>
>> },
>> .probe = lpi_pinctrl_probe,
>> .remove = lpi_pinctrl_remove,
>> diff --git a/drivers/pinctrl/qcom/pinctrl-sm8450-lpass-lpi.c b/drivers/pinctrl/qcom/pinctrl-sm8450-lpass-lpi.c
>> index 439f6541622e..a79f99ec6df9 100644
>> --- a/drivers/pinctrl/qcom/pinctrl-sm8450-lpass-lpi.c
>> +++ b/drivers/pinctrl/qcom/pinctrl-sm8450-lpass-lpi.c
>> @@ -6,6 +6,8 @@
>> #include <linux/gpio/driver.h>
>> #include <linux/module.h>
>> #include <linux/platform_device.h>
>> +#include <linux/pm_clock.h>
>> +#include <linux/pm_runtime.h>
>>
>> #include "pinctrl-lpass-lpi.h"
>>
>> @@ -202,10 +204,15 @@ static const struct of_device_id lpi_pinctrl_of_match[] = {
>> };
>> MODULE_DEVICE_TABLE(of, lpi_pinctrl_of_match);
>>
>> +static const struct dev_pm_ops lpi_pinctrl_pm_ops = {
>> + RUNTIME_PM_OPS(pm_clk_suspend, pm_clk_resume, NULL)
>> +};
>> +
>> static struct platform_driver lpi_pinctrl_driver = {
>> .driver = {
>> - .name = "qcom-sm8450-lpass-lpi-pinctrl",
>> - .of_match_table = lpi_pinctrl_of_match,
>> + .name = "qcom-sm8450-lpass-lpi-pinctrl",
>> + .of_match_table = lpi_pinctrl_of_match,
>> + .pm = pm_ptr(&lpi_pinctrl_pm_ops),
>
> Incorrect indentation
ACK, fixed in V5.
>
>> },
>> .probe = lpi_pinctrl_probe,
>> .remove = lpi_pinctrl_remove,
>> diff --git a/drivers/pinctrl/qcom/pinctrl-sm8550-lpass-lpi.c b/drivers/pinctrl/qcom/pinctrl-sm8550-lpass-lpi.c
>> index 73065919c8c2..9037ef0020da 100644
>> --- a/drivers/pinctrl/qcom/pinctrl-sm8550-lpass-lpi.c
>> +++ b/drivers/pinctrl/qcom/pinctrl-sm8550-lpass-lpi.c
>> @@ -6,6 +6,8 @@
>> #include <linux/gpio/driver.h>
>> #include <linux/module.h>
>> #include <linux/platform_device.h>
>> +#include <linux/pm_clock.h>
>> +#include <linux/pm_runtime.h>
>>
>> #include "pinctrl-lpass-lpi.h"
>>
>> @@ -210,10 +212,15 @@ static const struct of_device_id lpi_pinctrl_of_match[] = {
>> };
>> MODULE_DEVICE_TABLE(of, lpi_pinctrl_of_match);
>>
>> +static const struct dev_pm_ops lpi_pinctrl_pm_ops = {
>> + RUNTIME_PM_OPS(pm_clk_suspend, pm_clk_resume, NULL)
>> +};
>> +
>> static struct platform_driver lpi_pinctrl_driver = {
>> .driver = {
>> - .name = "qcom-sm8550-lpass-lpi-pinctrl",
>> - .of_match_table = lpi_pinctrl_of_match,
>> + .name = "qcom-sm8550-lpass-lpi-pinctrl",
>> + .of_match_table = lpi_pinctrl_of_match,
>> + .pm = pm_ptr(&lpi_pinctrl_pm_ops),
>
> Incorrect indentation
ACK, fixed in V5.
>
>> },
>> .probe = lpi_pinctrl_probe,
>> .remove = lpi_pinctrl_remove,
>> diff --git a/drivers/pinctrl/qcom/pinctrl-sm8650-lpass-lpi.c b/drivers/pinctrl/qcom/pinctrl-sm8650-lpass-lpi.c
>> index f9fcedf5a65d..513ddc99dd37 100644
>> --- a/drivers/pinctrl/qcom/pinctrl-sm8650-lpass-lpi.c
>> +++ b/drivers/pinctrl/qcom/pinctrl-sm8650-lpass-lpi.c
>> @@ -6,6 +6,8 @@
>> #include <linux/gpio/driver.h>
>> #include <linux/module.h>
>> #include <linux/platform_device.h>
>> +#include <linux/pm_clock.h>
>> +#include <linux/pm_runtime.h>
>>
>> #include "pinctrl-lpass-lpi.h"
>>
>> @@ -217,10 +219,15 @@ static const struct of_device_id lpi_pinctrl_of_match[] = {
>> };
>> MODULE_DEVICE_TABLE(of, lpi_pinctrl_of_match);
>>
>> +static const struct dev_pm_ops lpi_pinctrl_pm_ops = {
>> + RUNTIME_PM_OPS(pm_clk_suspend, pm_clk_resume, NULL)
>> +};
>> +
>> static struct platform_driver lpi_pinctrl_driver = {
>> .driver = {
>> - .name = "qcom-sm8650-lpass-lpi-pinctrl",
>> - .of_match_table = lpi_pinctrl_of_match,
>> + .name = "qcom-sm8650-lpass-lpi-pinctrl",
>> + .of_match_table = lpi_pinctrl_of_match,
>> + .pm = pm_ptr(&lpi_pinctrl_pm_ops),
>
> Incorrect indentation
ACK, fixed in V5.
Thanks
Ajay Kumar
>
>> },
>> .probe = lpi_pinctrl_probe,
>> .remove = lpi_pinctrl_remove,
>> --
>> 2.34.1
>>
>
next prev parent reply other threads:[~2026-05-13 13:55 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-08 11:36 [PATCH v3 0/2] pinctrl: qcom: lpass-lpi: Switch to PM clock framework Ajay Kumar Nandam
2026-05-08 11:36 ` [PATCH v3 1/2] pinctrl: qcom: lpass-lpi: Enable runtime PM hooks on remaining SoCs Ajay Kumar Nandam
2026-05-08 13:41 ` Konrad Dybcio
2026-05-13 13:50 ` Ajay Kumar Nandam
2026-05-13 12:48 ` Dmitry Baryshkov
2026-05-13 13:55 ` Ajay Kumar Nandam [this message]
2026-05-08 11:36 ` [PATCH v3 2/2] pinctrl: qcom: lpass-lpi: Switch to PM clock framework for runtime PM Ajay Kumar Nandam
2026-05-08 13:40 ` Konrad Dybcio
2026-05-13 13:49 ` Ajay Kumar Nandam
2026-05-13 12:25 ` [PATCH v4 0/2] pinctrl: qcom: lpass-lpi: Switch to PM clock framework Ajay Kumar Nandam
2026-05-13 12:25 ` [PATCH v4 1/2] pinctrl: qcom: lpass-lpi: Enable runtime PM hooks on LPASS LPI SoCs Ajay Kumar Nandam
2026-05-13 12:51 ` Dmitry Baryshkov
2026-05-13 13:53 ` Ajay Kumar Nandam
2026-05-13 12:25 ` [PATCH v4 2/2] pinctrl: qcom: lpass-lpi: Switch to PM clock framework for runtime PM Ajay Kumar Nandam
2026-05-13 12:52 ` Dmitry Baryshkov
2026-05-13 13:53 ` Ajay Kumar Nandam
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8cdca0cf-7b36-4aef-bc93-c611611b32b7@oss.qualcomm.com \
--to=ajay.nandam@oss.qualcomm.com \
--cc=andersson@kernel.org \
--cc=dmitry.baryshkov@oss.qualcomm.com \
--cc=linusw@kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox