From: Markus Elfring <Markus.Elfring@web.de>
To: vulab@iscas.ac.cn, brcm80211-dev-list.pdl@broadcom.com,
brcm80211@lists.linux.dev, linux-wireless@vger.kernel.org
Cc: stable@vger.kernel.org, LKML <linux-kernel@vger.kernel.org>,
"Arend van Spriel" <arend.vanspriel@broadcom.com>,
"Christophe Jaillet" <christophe.jaillet@wanadoo.fr>,
"Kalle Valo" <kvalo@kernel.org>, "Ondřej Jirman" <megi@xff.cz>,
"Sai Krishna" <saikrishnag@marvell.com>
Subject: Re: [PATCH] brcm80211: fmac: Add error check for brcmf_usb_dlneeded()
Date: Wed, 9 Apr 2025 10:16:34 +0200 [thread overview]
Message-ID: <8cf4d7d5-e9f8-4c10-810b-5c7da72db1c8@web.de> (raw)
In-Reply-To: <20250406081930.2909-1-vulab@iscas.ac.cn>
…
> Add error handling for brcmf_usb_dl_cmd() to return the function if the
> 'id.chiprev' is uninitialized.
* Please reconsider the offered conclusion once more.
* I propose to replace the word “for” by “in” (before function names)
in some summary phrases.
…
> +++ b/drivers/net/wireless/broadcom/brcm80211/brcmfmac/usb.c
…
> @@ -798,7 +799,11 @@ brcmf_usb_dlneeded(struct brcmf_usbdev_info *devinfo)
>
> /* Check if firmware downloaded already by querying runtime ID */
> id.chip = cpu_to_le32(0xDEAD);
> - brcmf_usb_dl_cmd(devinfo, DL_GETVER, &id, sizeof(id));
> + err = brcmf_usb_dl_cmd(devinfo, DL_GETVER, &id, sizeof(id));
> + if (err) {
> + brcmf_err("DL_GETID Failed\n");
> + return false;
> + }
…
Would an error hint like “DL_GETVER failed\n” be more appropriate here?
Regards,
Markus
next prev parent reply other threads:[~2025-04-09 8:16 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-04-06 8:19 [PATCH] brcm80211: fmac: Add error check for brcmf_usb_dlneeded() Wentao Liang
2025-04-09 8:16 ` Markus Elfring [this message]
2025-04-09 12:11 ` Arend van Spriel
2025-04-09 15:03 ` Arend Van Spriel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8cf4d7d5-e9f8-4c10-810b-5c7da72db1c8@web.de \
--to=markus.elfring@web.de \
--cc=arend.vanspriel@broadcom.com \
--cc=brcm80211-dev-list.pdl@broadcom.com \
--cc=brcm80211@lists.linux.dev \
--cc=christophe.jaillet@wanadoo.fr \
--cc=kvalo@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=megi@xff.cz \
--cc=saikrishnag@marvell.com \
--cc=stable@vger.kernel.org \
--cc=vulab@iscas.ac.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox