From: Javier Carrasco <javier.carrasco@wolfvision.net>
To: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>,
Javier Carrasco <javier.carrasco.cruz@gmail.com>,
Alessandro Zummo <a.zummo@towertech.it>,
Alexandre Belloni <alexandre.belloni@bootlin.com>,
Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Conor Dooley <conor+dt@kernel.org>,
Chris Verges <chrisv@cyberswitching.com>
Cc: linux-rtc@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] dt-bindings: rtc: pcf2123: convert to YAML
Date: Mon, 11 Sep 2023 10:27:20 +0200 [thread overview]
Message-ID: <8d1a49ac-3abc-5b75-34b0-9573971e61da@wolfvision.net> (raw)
In-Reply-To: <f0224983-d276-8d9c-f6ce-bd77f350bc3c@linaro.org>
On 11.09.23 08:17, Krzysztof Kozlowski wrote:
> On 10/09/2023 13:00, Javier Carrasco wrote:
>> Convert the existing txt binding to the preferred YAML format.
>>
>
>> +unevaluatedProperties: false
>> +
>> +examples:
>> + - |
>> + spi {
>> + #address-cells = <1>;
>> + #size-cells = <0>;
>> +
>> + rtc@3 {
>> + compatible = "nxp,pcf2123";
>> + reg = <3>;
>> + spi-cs-high;
>
> Example should be complete, so preferably also with interrupts.
>
> Anyway:
>
> Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
>
> Best regards,
> Krzysztof
>
Thank you for the review. You are right, adding a line to complete the
example with an interrupt does not cost much. I will add it for v2 and
wait a few days in case I should change the maintainer.
Best regards,
Javier Carrasco
prev parent reply other threads:[~2023-09-11 21:39 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-10 11:00 [PATCH] dt-bindings: rtc: pcf2123: convert to YAML Javier Carrasco
2023-09-10 12:17 ` Alexandre Belloni
2023-09-10 12:31 ` Javier Carrasco
2023-09-11 8:43 ` Javier Carrasco
2023-09-11 6:17 ` Krzysztof Kozlowski
2023-09-11 8:27 ` Javier Carrasco [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8d1a49ac-3abc-5b75-34b0-9573971e61da@wolfvision.net \
--to=javier.carrasco@wolfvision.net \
--cc=a.zummo@towertech.it \
--cc=alexandre.belloni@bootlin.com \
--cc=chrisv@cyberswitching.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=javier.carrasco.cruz@gmail.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=krzysztof.kozlowski@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rtc@vger.kernel.org \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox