From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-oo1-f45.google.com (mail-oo1-f45.google.com [209.85.161.45]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 94AEE397929 for ; Tue, 4 Aug 2026 12:43:08 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.161.45 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785847390; cv=none; b=O6eouhWwr1FUQwnjRWtUNEALOj2lr+H01ZzIn9xQg441FeViCm381nBjoKLWmrcFok+nm6BrpFAsw3rxz5rImzNufTvYHfonejlavIoouhcfyp7IsaROirU5HV3qisvEL5ZFARcUGJFALdyP2tBgrXi1H3XMOKdhR6janlf3Q1c= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785847390; c=relaxed/simple; bh=DtXh/mlNFR+bCLuXlTNfTGrdyML0sHf41b1CPtvxdZw=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=iTNl6uarmfZHA/lEzr/ct6ohgwga0X2NcHubJgBd8In1hgPLo9pCNh8KYWsMEJuQTZcfsYfnegMNASUIMqqs3zISqBAWxkfUoX5H/UOuDML94z7R7cJNFwDeAggxTSLqOLsI9imaDpPkZTFo/3hroq2kSkr3TBYTP/mNbUfkOyE= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=ZKLbcYcG; arc=none smtp.client-ip=209.85.161.45 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="ZKLbcYcG" Received: by mail-oo1-f45.google.com with SMTP id 006d021491bc7-6aae90e595fso1965727eaf.1 for ; Tue, 04 Aug 2026 05:43:08 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1785847387; x=1786452187; darn=vger.kernel.org; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:from:to:cc:subject:date:message-id:reply-to :content-type; bh=hhSW4//mX9v1/R7JRR+WipUpRRwR6Gq7OCxzrdqwGgs=; b=ZKLbcYcGIiKwez9HU3ik4IX44WSMDVwFkW6wZw7zBiLMWSUXPCd+ExQHocOXShUet6 o2X3FHI/P0cdEG4cpnbjf6BrvFdvaF/A+Rw5dIfec234Chz734ZLefEy9Qhy0Fftf/LA JIpnoVawgpt42wIfy4qd980i5dvkwLEny9D1qoOGngFHYDzFwb1g3mnqoUUCbZIqzmdy pRXkXueO9Xdub53HS1hprmLgqp4S1fpA3iLfo/4099BRdgNdlKBLtfq1D8UUvrIBOZmX pxg8H+ClX8abNurOzlNrika+hQbZtr4CZqQCcgkLk0q8qaVExflOsPvlWOK5bCV0gcwP 5Kwg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1785847387; x=1786452187; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=hhSW4//mX9v1/R7JRR+WipUpRRwR6Gq7OCxzrdqwGgs=; b=YZtBAq+/EpQcIfnAv9DWTJ9uxbRIfx3UowOQzWGUlBajOiiyBTEmiL9LwR7SNEtR9L h8QsGxQsZVrbc1s2cC60AQvD5nS7mEOGhiDhfpzsNA4Nqs9MT42cFuh7f/v2z4ncj74a I4U/2nmEJISHslB9K/VBy7Z/wYAVQlkaxSRDdcOkWrMxGPtSf7iWDJzXdZhFnab94qWE Bnh/qKAYmyKyjxoWvFQJlDIAXkkDLv5xQBGz0WOAgrRRZEH98TnUUUExYSBCjLIampj3 E6v7ymfbfrJhFO/JG4Jzel9Y348Qw8vhgDGY670mriR2kWjct22L9mMGmPjGuD0UTtvt CWMg== X-Forwarded-Encrypted: i=1; AHgh+Ro/oAJ1lbwypuwM3iqAsDbDRfjljjYRQLIMKihAXto73B8mRFyS/0L7Orsvn/IWHBwHNw7s3n/wFA3A5No=@vger.kernel.org X-Gm-Message-State: AOJu0Yy4yu0tSurghfIUD7iGA3WGXuWKDbmrkkxl4IPPzkYW+LSPyz6F Zs7IWlzxzDo4REaO4pYZQD+PuoeM2QGEsCWOxGQOWVtIrFVbU8R43o6t X-Gm-Gg: AR+sD1112QWT9u3uqezxvQqs1u+q/Wfpft0VUQxCuN4W+5mlhqEqmeHQRrgcCJBArKu MAZDjDxst+K34eDYznYHKcTLfb3RqLFeeyYpjXZfLRZ3XkhoFQWma+ugK6OwiEEpPd5PTvg8AAZ w/JuQFQu2cJUxbPP/nfHQZaQ0a08eywL/Q+KKIYVgchaju0/2E5m4RXJe+HEl4yXk1p7Tn1NtnD Oz9WNVMr0ckuU4kqZJiesuUm+9++y+7uQDljoFoHah9NufPJxZDKvM3hjJ2ebBKK/umgBvDg4RI SrJMJ9e06UBOxw6CeEdHECHw3PuzY9cpEUN4MWRPaU805faedrFTGUMt5JHFMeqW+cVS2z+BRqn qcwNb5Zgtv2Bg5+RIJMdelmtvP/ZHnIQbJsMnbZVD0Wqhj3rIVXBMWWcNinzQ0f5uaH6KQp3Bvv V5bzcyhENBl7GOR/GowsdpgauZ9TjH+EoZH+raYsxMNQZ7EV++sB4UHe6LaSzPV2t3qrQ5+n3Q X-Received: by 2002:a05:6820:61a:b0:69e:42fd:4070 with SMTP id 006d021491bc7-6ae431e0e4dmr17186032eaf.8.1785847382595; Tue, 04 Aug 2026 05:43:02 -0700 (PDT) Received: from [172.20.10.7] ([117.20.149.92]) by smtp.gmail.com with ESMTPSA id 006d021491bc7-6ae3a31d93esm8556474eaf.14.2026.08.04.05.42.56 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 04 Aug 2026 05:43:02 -0700 (PDT) Message-ID: <8d256ca9-9291-4151-a329-d0b9bf101a72@gmail.com> Date: Tue, 4 Aug 2026 20:42:54 +0800 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] bpf: add KF_SPIN_LOCK flag for kfuncs under bpf_spin_lock To: Kumar Kartikeya Dwivedi , Kaitao Cheng , Alexei Starovoitov , Daniel Borkmann , Andrii Nakryiko , Eduard Zingerman , Martin KaFai Lau , Song Liu , Yonghong Song , Jiri Olsa , Emil Tsalapatis , John Fastabend , Ihor Solodrai Cc: bpf@vger.kernel.org, linux-kernel@vger.kernel.org, Kaitao Cheng References: <20260804083212.79271-1-kaitao.cheng@linux.dev> <4aa061ed-6640-42b4-9f12-e33edb8ba1b2@linux.dev> Content-Language: en-US From: Leon Hwang In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 2026/8/4 18:22, Kumar Kartikeya Dwivedi wrote: > On Tue Aug 4, 2026 at 12:09 PM CEST, Kaitao Cheng wrote: [...] >> >> Alternatively, following the naming of GFP_ATOMIC, could we call it KF_ATOMIC? > > I think that is also confusing, every kfunc is allowed in atomic context in > general. E.g. bpf_map_update_elem() in spin lock critical section would be > problematic (due to embedded bpf_spin_lock in map value surfacing a deadlock > opportunity). KF_OK_IN_SPIN_LOCK_CS is another option, but slightly longer than > the previous proposal. > > In any case, let's choose this or the former one, and not fret too much about > the naming. We can also choose a better name later on. > KF_LOCK_SAFE? Since other kfuncs are lock-unsafe for verifier. Thanks, Leon