From: Daniel Lezcano <daniel.lezcano@linaro.org>
To: Viresh Kumar <viresh.kumar@linaro.org>
Cc: rjw@rjwysocki.net, edubezval@gmail.com, kevin.wangtao@linaro.org,
leo.yan@linaro.org, vincent.guittot@linaro.org,
linux-kernel@vger.kernel.org, javi.merino@kernel.org,
rui.zhang@intel.com, linux-pm@vger.kernel.org,
daniel.thompson@linaro.org
Subject: Re: [PATCH V4] powercap/drivers/idle_injection: Add an idle injection framework
Date: Tue, 5 Jun 2018 08:53:36 +0200 [thread overview]
Message-ID: <8d29a3c2-056c-3a70-3ecf-56cdf6e37931@linaro.org> (raw)
In-Reply-To: <20180605055334.mnffwgcvca3zzwub@vireshk-i7>
On 05/06/2018 07:53, Viresh Kumar wrote:
> On 05-06-18, 07:48, Daniel Lezcano wrote:
>> As soon as we reach complete(), no timer can be set because of the
>> condition before.
>
> Why not ? We aren't using any locks here and it is possible that run_duration_ms
> is set to 0 from idle_injection_stop() only after the first thread has restarted
> the hrtimer. Isn't it ?
If he restarted the timer, complete() won't be called and
idle_injection_stop() will wait until the idle cycle injection is finished.
--
<http://www.linaro.org/> Linaro.org │ Open source software for ARM SoCs
Follow Linaro: <http://www.facebook.com/pages/Linaro> Facebook |
<http://twitter.com/#!/linaroorg> Twitter |
<http://www.linaro.org/linaro-blog/> Blog
next prev parent reply other threads:[~2018-06-05 6:53 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-05-25 9:49 [PATCH V4] powercap/drivers/idle_injection: Add an idle injection framework Daniel Lezcano
2018-05-29 9:31 ` Viresh Kumar
2018-05-31 18:25 ` Daniel Lezcano
2018-06-05 5:14 ` Viresh Kumar
2018-06-05 5:48 ` Daniel Lezcano
2018-06-05 5:53 ` Viresh Kumar
2018-06-05 6:53 ` Daniel Lezcano [this message]
2018-06-05 10:05 ` Viresh Kumar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8d29a3c2-056c-3a70-3ecf-56cdf6e37931@linaro.org \
--to=daniel.lezcano@linaro.org \
--cc=daniel.thompson@linaro.org \
--cc=edubezval@gmail.com \
--cc=javi.merino@kernel.org \
--cc=kevin.wangtao@linaro.org \
--cc=leo.yan@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=rjw@rjwysocki.net \
--cc=rui.zhang@intel.com \
--cc=vincent.guittot@linaro.org \
--cc=viresh.kumar@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).