From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B1E2D265606 for ; Wed, 25 Mar 2026 15:21:00 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774452060; cv=none; b=rLx9CDfU/SvhnE7xR1huU0gUk7CerQUzfnZwPKg2dtnx546HsverkFkNSOhG4IU83TFCUMLgMU/LZ4nsRkmiCXc6gGOQeFgnSwxTDqgT+AehfI0F/6y1ueXqKxs5ui/4p7r7DyGZ4uT57zTeZK4i5Q9CmPHq9cBKuoiDfDYRVJQ= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774452060; c=relaxed/simple; bh=27h46b3j9DijQ/Ik+vVFMkoOTVwU8O9sVthj0b5oE18=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=oUKNsowd1VMU3pCwMKuAVHWdhu4bQyCMhadbauDdL/LxaVkFMeP3fxlxzOvBmY9m63dgdS3ptOwQsna83Bm/8MjHh+UjaGj9Hpx8PAkdHf8TtUU2ikG2zdZhl/a1uFKslcaAsWF4zd6aQ/WHqhmqP15GK3GBWPlw9ZfisUWkgQE= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=c7Nmi5Ur; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="c7Nmi5Ur" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 90231C4CEF7; Wed, 25 Mar 2026 15:20:57 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1774452060; bh=27h46b3j9DijQ/Ik+vVFMkoOTVwU8O9sVthj0b5oE18=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=c7Nmi5Urec3RhO+Ohugiu0N+6vBJK+jWCqGxt/tJoJ0blUCcXNu4tTQdAXfrkBvvT Q0oPXSSMXvg6XBv0NARx2rD1ipNO9V6NmryU71RMOgTFXLh3rfRDDpflDw+71EVt7i 8vOH5Cf6yjqgx6XDHk0rY+G9r0HE6B4V4pSvpdS+LZwDXqyhMqHNSdOfWgcU6nF0xf LvM1wlarL2BdtBVK1W7wfgw00PgG7RGwArkstORlDKSOi2It1UwZcLFNzpteU5+jiP +wtHngzVUSEGDUwkwECknv4N6IqoTdEzQ8uvwdRGhtm46gJWHTW6GgBOQBuCKpBALV wcKqbUq3hI7XA== Date: Wed, 25 Mar 2026 15:20:55 +0000 From: "Lorenzo Stoakes (Oracle)" To: "David Hildenbrand (Arm)" Cc: Andrew Morton , Vernon Yang , Wei Yang , lorenzo.stoakes@oracle.com, ziy@nvidia.com, dev.jain@arm.com, baohua@kernel.org, lance.yang@linux.dev, linux-mm@kvack.org, linux-kernel@vger.kernel.org, Vernon Yang Subject: Re: [PATCH mm-new v8 2/4] mm: khugepaged: refine scan progress number Message-ID: <8d2e809c-e4c8-4d35-a2ae-62777b6dfbcc@lucifer.local> References: <20260221093918.1456187-3-vernon2gm@gmail.com> <20260224035247.r6mxsfcpiev4wnce@master> <1da56bbb-9211-42d7-9b08-3ee56d2b538d@kernel.org> <8a5277e0-d70e-4849-9763-ed90e350a118@kernel.org> <22dccc17-787c-448e-a571-23c7a9afeaff@lucifer.local> <20260325080930.a205fca9e7e61c4a793f5228@linux-foundation.org> <3cf94628-3c6a-43ed-9fc1-29bd5a911497@kernel.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <3cf94628-3c6a-43ed-9fc1-29bd5a911497@kernel.org> On Wed, Mar 25, 2026 at 04:17:21PM +0100, David Hildenbrand (Arm) wrote: > On 3/25/26 16:09, Andrew Morton wrote: > > On Wed, 25 Mar 2026 14:10:23 +0000 "Lorenzo Stoakes (Oracle)" wrote: > > > >>> No need to update the patch description. > >> > >> I will take a look at this (sorry for delay) but general point - while > >> fix-patches are convenient, they're incredibly anti-reviewer. > > +1, I could have sworn we brought that up before. :) > > >> > >> I hope at some point in the future we can move away from that so you can look at > >> a series on list and know that what's shown there is the actual patch. > > > > Oh. I've never really received that message, at least not at all > > clearly. > > > > I've been hoping that the -fix patches are actually pro-reviewer, for > > those reviewers who have looked at the previous version. A full resend > > of something you've already looked at is quite annoying! > > > > I try to mitigate that by sending the > > heres-what-you-changed-since-last-time replies. It's a little more > > work at this end, but that's not at all a problem. > > > > I see a couple of options here > > > > a) I can fold the -fix into the base patch then send out the > > resulting diff as a reply-to-all. > > > > b) We can just deprecate the -fix things and ask people for full > > resends. > > > > It depends on what people prefer. How do we determine that? > > I like "fix" for smaller "obvious" stuff where a resend is really just > noise. > > But for bigger stuff I prefer a full resend (we can still have these > temporary fixups, but for reviewers a follow-up resend is better). Yeah, it's really about being able to come to a series later and be able to comment line-by-line. Really larger stuff should be resent I think, esp. if there's multiple fixes in the series. A reply with the same-patch-but-with-fix-applied would definitely be useful! > > -- > Cheers, > > David Thanks, Lorenzo