From: Eli Billauer <eli.billauer@gmail.com>
To: Salah Triki <salah.triki@gmail.com>,
Arnd Bergmann <arnd@arndb.de>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3] char: xillybus: Replace deprecated MSI API
Date: Fri, 18 Jul 2025 16:19:49 +0200 [thread overview]
Message-ID: <8d3513e3-6294-b6df-189a-cc3bee76f0a3@outbound.gmail.com> (raw)
In-Reply-To: <aHmbnFJXWMWgS5Lk@pc>
Hello,
On 18/07/2025 2:55, Salah Triki wrote:
> +static void xilly_pci_free_irq_vectors(void *data)
> +{
> + pci_free_irq_vectors(data);
> +}
> +
I'm sorry, but I have mislead you: The call to pci_free_irq_vectors() is
done automatically by the kernel's own pcim_msi_release() function if
the device is managed, which it is. So the driver is functionally
correct in this matter as is. The only remaining issue is the deprecated
API.
I discovered this using ftrace on the relevant functions in the kernel,
as I was preparing for testing your patch against hardware.
Regards,
Eli
next prev parent reply other threads:[~2025-07-18 14:19 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-07-16 19:39 [PATCH] char: xillybus: Replace deprecated MSI API Salah Triki
2025-07-17 13:51 ` Eli Billauer
2025-07-17 16:26 ` [PATCH v2] " Salah Triki
2025-07-18 0:55 ` [PATCH v3] " Salah Triki
2025-07-18 14:19 ` Eli Billauer [this message]
2025-07-19 4:51 ` [PATCH v4] " Salah Triki
2025-07-19 12:22 ` Eli Billauer
2025-07-19 12:35 ` Salah Triki
2025-07-20 8:33 ` Greg Kroah-Hartman
2025-07-20 8:56 ` Salah Triki
2025-07-20 9:07 ` Greg Kroah-Hartman
2025-07-20 17:03 ` Salah Triki
2025-07-21 5:41 ` Greg Kroah-Hartman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8d3513e3-6294-b6df-189a-cc3bee76f0a3@outbound.gmail.com \
--to=eli.billauer@gmail.com \
--cc=arnd@arndb.de \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=salah.triki@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).