From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.1 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 69576C4363D for ; Tue, 6 Oct 2020 22:31:30 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id EA01F206FC for ; Tue, 6 Oct 2020 22:31:29 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1602023490; bh=jhzW9Fgg7Fcmo0v89kQJUVuxxtbMujFQkJeDd2Xwsbw=; h=Subject:To:Cc:References:From:Date:In-Reply-To:List-ID:From; b=oxKqHmhNcC2rL+v8dIaFUmSQWaZ2ZrBOCEzjWtUaRgp7V6jeeJiARuSoZGP2wc67V 8wcOCvlIWBBE8Z6h/geufU6Z71HwiwsDye1AGNKReewTCnrtbQaEsWF2/Yrqh/QPOx pX7t7dVTvgA8KJc/WJr0gysUt0pTWjIrcPj3nwTw= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727254AbgJFWb2 (ORCPT ); Tue, 6 Oct 2020 18:31:28 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:53564 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726323AbgJFWb2 (ORCPT ); Tue, 6 Oct 2020 18:31:28 -0400 Received: from mail-io1-xd42.google.com (mail-io1-xd42.google.com [IPv6:2607:f8b0:4864:20::d42]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 2E7BBC061755 for ; Tue, 6 Oct 2020 15:31:28 -0700 (PDT) Received: by mail-io1-xd42.google.com with SMTP id m17so264087ioo.1 for ; Tue, 06 Oct 2020 15:31:28 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linuxfoundation.org; s=google; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=merY9ASuRAU3zfTS2gZnDNq8Wwv3Ib+nkHis31YHECs=; b=fnaviWr41bfPN7IlaF3jqU4F371ghNXPuXLMU0b4pvfZGAuR5+iWMteCxXqhyQcznL 0SI4gLcDhJ/2bG85y68hGfil/zZV56HJ8Lwi3v8dGWPYc9t6AfFV6zgSc/+21xvnF4R4 Nn9C1F8OI86IvtFl77NL2qL5N57fkMeDKZllA= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=merY9ASuRAU3zfTS2gZnDNq8Wwv3Ib+nkHis31YHECs=; b=CMwGxSUdu1MXzC1mYNu3JWT9uPy+m0SGbYFkYYauDO1+NUdMA9VetPlKzLFa4jq4Gx H++oWIVImTy4n0Q8ueo7Z1XIb3LSIztLuCcgKW/2MqaRDw5whh9YNBVr/qsvIlAK70qZ JWsGH5rerXrYDRZ9iKYqbaXZY6Ya/h9a0k0gaoTf80ZDZ2B71Zj+TKRZX6LX5ZPrgzeN b8EA2sk09rDMYDPAruGWn/KipcO9hzahi+HMaHYAPd41cVjFw1RjT/oZLmxZPFMqdG3N /SRUgJ/h9n5HnW4Z0bmmCusm/427Dga+kGW/UlByTAsCwwlmE/2ZlL0a6FdcSJMjRIKy kouw== X-Gm-Message-State: AOAM5338z5rurhLu4zJ17j5kmmQhrSlTF2WRRyTFcuLXBhH2slZxE5Sm PX/ojPjguGhfEDeaMfl9wHtqow== X-Google-Smtp-Source: ABdhPJw1ONzTpjA0EnLvPODLhxTqiWsX2OSj8ZKDLEQYmAzMFjM19HjPi8Ng+mFpHC9uQqKX8GiDgQ== X-Received: by 2002:a02:a802:: with SMTP id f2mr368210jaj.47.1602023487397; Tue, 06 Oct 2020 15:31:27 -0700 (PDT) Received: from [192.168.1.112] (c-24-9-64-241.hsd1.co.comcast.net. [24.9.64.241]) by smtp.gmail.com with ESMTPSA id v9sm20040ioq.41.2020.10.06.15.31.25 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 06 Oct 2020 15:31:26 -0700 (PDT) Subject: Re: [PATCH] usbip: vhci_hcd: fix calling usb_hcd_giveback_urb() with irqs enabled To: Andrey Konovalov Cc: Valentina Manea , Shuah Khan , Greg Kroah-Hartman , Alan Stern , USB list , LKML , Shuah Khan References: <20201006215147.35146-1-skhan@linuxfoundation.org> From: Shuah Khan Message-ID: <8d485cef-3a99-03da-1307-9569df0659e1@linuxfoundation.org> Date: Tue, 6 Oct 2020 16:31:25 -0600 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 10/6/20 4:16 PM, Andrey Konovalov wrote: > On Tue, Oct 6, 2020 at 11:51 PM Shuah Khan wrote: >> >> Fix the following warning from kcov regarding usb_hcd_giveback_urb() >> call being made without disabling interrupts. > > Hi Shuah, > > This won't fix the kcov warning, as it still requires its own fix, > which I'll send separately. But this will fix the improper usage of > usb_hcd_giveback_urb() in USB/IP. > Yes you are right, I will record message to remove the wording in my v2. I should add the link to discussion anyway. thanks, -- Shuah