* [PATCH net v3] net: ti: icssg-prueth: Fix error cleanup on failing pruss_request_mem_region
@ 2023-11-10 16:13 Jan Kiszka
2023-11-11 16:11 ` Roger Quadros
2023-11-11 19:51 ` patchwork-bot+netdevbpf
0 siblings, 2 replies; 3+ messages in thread
From: Jan Kiszka @ 2023-11-10 16:13 UTC (permalink / raw)
To: David S. Miller, Eric Dumazet, Jakub Kicinski, Paolo Abeni,
MD Danish Anwar
Cc: netdev, linux-kernel, Lopes Ivo, Diogo Miguel (T CED IFD-PT),
Nishanth Menon, Su, Bao Cheng (RC-CN DF FA R&D),
Wojciech Drewek, Roger Quadros
From: Jan Kiszka <jan.kiszka@siemens.com>
We were just continuing in this case, surely not desired.
Fixes: 128d5874c082 ("net: ti: icssg-prueth: Add ICSSG ethernet driver")
Signed-off-by: Jan Kiszka <jan.kiszka@siemens.com>
Reviewed-by: Wojciech Drewek <wojciech.drewek@intel.com>
---
Changes in v3:
- no functional ones
- added original author in CC with new address
Changes in v2:
- add proper tags
drivers/net/ethernet/ti/icssg/icssg_prueth.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/drivers/net/ethernet/ti/icssg/icssg_prueth.c b/drivers/net/ethernet/ti/icssg/icssg_prueth.c
index 3abbeba26f1b..411898a4f38c 100644
--- a/drivers/net/ethernet/ti/icssg/icssg_prueth.c
+++ b/drivers/net/ethernet/ti/icssg/icssg_prueth.c
@@ -2063,7 +2063,7 @@ static int prueth_probe(struct platform_device *pdev)
&prueth->shram);
if (ret) {
dev_err(dev, "unable to get PRUSS SHRD RAM2: %d\n", ret);
- pruss_put(prueth->pruss);
+ goto put_pruss;
}
prueth->sram_pool = of_gen_pool_get(np, "sram", 0);
@@ -2215,6 +2215,8 @@ static int prueth_probe(struct platform_device *pdev)
put_mem:
pruss_release_mem_region(prueth->pruss, &prueth->shram);
+
+put_pruss:
pruss_put(prueth->pruss);
put_cores:
--
2.35.3
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH net v3] net: ti: icssg-prueth: Fix error cleanup on failing pruss_request_mem_region
2023-11-10 16:13 [PATCH net v3] net: ti: icssg-prueth: Fix error cleanup on failing pruss_request_mem_region Jan Kiszka
@ 2023-11-11 16:11 ` Roger Quadros
2023-11-11 19:51 ` patchwork-bot+netdevbpf
1 sibling, 0 replies; 3+ messages in thread
From: Roger Quadros @ 2023-11-11 16:11 UTC (permalink / raw)
To: Jan Kiszka, David S. Miller, Eric Dumazet, Jakub Kicinski,
Paolo Abeni, MD Danish Anwar
Cc: netdev, linux-kernel, Lopes Ivo, Diogo Miguel (T CED IFD-PT),
Nishanth Menon, Su, Bao Cheng (RC-CN DF FA R&D),
Wojciech Drewek
On 10/11/2023 18:13, Jan Kiszka wrote:
> From: Jan Kiszka <jan.kiszka@siemens.com>
>
> We were just continuing in this case, surely not desired.
>
> Fixes: 128d5874c082 ("net: ti: icssg-prueth: Add ICSSG ethernet driver")
> Signed-off-by: Jan Kiszka <jan.kiszka@siemens.com>
> Reviewed-by: Wojciech Drewek <wojciech.drewek@intel.com>
Reviewed-by: Roger Quadros <rogerq@kernel.org>
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH net v3] net: ti: icssg-prueth: Fix error cleanup on failing pruss_request_mem_region
2023-11-10 16:13 [PATCH net v3] net: ti: icssg-prueth: Fix error cleanup on failing pruss_request_mem_region Jan Kiszka
2023-11-11 16:11 ` Roger Quadros
@ 2023-11-11 19:51 ` patchwork-bot+netdevbpf
1 sibling, 0 replies; 3+ messages in thread
From: patchwork-bot+netdevbpf @ 2023-11-11 19:51 UTC (permalink / raw)
To: Jan Kiszka
Cc: davem, edumazet, kuba, pabeni, danishanwar, netdev, linux-kernel,
diogo.ivo, nm, baocheng.su, wojciech.drewek, rogerq
Hello:
This patch was applied to netdev/net.git (main)
by David S. Miller <davem@davemloft.net>:
On Fri, 10 Nov 2023 17:13:08 +0100 you wrote:
> From: Jan Kiszka <jan.kiszka@siemens.com>
>
> We were just continuing in this case, surely not desired.
>
> Fixes: 128d5874c082 ("net: ti: icssg-prueth: Add ICSSG ethernet driver")
> Signed-off-by: Jan Kiszka <jan.kiszka@siemens.com>
> Reviewed-by: Wojciech Drewek <wojciech.drewek@intel.com>
>
> [...]
Here is the summary with links:
- [net,v3] net: ti: icssg-prueth: Fix error cleanup on failing pruss_request_mem_region
https://git.kernel.org/netdev/net/c/2bd5b559a1f3
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2023-11-11 19:52 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-11-10 16:13 [PATCH net v3] net: ti: icssg-prueth: Fix error cleanup on failing pruss_request_mem_region Jan Kiszka
2023-11-11 16:11 ` Roger Quadros
2023-11-11 19:51 ` patchwork-bot+netdevbpf
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox