From: Lakshmi Ramasubramanian <nramas@linux.microsoft.com>
To: Paul Moore <paul@paul-moore.com>, Mimi Zohar <zohar@linux.ibm.com>
Cc: linux-integrity@vger.kernel.org, tusharsu@linux.microsoft.com,
linux-kernel@vger.kernel.org, linux-audit@redhat.com
Subject: Re: [PATCH] IMA: Add log statements for failure conditions
Date: Fri, 5 Jun 2020 12:54:14 -0700 [thread overview]
Message-ID: <8dfb3fa6-5c1f-d644-7d21-72a9448c52cc@linux.microsoft.com> (raw)
In-Reply-To: <CAHC9VhS-EP=Kk3GKRzAGAYa5mqupkLQCHz_m_DgoAKRWcSTgLA@mail.gmail.com>
On 6/5/20 12:37 PM, Paul Moore wrote:
> If it's audit related, it's generally best to CC the linux-audit list,
> not just me (fixed).
>
> It's not clear to me what this pr_err() is trying to indicate other
> than *something* failed. Can someone provide some more background on
> this message?
process_buffer_measurement() is currently used to measure
"kexec command line", "keys", and "blacklist-hash". If there was any
error in the measurement, this pr_err() will indicate which of the above
measurement failed and the related error code.
Please let me know if you need more info on this one.
Since a pr_xyz() call was already present, I just wanted to change the
log level to keep the code change to the minimum. But if audit log is
the right approach for this case, I'll update.
thanks,
-lakshmi
next prev parent reply other threads:[~2020-06-05 19:54 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-04 16:32 [PATCH] IMA: Add log statements for failure conditions Lakshmi Ramasubramanian
2020-06-05 18:46 ` Mimi Zohar
2020-06-05 19:37 ` Paul Moore
2020-06-05 19:54 ` Lakshmi Ramasubramanian [this message]
2020-06-05 20:49 ` Paul Moore
2020-06-05 21:09 ` Lakshmi Ramasubramanian
2020-06-05 21:34 ` Mimi Zohar
2020-06-05 21:36 ` Lakshmi Ramasubramanian
-- strict thread matches above, loose matches on Subject: below --
2020-02-07 19:53 [PATCH] IMA: Updated KBUILD_MODNAME for IMA files to ima Tushar Sugandhi
2020-02-07 19:53 ` [PATCH] IMA: Add log statements for failure conditions Tushar Sugandhi
2020-02-09 12:57 ` Mimi Zohar
2020-02-10 2:46 ` Joe Perches
2020-02-10 16:40 ` Lakshmi Ramasubramanian
2020-02-10 16:50 ` Joe Perches
2020-02-10 21:42 ` Tushar Sugandhi
[not found] ` <0c9099b5-da29-3e71-0933-123dfe08442c@linux.microsoft.com>
2020-02-10 21:46 ` Mimi Zohar
2020-02-10 22:19 ` Tushar Sugandhi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8dfb3fa6-5c1f-d644-7d21-72a9448c52cc@linux.microsoft.com \
--to=nramas@linux.microsoft.com \
--cc=linux-audit@redhat.com \
--cc=linux-integrity@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=paul@paul-moore.com \
--cc=tusharsu@linux.microsoft.com \
--cc=zohar@linux.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox