From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-16.2 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4180AC433E0 for ; Thu, 11 Mar 2021 22:52:31 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id EDCD964F26 for ; Thu, 11 Mar 2021 22:52:30 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231144AbhCKWwA (ORCPT ); Thu, 11 Mar 2021 17:52:00 -0500 Received: from mail.kernel.org ([198.145.29.99]:42598 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229910AbhCKWv4 (ORCPT ); Thu, 11 Mar 2021 17:51:56 -0500 Received: by mail.kernel.org (Postfix) with ESMTPSA id 2E22664F26; Thu, 11 Mar 2021 22:51:55 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1615503115; bh=vntZGoqs0CqwH2BmBiZ/QL0YFTZvd8CMaMCrkmzsLCg=; h=Subject:From:To:Cc:Date:In-Reply-To:References:From; b=f+BMf0FazeCKv7+xE2a01FZyMKDgIawfrWTDN4xWxAzc2mfB71aO3C0KLvte4kma4 iROzJRsSfNj8KrEO0bqFAg0E2kwnoFKs3x/7IjXEM5v0xzw7kUI/95m8Xd9+HxkhTd 9at+Jpa4379HW1DRVl4e83r4Sc7zREp4lwLFYgtvxXJeczUDeL76RbOARydfVdF5Yq w1Qr1R3+mHFHjTOXf91syngUVHVI+wHFuUR1edJW8WktKkWC6sZ+Sj0Nebt9C2qyJL IALRiMTROT+dxsxol1TdkuLJw3skon/moH0QFZ1xvDs5WfJVBAZzD4GLJUH7HAstbM y6gsSKxweYxvg== Message-ID: <8dff1af3191e65e28615a2a3df5269bdaea18754.camel@kernel.org> Subject: Re: [PATCH] net: mellanox: mlx5: fix error return code in mlx5_fpga_device_start() From: Saeed Mahameed To: Leon Romanovsky , Jia-Ju Bai Cc: borisp@nvidia.com, davem@davemloft.net, kuba@kernel.org, netdev@vger.kernel.org, linux-rdma@vger.kernel.org, linux-kernel@vger.kernel.org Date: Thu, 11 Mar 2021 14:51:54 -0800 In-Reply-To: References: <20210304141814.8508-1-baijiaju1990@gmail.com> Content-Type: text/plain; charset="UTF-8" User-Agent: Evolution 3.38.4 (3.38.4-1.fc33) MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, 2021-03-07 at 10:50 +0200, Leon Romanovsky wrote: > On Thu, Mar 04, 2021 at 06:18:14AM -0800, Jia-Ju Bai wrote: > > When mlx5_is_fpga_lookaside() returns a non-zero value, no error > > return code is assigned. > > To fix this bug, err is assigned with -EINVAL as error return code. > > > > Reported-by: TOTE Robot > > Signed-off-by: Jia-Ju Bai > > --- > >  drivers/net/ethernet/mellanox/mlx5/core/fpga/core.c | 4 +++- > >  1 file changed, 3 insertions(+), 1 deletion(-) > > Like Heiner said, the current code has correct behavior. > The mlx5_fpga_device_load_check() has same mlx5_is_fpga_lookaside() > check and it is not an error if it returns true. > > NAK: Leon Romanovsky > > Thanks Agreed, apparently this robot is looking for "goto {out|*err*}" statements and treats all of them as errors, this is very unreliable,