Re: [PATCH] Make `obsolete params' work correctly if MODULE_SYMBOL_PRE

Valdis.Kletnieks
2003-01-13T20:34:53Z

[-- Attachment #1: Type: text/plain, Size: 800 bytes --]

On Mon, 13 Jan 2003 15:28:45 EST, "Richard B. Johnson" said:

> void foo(int len)
> {
> char use[0x100];
> char bar[len];
> }
>
> In the case of 'use', the compiler subtracts (0x100 * sizeof(char))
> from the current stack value and uses that as the location for 'use'.
> In the case of 'bar' the compiler subtracts (len * sizeof(char))
> from the current stack value and uses that as the location for 'bar'.

One or the other of these is missing a -0x100 for the location...

void foo (int len1, unsigned int len2)
{
char bar[0x100];
char baz[len1];
char quux[len2];
char moby[8];
}

And moby[6] is *where*? ;) Bonus points for getting this right if
compiled with -fvomit-stack-pointer. <evil grin> ;)
--
Valdis Kletnieks
Computer Systems Senior Engineer
Virginia Tech

[-- Attachment #2: Type: application/pgp-signature, Size: 226 bytes --]