From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E1C553D566C for ; Fri, 8 May 2026 18:34:42 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.129.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778265284; cv=none; b=k+sGj+GoAvYzr2c9W1AofrPmTSfgoHWDx3kKHjRlFraK5keSDldLfAXmcYQGbFqL93eoeVF5Y3QXDk8p3zQSOIsThq8AUUiEQUtmwPcK6uw/b+dwDMVuhbbn7PBIumOWjrXuxJtaXFMrIue7HZcrhAMp1pokpcMRSv7E/TWHgo4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778265284; c=relaxed/simple; bh=Az3Abzg9R9ixrk3fY4KPoOpV0NHjSjdIGPubJ5jAWhA=; h=Message-ID:Subject:From:To:Cc:Date:In-Reply-To:References: Content-Type:MIME-Version; b=n1g01gSsph9HXH3QAnm/1YSpU9o49ZIvL4Ffj4FX40efu2ut9nrTaq4xJTs0CseOlr38UTGzFJ6BhwM06Ae/hTwr85u6nPbST1ptemZEVmTQERlyQrDxYg68V0O5LRkJwpyfF6SoHtgAUyYKydnNE8nnfPbbmBH7x5sqDeUuJR0= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=f1zltzbm; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b=kIOed2y8; arc=none smtp.client-ip=170.10.129.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="f1zltzbm"; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b="kIOed2y8" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1778265282; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=hvnRK4XNgcB63eQHvn6GGJzkZT1HVPdz91PsqehdImw=; b=f1zltzbmrjY7C0Tdi3s9y5KBSq9bSoK86AyuYy7R3kp9o36awZ6TxvG7m5XjTeYLrRrSAF c24xz8dVH4BWSryX7ymxGv5V+kwvMXtflrRApYpwdneSlVMQ5vxt80JPOqY0OP+FPepJbZ QdKmI/YBhO+uUDpNWdaRKDKVCySJfis= Received: from mail-yw1-f200.google.com (mail-yw1-f200.google.com [209.85.128.200]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-223-9dYyFVEiMneQvrQHWNa7iA-1; Fri, 08 May 2026 14:34:38 -0400 X-MC-Unique: 9dYyFVEiMneQvrQHWNa7iA-1 X-Mimecast-MFC-AGG-ID: 9dYyFVEiMneQvrQHWNa7iA_1778265278 Received: by mail-yw1-f200.google.com with SMTP id 00721157ae682-7bd49a2467eso48012977b3.2 for ; Fri, 08 May 2026 11:34:38 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=google; t=1778265278; x=1778870078; darn=vger.kernel.org; h=mime-version:user-agent:content-transfer-encoding:references :in-reply-to:date:cc:to:from:subject:message-id:from:to:cc:subject :date:message-id:reply-to; bh=hvnRK4XNgcB63eQHvn6GGJzkZT1HVPdz91PsqehdImw=; b=kIOed2y8Ix2sr4EKtmoGIPd/sSVpPb8TfNAS9bGAmkuLrnGfPoJwuc07KTUIxD3tTF Tt8GTs6yaLxYcsYWtznWp9LWRD2Cebi4zI8YJM6PlWVbxyA3OG5oTqe/vb2kT4CV0f0u kfL9o6yKbVQEbEmKcpWxPZEJmW+00R7VLk9hrKtxE5vpMUv1wcDxStCaUA80RXxbks7Q jB9ogQT6mQTcJle6F4j5cpwxeGjbTpa0Ht/eO+ingALwP6rQT9qTo4i/mF+Uk4+XxHBo /rNkZKlG53TbOmmOcAdOt51Q668wamrQJOsqfqCQV6C2GXA5DX1nr3/DVcTHweS8fvsj JMJg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1778265278; x=1778870078; h=mime-version:user-agent:content-transfer-encoding:references :in-reply-to:date:cc:to:from:subject:message-id:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=hvnRK4XNgcB63eQHvn6GGJzkZT1HVPdz91PsqehdImw=; b=p7aWATvkgIBcRADL035w/cXsmIUaOBdTHYWUUNaA6Bxw/FTtU02uP63d3V3esJksoP hoZrt3pw+OzeyJpB/hcgFNMq9pvWmZAI3vGlPk5I0Mpe5kJRtMOwORy+gegF4+ViNHcG Eo1UXK4zw7zF4E8/CXjfIjrqjASAyYoECvYWdngWJm3bJvFdWKwGB1g8LnfdmtUfnOA/ 2h9pkevYKQwn112UkxlZDtCw0ncIEPXbzsn2xrfNZ4Le8wbpg14WQyTwCCUQQRwe7fGn VIUOUADE5LoglxnpXCapXAs9g/S+HW+QG7gqdQ5IvqQl1fZV8DuRBOpC8tT1bo93SBYs UxOw== X-Forwarded-Encrypted: i=1; AFNElJ9Qu66K9LNiQlrFN23cHUCIkwo/hxKC3bzk6Kv+lJ5oq2sYWGoIUnKrMxM4QjeGWRK4sgFBXD06wVaOWcI=@vger.kernel.org X-Gm-Message-State: AOJu0Yz7Q3ysTXMfgbc5IOqWL9lcEt+Fo4CYXYZEwHQt6Py1IGrpfsVo vjr3Zk/5NSuDu6Z8+5Bbw3KiV5AZaQmg2sceB3cQrBrd1rnV5vCZLzCRP2ZP2G6Kyp/pDbWNmgn yGzuoOvS5UcdtBEQ7W/VrSJyp55l9iRsYSnzDO6iPvW+gZDTnNngn7kzjypIGQUM5xw== X-Gm-Gg: Acq92OHlL+k8iVVEyDnKS0DmErI/VG3e3Zd8RQskteU96A68HA4cNH7v04NZpKZA5PM l1P5ptdOy5WQMZ1hvE9YGPfMiXYC3U1fn0vP8Hb+8mTNJpgV+uT5kpolwEPJ6YIk8Y3TJcjCod6 JuLNNZqTxuD8t2CvCLQvGAlUzSlOi4tcV8MzTxQ9aXPi09a6d4rgSh7pmhg3+PQOf5bHWUnx9iX d4FrvzMc82KAwyoQRfGuiuvMPNIRVKKqGrdWBMani0g7Smk1BwoWaW7xQPOIgJ2TzOU7qWSIdE5 fhbTP7XVqFTKGlHGg6Et5HHaoPYblAZMpKnQY2DZCPNHF1sflcSHUcFcYhU29wMTxt8D5sYA9ZT Chrvomiwh6SKZHMvRExQH0Olb6xdp+dVe+LLpTTttaQkIFYnJP5OzKKhmE7cz8xE= X-Received: by 2002:a05:690c:6b01:b0:79a:2f38:9a8c with SMTP id 00721157ae682-7bdf5dd0bcfmr143719457b3.15.1778265277989; Fri, 08 May 2026 11:34:37 -0700 (PDT) X-Received: by 2002:a05:690c:6b01:b0:79a:2f38:9a8c with SMTP id 00721157ae682-7bdf5dd0bcfmr143718937b3.15.1778265277406; Fri, 08 May 2026 11:34:37 -0700 (PDT) Received: from li-4c4c4544-0032-4210-804c-c3c04f423534.ibm.com ([2600:1700:6476:1430::29]) by smtp.gmail.com with ESMTPSA id 00721157ae682-7bd6656d218sm108668767b3.22.2026.05.08.11.34.35 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 08 May 2026 11:34:36 -0700 (PDT) Message-ID: <8e19e180b64f366b25293bbb1b0f6dfeba506bae.camel@redhat.com> Subject: Re: [RFC PATCH 3/6] hfsplus: Move long delayed work on system_dfl_long_wq From: Viacheslav Dubeyko To: Marco Crivellari , linux-kernel@vger.kernel.org Cc: Tejun Heo , Lai Jiangshan , Frederic Weisbecker , Sebastian Andrzej Siewior , Michal Hocko , Viacheslav Dubeyko , John Paul Adrian Glaubitz , Yangtao Li , linux-fsdevel@vger.kernel.org Date: Fri, 08 May 2026 11:34:34 -0700 In-Reply-To: <20260508134541.282073-4-marco.crivellari@suse.com> References: <20260508134541.282073-1-marco.crivellari@suse.com> <20260508134541.282073-4-marco.crivellari@suse.com> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.60.0 (3.60.0-1.fc44app2) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 On Fri, 2026-05-08 at 15:45 +0200, Marco Crivellari wrote: > Currently the code enqueue work items using {queue|mod}_delayed_work(), > using system_long_wq. This workqueue should be used when long works are > expected and it is a per-cpu workqueue. >=20 > The function(s) end up calling __queue_delayed_work(), which set a global > timer that could fire anywhere, enqueuing the work where the timer fired. >=20 > Unbound works could benefit from scheduler task placement, to optimize > performance and power consumption. Long work shouldn't stick to a single > CPU. >=20 > Recently, a new unbound workqueue specific for long running work has > been added: >=20 > =C2=A0=C2=A0=C2=A0=C2=A0c116737e972e ("workqueue: Add system_dfl_long_wq = for long unbound works") >=20 > Since the workqueue work doesn't rely on per-cpu variables, there is no > obvious reason that justify the use of a per-cpu workqueue. So change > system_long_wq with system_dfl_long_wq so that the work may benefit from > scheduler task placement. >=20 > Cc: Viacheslav Dubeyko > Cc: John Paul Adrian Glaubitz > Cc: Yangtao Li > Cc: linux-fsdevel@vger.kernel.org > Signed-off-by: Marco Crivellari > --- > fs/hfsplus/super.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) >=20 > diff --git a/fs/hfsplus/super.c b/fs/hfsplus/super.c > index 40a0feda716b..12ba672e13bc 100644 > --- a/fs/hfsplus/super.c > +++ b/fs/hfsplus/super.c > @@ -314,7 +314,7 @@ void hfsplus_mark_mdb_dirty(struct super_block *sb) > spin_lock(&sbi->work_lock); > if (!sbi->work_queued) { > delay =3D msecs_to_jiffies(dirty_writeback_interval * 10); > - queue_delayed_work(system_long_wq, &sbi->sync_work, delay); > + queue_delayed_work(system_dfl_long_wq, &sbi->sync_work, delay); > sbi->work_queued =3D 1; > } > spin_unlock(&sbi->work_lock); Looks good. Reviewed-by: Viacheslav Dubeyko Thanks, Slava.