From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.3 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 17CD6C388F9 for ; Wed, 11 Nov 2020 11:46:52 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id AF6DB206C0 for ; Wed, 11 Nov 2020 11:46:51 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726360AbgKKLqu (ORCPT ); Wed, 11 Nov 2020 06:46:50 -0500 Received: from mga04.intel.com ([192.55.52.120]:61477 "EHLO mga04.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725965AbgKKLqj (ORCPT ); Wed, 11 Nov 2020 06:46:39 -0500 IronPort-SDR: lSlzhjSK5FwgT88m+r6fJ6yJReJPLZ+h/DPwM3mrtFs99tZ4IBqcEz6eBmrRLBbuzQ0S9bgXfK yvZe8xouKk8g== X-IronPort-AV: E=McAfee;i="6000,8403,9801"; a="167548957" X-IronPort-AV: E=Sophos;i="5.77,469,1596524400"; d="scan'208";a="167548957" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga005.jf.intel.com ([10.7.209.41]) by fmsmga104.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 11 Nov 2020 03:46:35 -0800 IronPort-SDR: aLVfRnQ6syjz5hXBA2uHcXCUdpunAAx5MGZAPEb0SNSLesgqWUeWlXvn+plo64gIgKQuVNxZxR EjK/gvhjb7MQ== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.77,469,1596524400"; d="scan'208";a="541753308" Received: from mylly.fi.intel.com (HELO [10.237.72.73]) ([10.237.72.73]) by orsmga005.jf.intel.com with ESMTP; 11 Nov 2020 03:46:32 -0800 Subject: Re: [PATCH v1] i2c: nvidia-gpu: drop empty stub for runtime pm To: Vaibhav Gupta Cc: Ajay Gupta , Bjorn Helgaas , linux-i2c@vger.kernel.org, linux-kernel@vger.kernel.org, Bjorn Helgaas References: <20201107082151.58239-1-vaibhavgupta40@gmail.com> <20201107090442.GA107675@gmail.com> <6989eb51-a36c-6e43-86f3-9b02ab490d95@linux.intel.com> From: Jarkko Nikula Message-ID: <8e2b0544-5ff1-41aa-7f38-e501c1aff6d6@linux.intel.com> Date: Wed, 11 Nov 2020 13:46:31 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.12.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 11/11/20 12:54 PM, Vaibhav Gupta wrote: > On Tue, Nov 10, 2020 at 02:33:43PM +0200, Jarkko Nikula wrote: >>>> +#define gpu_i2c_suspend NULL >> Perhaps we can put NULL directly into UNIVERSAL_DEV_PM_OPS() for the suspend >> callback? >> > Yes. I have noticed that the approach for this is random. Many drivers pass > NULL directly to the dev_pm_ops type variable, and rest of them use a macro. > > I used it for symmetry. I mean there is 'gpu_i2c_resume', so although a macro, > I have put a 'gpu_i2c_suspend'. > > Although it won't make any significant change, but if required, I can send > another patch where NULL is passed into UNIVERSAL_DEV_PM_OPS() instead. No need to resend from my side, it was just a remark and I gave already the reviewed-by tag. Jarkko