From: Krzysztof Kozlowski <krzk@kernel.org>
To: Adriana Stancu <adriana@arista.com>, alexandre.belloni@bootlin.com
Cc: linux-rtc@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, robh@kernel.org,
krzk+dt@kernel.org, conor+dt@kernel.org
Subject: Re: [PATCH v1 1/2] dt-bindings: rtc: ti,bq32k: Add delay on rtc reads
Date: Thu, 16 Apr 2026 11:27:23 +0200 [thread overview]
Message-ID: <8e36e8e9-d0ad-4b19-bf04-2c4e5e92c670@kernel.org> (raw)
In-Reply-To: <20260416092414.3210383-2-adriana@arista.com>
On 16/04/2026 11:24, Adriana Stancu wrote:
> Add a configurable device tree property to specify
> if a microseconds delay should be added before reading
> the RTC registers.
But, why do we need it? Why are you adding it? You just described the
diff, but that we can read.
Please wrap commit message according to Linux coding style / submission
process (neither too early nor over the limit):
https://elixir.bootlin.com/linux/v6.4-rc1/source/Documentation/process/submitting-patches.rst#L597
Best regards,
Krzysztof
next prev parent reply other threads:[~2026-04-16 9:27 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-04-16 9:24 [PATCH v1 0/2] rtc: bq32000: Add settle delay for aggressive polling Adriana Stancu
2026-04-16 9:24 ` [PATCH v1 1/2] dt-bindings: rtc: ti,bq32k: Add delay on rtc reads Adriana Stancu
2026-04-16 9:27 ` Krzysztof Kozlowski [this message]
2026-04-16 9:24 ` [PATCH v1 2/2] rtc: bq32000: add configurable delay between RTC reads Adriana Stancu
2026-04-16 9:57 ` [PATCH v2 0/2] rtc: bq32000: Add settle delay for aggressive polling Adriana Stancu
2026-04-16 9:57 ` [PATCH v2 1/2] dt-bindings: rtc: ti,bq32k: Add delay on rtc reads Adriana Stancu
2026-04-16 10:03 ` Alexandre Belloni
2026-04-16 10:33 ` Adriana Nicolae
2026-04-16 11:00 ` Krzysztof Kozlowski
2026-04-16 11:14 ` Adriana Nicolae
2026-04-16 9:57 ` [PATCH v2 2/2] rtc: bq32000: add configurable delay between RTC reads Adriana Stancu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8e36e8e9-d0ad-4b19-bf04-2c4e5e92c670@kernel.org \
--to=krzk@kernel.org \
--cc=adriana@arista.com \
--cc=alexandre.belloni@bootlin.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=krzk+dt@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rtc@vger.kernel.org \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox