From: Dave Hansen <dave.hansen@intel.com>
To: Dongli Zhang <dongli.zhang@oracle.com>, x86@kernel.org
Cc: tglx@linutronix.de, mingo@redhat.com, bp@alien8.de,
dave.hansen@linux.intel.com, hpa@zytor.com,
linux-kernel@vger.kernel.org, joe.jin@oracle.com
Subject: Re: [PATCH 1/1] x86/split_lock: add the source of exception to warning logs
Date: Fri, 23 Feb 2024 08:27:34 -0800 [thread overview]
Message-ID: <8e4c2001-9fac-48a4-a177-dd6472eb3643@intel.com> (raw)
In-Reply-To: <20240223094746.11305-1-dongli.zhang@oracle.com>
On 2/23/24 01:47, Dongli Zhang wrote:
> @@ -1194,11 +1195,11 @@ static void split_lock_warn(unsigned long ip)
> bool handle_guest_split_lock(unsigned long ip)
> {
> if (sld_state == sld_warn) {
> - split_lock_warn(ip);
> + split_lock_warn(ip, true);
> return true;
> }
I really despise random true/falses getting passed to functions.
Wouldn't this be a lot easier to read if you just passed the string in:
split_lock_warn(ip, "guest");
rather than bools plus the ternary form dance?
next prev parent reply other threads:[~2024-02-23 16:27 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-23 9:47 [PATCH 1/1] x86/split_lock: add the source of exception to warning logs Dongli Zhang
2024-02-23 16:27 ` Dave Hansen [this message]
2024-02-24 3:19 ` Dongli Zhang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8e4c2001-9fac-48a4-a177-dd6472eb3643@intel.com \
--to=dave.hansen@intel.com \
--cc=bp@alien8.de \
--cc=dave.hansen@linux.intel.com \
--cc=dongli.zhang@oracle.com \
--cc=hpa@zytor.com \
--cc=joe.jin@oracle.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox