From: Terry Bowman <Terry.Bowman@amd.com>
To: kernel test robot <lkp@intel.com>,
alison.schofield@intel.com, vishal.l.verma@intel.com,
ira.weiny@intel.com, bwidawsk@kernel.org,
dan.j.williams@intel.com, dave.jiang@intel.com,
Jonathan.Cameron@huawei.com, linux-cxl@vger.kernel.org,
rrichter@amd.com
Cc: oe-kbuild-all@lists.linux.dev, linux-kernel@vger.kernel.org,
bhelgaas@google.com
Subject: Re: [PATCH v2 1/5] cxl/pci: Add RCH downstream port AER and RAS register discovery
Date: Fri, 24 Mar 2023 08:12:01 -0500 [thread overview]
Message-ID: <8e593a61-8a0e-8e13-603b-ced514b7533e@amd.com> (raw)
In-Reply-To: <202303241632.HTxJ0yfj-lkp@intel.com>
On 3/24/23 03:53, kernel test robot wrote:
> If you fix the issue, kindly add following tag where applicable
> | Reported-by: kernel test robot <lkp@intel.com>
> | Link: https://lore.kernel.org/oe-kbuild-all/202303241632.HTxJ0yfj-lkp@intel.com/
>
> sparse warnings: (new ones prefixed by >>)
>>> drivers/cxl/core/regs.c:340:24: sparse: sparse: Using plain integer as NULL pointer
> drivers/cxl/core/regs.c:345:24: sparse: sparse: Using plain integer as NULL pointer
>
> vim +340 drivers/cxl/core/regs.c
>
> 338
> 339 if (!request_mem_region(map->resource, map->max_size, name))
> > 340 return 0;
> 341
> 342 map->base = ioremap(map->resource, map->max_size);
> 343 if (!map->base) {
> 344 release_mem_region(map->resource, map->max_size);
> 345 return 0;
> 346 }
> 347
> 348 return map->base;
> 349 }
> 350
>
Yes, I will change the 0 return value to use NULL instead.
Regards,
Terry
next prev parent reply other threads:[~2023-03-24 13:12 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-23 21:38 [PATCH v2 0/5] cxl/pci: Add support for RCH RAS error handling Terry Bowman
2023-03-23 21:38 ` [PATCH v2 1/5] cxl/pci: Add RCH downstream port AER and RAS register discovery Terry Bowman
2023-03-24 8:53 ` kernel test robot
2023-03-24 13:12 ` Terry Bowman [this message]
2023-03-23 21:38 ` [PATCH v2 2/5] efi/cper: Export cper_mem_err_unpack() for CXL logging Terry Bowman
2023-03-23 22:29 ` Terry Bowman
2023-03-23 21:38 ` [PATCH v2 3/5] pci/aer: Export cper_print_aer() for CXL driver logging Terry Bowman
2023-03-23 22:20 ` Terry Bowman
2023-03-23 22:26 ` Sathyanarayanan Kuppuswamy
2023-04-14 20:41 ` Terry Bowman
2023-03-24 21:41 ` Bjorn Helgaas
2023-03-24 21:52 ` Terry Bowman
2023-03-23 21:38 ` [PATCH v2 4/5] cxl/pci: Forward RCH downstream port-detected errors to the CXL.mem dev handler Terry Bowman
2023-03-23 22:27 ` Terry Bowman
2023-03-24 22:36 ` Bjorn Helgaas
2023-03-27 21:51 ` Robert Richter
2023-03-28 17:21 ` Bjorn Helgaas
2023-03-29 15:59 ` Robert Richter
2023-03-28 13:41 ` Terry Bowman
2023-03-23 21:38 ` [PATCH v2 5/5] cxl/pci: Add RCH downstream port error logging Terry Bowman
2023-03-24 5:39 ` kernel test robot
2023-03-24 6:09 ` kernel test robot
2023-03-24 6:30 ` kernel test robot
2023-03-24 17:41 ` Terry Bowman
2023-03-27 23:21 ` Dave Jiang
2023-03-28 13:53 ` Terry Bowman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8e593a61-8a0e-8e13-603b-ced514b7533e@amd.com \
--to=terry.bowman@amd.com \
--cc=Jonathan.Cameron@huawei.com \
--cc=alison.schofield@intel.com \
--cc=bhelgaas@google.com \
--cc=bwidawsk@kernel.org \
--cc=dan.j.williams@intel.com \
--cc=dave.jiang@intel.com \
--cc=ira.weiny@intel.com \
--cc=linux-cxl@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lkp@intel.com \
--cc=oe-kbuild-all@lists.linux.dev \
--cc=rrichter@amd.com \
--cc=vishal.l.verma@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox