From: Krzysztof Kozlowski <krzk@kernel.org>
To: niravkumar.l.rabara@intel.com, Dinh Nguyen <dinguyen@kernel.org>,
Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
nirav.rabara@altera.com, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] arm64: dts: socfpga: agilex5: add gpio led and memory node
Date: Mon, 17 Feb 2025 10:08:40 +0100 [thread overview]
Message-ID: <8e5bbd2b-a4e1-417b-88d0-267450c7cf86@kernel.org> (raw)
In-Reply-To: <20250217052702.3470096-1-niravkumar.l.rabara@intel.com>
On 17/02/2025 06:27, niravkumar.l.rabara@intel.com wrote:
> From: Niravkumar L Rabara <niravkumar.l.rabara@intel.com>
>
> Add GPIO led and memory node for Agilex5 devkit.
>
> Signed-off-by: Niravkumar L Rabara <niravkumar.l.rabara@intel.com>
> ---
> .../boot/dts/intel/socfpga_agilex5_socdk.dts | 19 +++++++++++++++++++
> 1 file changed, 19 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/intel/socfpga_agilex5_socdk.dts b/arch/arm64/boot/dts/intel/socfpga_agilex5_socdk.dts
> index c533e5a3a610..59530eada2ea 100644
> --- a/arch/arm64/boot/dts/intel/socfpga_agilex5_socdk.dts
> +++ b/arch/arm64/boot/dts/intel/socfpga_agilex5_socdk.dts
> @@ -15,6 +15,25 @@ aliases {
> chosen {
> stdout-path = "serial0:115200n8";
> };
Missing blank line
> + leds {
> + compatible = "gpio-leds";
> +
> + led1 {
led-0
> + label = "hps_led1";
> + gpios = <&porta 11 GPIO_ACTIVE_HIGH>;
> + };
> +
And that's not necessary
> + };
> +
Best regards,
Krzysztof
prev parent reply other threads:[~2025-02-17 9:08 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-02-17 5:27 [PATCH] arm64: dts: socfpga: agilex5: add gpio led and memory node niravkumar.l.rabara
2025-02-17 9:08 ` Krzysztof Kozlowski [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8e5bbd2b-a4e1-417b-88d0-267450c7cf86@kernel.org \
--to=krzk@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dinguyen@kernel.org \
--cc=krzk+dt@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nirav.rabara@altera.com \
--cc=niravkumar.l.rabara@intel.com \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox