From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1759387AbdJQPuG (ORCPT ); Tue, 17 Oct 2017 11:50:06 -0400 Received: from szxga05-in.huawei.com ([45.249.212.191]:8514 "EHLO szxga05-in.huawei.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754496AbdJQPuD (ORCPT ); Tue, 17 Oct 2017 11:50:03 -0400 Subject: Re: [PATCH 0/2] block/SCSI MQ: two RESTART related patches To: Ming Lei , Jens Axboe , , Christoph Hellwig References: <20171017050418.22555-1-ming.lei@redhat.com> <20171017051209.GF15996@ming.t460p> CC: Bart Van Assche , , , Omar Sandoval , Linuxarm From: John Garry Message-ID: <8e604f28-dd20-7818-a25b-985ab537bf70@huawei.com> Date: Tue, 17 Oct 2017 16:47:23 +0100 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:45.0) Gecko/20100101 Thunderbird/45.3.0 MIME-Version: 1.0 In-Reply-To: <20171017051209.GF15996@ming.t460p> Content-Type: text/plain; charset="windows-1252"; format=flowed Content-Transfer-Encoding: 7bit X-Originating-IP: [10.202.227.238] X-CFilter-Loop: Reflected X-Mirapoint-Virus-RAPID-Raw: score=unknown(0), refid=str=0001.0A090204.59E626A4.017E,ss=1,re=0.000,recu=0.000,reip=0.000,cl=1,cld=1,fgs=0, ip=0.0.0.0, so=2014-11-16 11:51:01, dmn=2013-03-21 17:37:32 X-Mirapoint-Loop-Id: 6348f5fd87858119c54b3fdbdee88e24 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 17/10/2017 06:12, Ming Lei wrote: > On Tue, Oct 17, 2017 at 01:04:16PM +0800, Ming Lei wrote: >> Hi Jens, >> >> The 1st patch runs idle hctx after dealy in scsi_mq_get_budget(), >> so that we can keep same behaviour with before, and it can be >> thought as a fix. >> >> The 2nd patch cleans up RESTART, and removes handling for TAG_SHARED >> from current blk-mq's RESTART mechanism because SCSI_MQ can covers its >> restart by itself, so that no need to handle TAG_SHARED in blk-mq >> RESTART. And >20% IOPS boost is observed in my rand read test over >> scsi_debug. >> >> John, please test this two patches and see if it may improve your SAS >> IO performance, and you can find the two patches in the following branch: >> >> https://github.com/ming1/linux/commits/blk_mq_improve_restart_V1 > Hi Ming, As requested, here's my figures for blk_mq_improve_restart_V1: without default SCSI_MQ, deadline scheduler, CONFIG PREEMPT off read, rw, write IOPS 989K, 113K/113K, 835K with default SCSI_MQ, mq-deadline scheduler, CONFIG PREEMPT off read, rw, write IOPS 738K, 130K/130K, 686K For axboe for-next tip (21ed538): without default SCSI_MQ, deadline scheduler, CONFIG PREEMPT off read, rw, write IOPS 977K, 117K/117K, 821K with default SCSI_MQ, mq-deadline scheduler, CONFIG PREEMPT off read, rw, write IOPS 733K, 128K/128K, 676K All cases do not have LLDD mq exposed/enabled. So unfortunately not much difference with your branch. cheers, John > Forget to mention, you need to either pull the above branch directly > or apply the two patches against for-next branch of Jens' block > tree: > > git://git.kernel.org/pub/scm/linux/kernel/git/axboe/linux-block.git #for-next >