From: Jason Andryuk <jason.andryuk@amd.com>
To: Penny Zheng <Penny.Zheng@amd.com>,
Juergen Gross <jgross@suse.com>,
Stefano Stabellini <sstabellini@kernel.org>,
Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com>
Cc: Ray Huang <Ray.Huang@amd.com>,
Xenia Ragiadakou <Xenia.Ragiadakou@amd.com>,
<xen-devel@lists.xenproject.org>, <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v2 3/4] xen/cppc: get xen-required cppc perf caps data
Date: Wed, 15 Jan 2025 17:39:15 -0500 [thread overview]
Message-ID: <8e7bca41-46cd-4143-90cb-d3361e865522@amd.com> (raw)
In-Reply-To: <20241205054252.471761-4-Penny.Zheng@amd.com>
Hi Penny,
On 2024-12-05 00:42, Penny Zheng wrote:
> diff --git a/drivers/acpi/cppc_acpi.c b/drivers/acpi/cppc_acpi.c
> index 13d6ff84a1e9..3a436591da07 100644
> --- a/drivers/acpi/cppc_acpi.c
> +++ b/drivers/acpi/cppc_acpi.c
> + if (!high || !low || !nom || !min_nonlinear)
> + pr_warn("CPPC: read zero cpc register value for Xen Processor %d"
> + "highest_reg: %llu, lowest_reg: %llu"
> + "nominal_reg: %llu, lowest_non_linear_reg: %llu\n",
The string lacks separation before highest and nominal and the preceding
number. Also, I think it could probably be consolidated to:
pr_warn("zero register for Xen CPU %d highest: %llu"
" lowest: %llu nominal: %llu, non_linear: %llu\n,
pr_fmt is already "ACPI CPPC: ", and "_reg" doesn't add much value.
Regards,
Jason
next prev parent reply other threads:[~2025-01-15 22:39 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-12-05 5:42 [PATCH v2 0/4] xen/acpi: introduce cppc performance hypercall Penny Zheng
2024-12-05 5:42 ` [PATCH v2 1/4] xen/acpi: upload power and performance related data from a PVH dom0 Penny Zheng
2024-12-05 20:19 ` Jason Andryuk
2024-12-05 5:42 ` [PATCH v2 2/4] acpi/cppc: extract _cpc entry parsing logic Penny Zheng
2024-12-05 20:49 ` Jason Andryuk
2024-12-05 5:42 ` [PATCH v2 3/4] xen/cppc: get xen-required cppc perf caps data Penny Zheng
2024-12-05 21:11 ` Jason Andryuk
2025-01-15 22:39 ` Jason Andryuk [this message]
2024-12-05 5:42 ` [PATCH v2 4/4] xen/cppc: introduce cppc data upload sub-hypercall Penny Zheng
2024-12-05 22:08 ` Jason Andryuk
2024-12-11 20:55 ` Jason Andryuk
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8e7bca41-46cd-4143-90cb-d3361e865522@amd.com \
--to=jason.andryuk@amd.com \
--cc=Penny.Zheng@amd.com \
--cc=Ray.Huang@amd.com \
--cc=Xenia.Ragiadakou@amd.com \
--cc=jgross@suse.com \
--cc=linux-kernel@vger.kernel.org \
--cc=oleksandr_tyshchenko@epam.com \
--cc=sstabellini@kernel.org \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox