From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from bali.collaboradmins.com (bali.collaboradmins.com [148.251.105.195]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2CB2F22CF3F for ; Mon, 13 Jan 2025 13:48:11 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=148.251.105.195 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1736776093; cv=none; b=QtY1R3XTK7JqBcwf4MHrU4L4GGayvY63i+hZAobs6uGObd+qQ3FBBDvY2GQxjxyZJUW+a8fcQ7fN6a4ShgvThpYShBwcj72yV/Ki+l02JkwKE1kwTSQGdhFLkIoJy2Qc6HQROERNMhoMkp69wb+ywDz82tfi9KMEEVzEWqLAJ+w= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1736776093; c=relaxed/simple; bh=hj/tpubYtWMF9OtI/D/dKcAezXzb8evhqd+mQKXW1QI=; h=Message-ID:Date:MIME-Version:Subject:To:References:From: In-Reply-To:Content-Type; b=kDPwVacPjnaY0yoTo+tXQGz38qvBWPyXApF+jgchwEBnfxQct5g2qWb5f5R9qMJiDXXX2GjnC0NE08KCrxYompyCARB86/2EmYcG+RoHRgarzptXqkJzQgLCGQ/EyYPjSW++mVaGI4xuOPNE/R5MW6iRBWqGyhe3+PvYB1L6Wqg= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=collabora.com; spf=pass smtp.mailfrom=collabora.com; dkim=pass (2048-bit key) header.d=collabora.com header.i=@collabora.com header.b=Gn3SbNgJ; arc=none smtp.client-ip=148.251.105.195 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=collabora.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=collabora.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=collabora.com header.i=@collabora.com header.b="Gn3SbNgJ" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=collabora.com; s=mail; t=1736776090; bh=hj/tpubYtWMF9OtI/D/dKcAezXzb8evhqd+mQKXW1QI=; h=Date:Subject:To:References:From:In-Reply-To:From; b=Gn3SbNgJ/Y8hdqYSwdOXqZ9DsEkzobA5L8GJFfxvwQ8W8KXgRF8gmBtrLOedmph27 TUM9w4ikBq9IOfm5B/aP8dRpOAGxyfoOH2Iveh+yDSLFgEsDhjQx/Mg04CJn10YE5m xKt3MuKbAG16e8F2ebTvKbKheEOGGMh7ehTntr6TrE2Yuere64IU7Et59VLo3zngyE i1hH5X2TTiIl2GGjsHYxaaC9BdQkX19pM2tNkI2XMVMmCp+QWk+MhAqtEyHI2gTwwi 6gZEIP14DUWgXyt7nq/XujEF+vqFigyIukgEU5OQDq3iKx+aRy2S5kDnlSvbK7o4hL 3e79G/MFOVuCQ== Received: from [192.168.1.100] (2-237-20-237.ip236.fastwebnet.it [2.237.20.237]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits)) (No client certificate requested) (Authenticated sender: kholk11) by bali.collaboradmins.com (Postfix) with ESMTPSA id A8CDC17E0DB7; Mon, 13 Jan 2025 14:48:09 +0100 (CET) Message-ID: <8e8e3eca-dee0-43ab-95d9-aebd636245c7@collabora.com> Date: Mon, 13 Jan 2025 14:48:09 +0100 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 2/2] drm/mediatek/hdmi: Simplify with dev_err_probe To: Krzysztof Kozlowski , Chun-Kuang Hu , Philipp Zabel , David Airlie , Simona Vetter , Matthias Brugger , dri-devel@lists.freedesktop.org, linux-mediatek@lists.infradead.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org References: <20250112134708.46100-1-krzysztof.kozlowski@linaro.org> <20250112134708.46100-2-krzysztof.kozlowski@linaro.org> <59f8a02e-a716-40a8-bf73-111ad2a7af79@linaro.org> From: AngeloGioacchino Del Regno Content-Language: en-US In-Reply-To: <59f8a02e-a716-40a8-bf73-111ad2a7af79@linaro.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Il 13/01/25 14:07, Krzysztof Kozlowski ha scritto: > On 13/01/2025 13:41, AngeloGioacchino Del Regno wrote: >> Il 12/01/25 14:47, Krzysztof Kozlowski ha scritto: >>> Use dev_err_probe() to make error code and deferred probe handling >>> simpler. >>> >> >> That's already done in [1] so you can drop this commit. >> >> [1]: >> https://lore.kernel.org/r/20250108112744.64686-1-angelogioacchino.delregno@collabora.com >> > Eh, this was first in v3 in the middle of Dec, so why you cannot get it > merged first? Creating such 34-behemoths causes simple cleanups to > unnecessarily wait. > Getting the series partially merged is okay for me, no complaints about that, but then ... in v4, there are two minor comments to address (one of which is a one-char nitpick!) that might as well be done while applying, depending on what CK thinks about that, so there's no real benefit in getting 28 commits out of 34 picked instead of, well, just everything... Cheers! Angelo