Re: [PATCH v3 02/19] x86/resctrl: Access per-rmid structures by index

James Morse
2023-05-25T17:32:29Z

Hi Peter,

On 24/04/2023 14:06, Peter Newman wrote:
> On Mon, Mar 20, 2023 at 6:27 PM James Morse <james.morse@arm.com> wrote:
>> diff --git a/arch/x86/kernel/cpu/resctrl/core.c b/arch/x86/kernel/cpu/resctrl/core.c
>> index 030d3b409768..351319403f84 100644
>> --- a/arch/x86/kernel/cpu/resctrl/core.c
>> +++ b/arch/x86/kernel/cpu/resctrl/core.c
>> @@ -600,7 +600,7 @@ static void clear_closid_rmid(int cpu)
>> state->default_rmid = 0;
>> state->cur_closid = 0;
>> state->cur_rmid = 0;
>> - wrmsr(MSR_IA32_PQR_ASSOC, 0, 0);
>> + wrmsr(MSR_IA32_PQR_ASSOC, RESCTRL_RESERVED_CLOSID, 0);
>
> It looks like the RMID/CLOSID params are in the wrong order in this wrmsr().

Fixed, thanks!

James