From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id DA38FC43334 for ; Sun, 24 Jul 2022 03:14:41 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233252AbiGXC7m (ORCPT ); Sat, 23 Jul 2022 22:59:42 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38346 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229602AbiGXC7j (ORCPT ); Sat, 23 Jul 2022 22:59:39 -0400 Received: from mga18.intel.com (mga18.intel.com [134.134.136.126]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id DED0B13F8C for ; Sat, 23 Jul 2022 19:59:38 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1658631578; x=1690167578; h=message-id:date:mime-version:cc:subject:to:references: from:in-reply-to:content-transfer-encoding; bh=tu+rlCbzZUYmb39RdyQ4XYT1JbhjzZ6xE7dWDudpVkc=; b=hfng02PpR8htaOKrRSK8DOE/v9U6zJhPd/hzyrdXdKNC9Tubq9GnGq6a UqnEdX/RqCIwLduZ4h3FXD67vinos8Mhauk18ywm8yhwdWNwczYM6A35a ndJ321FC2pY+a8yY5UfMKCB7wlyiP7xC+AgYFNtMJWQ+hC29/kz37ZfIO gdBP3YvOvqKXZw3r2atBy641TWU78Uw4LutFgFip5PB4hDJSWa8JeibCy kx4py09/gagN2Srugfq4FGlKkvJITxAMufGciEpahzZNWYeIDATvTwhM4 Nrx5gogtSOAKowo2vBw1m4jhn/vDkPgk1y0QE06yGGYVal4k68QXsyfnP A==; X-IronPort-AV: E=McAfee;i="6400,9594,10417"; a="270545561" X-IronPort-AV: E=Sophos;i="5.93,189,1654585200"; d="scan'208";a="270545561" Received: from fmsmga008.fm.intel.com ([10.253.24.58]) by orsmga106.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 23 Jul 2022 19:59:38 -0700 X-IronPort-AV: E=Sophos;i="5.93,189,1654585200"; d="scan'208";a="657692682" Received: from zjiang1-mobl.ccr.corp.intel.com (HELO [10.249.170.155]) ([10.249.170.155]) by fmsmga008-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 23 Jul 2022 19:59:36 -0700 Message-ID: <8e970367-746e-0e74-ba39-e941fdbfdab7@linux.intel.com> Date: Sun, 24 Jul 2022 10:59:34 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.9.1 Cc: baolu.lu@linux.intel.com, Joerg Roedel , Will Deacon , Robin Murphy , "linux-kernel@vger.kernel.org" Subject: Re: [PATCH 1/1] iommu/vt-d: Fix possible recursive locking in intel_iommu_init() Content-Language: en-US To: "Tian, Kevin" , "iommu@lists.linux.dev" References: <20220718235325.3952426-1-baolu.lu@linux.intel.com> From: Baolu Lu In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Kevin, On 2022/7/21 15:39, Tian, Kevin wrote: >> From: Lu Baolu >> Sent: Tuesday, July 19, 2022 7:53 AM >> >> @@ -88,7 +89,8 @@ extern struct list_head dmar_drhd_units; >> static inline bool dmar_rcu_check(void) >> { >> return rwsem_is_locked(&dmar_global_lock) || >> - system_state == SYSTEM_BOOTING; >> + system_state == SYSTEM_BOOTING || >> + (IS_ENABLED(CONFIG_INTEL_IOMMU) >> && !intel_iommu_enabled); >> } > > intel_iommu_enabled is 0 if CONFIG_INTEL_IOMMU is not set. > > same for other similar checks. Sorry that I didn't get your point. If CONFIG_INTEL_IOMMU is not set, IS_ENABLED(CONFIG_INTEL_IOMMU) is 0. The adding check has no effect. Did I miss anything? Best regards, baolu