From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pj1-f41.google.com (mail-pj1-f41.google.com [209.85.216.41]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id ED3183F926D for ; Mon, 10 Aug 2026 23:22:43 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.41 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786404165; cv=none; b=aN7BxWnRiyEPLJCQ8KSK7WpBh9d1qNJ7lisHaI2aKfq8VjjSC3gEAo8qGWnBD0v/v7QDIbXqCpv6BFBqLFKOl00WTARyMpj9v1CBD3AZ3Yz/ya46NvUbmba0NJgXSVXsiqxmYJGutnIrBj3mAl916E79TEy/3bgQBU8oQ7duG94= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786404165; c=relaxed/simple; bh=M0MjLcWTskDALbCS54CZ4/9+M5FLfIcdbvqgABIt+TA=; h=Message-ID:Subject:From:To:Cc:Date:In-Reply-To:References: Content-Type:MIME-Version; b=Q2Nm4EDs9eJ/JFVoWDE0SmiOE0rm22+geSFr5GkZw9Z8b2isBtTUvjrD9qy2Fox5fJSKjRZlbPtq0bEyIlDMogRfOVCPBlBhxHC9QjoEWXC5yjjDfXq+irhHmBgBKDiZMeJBuLjZ9lGfFh8XOlO4N7wmXOZ2T45o34IXzfg2Igs= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=HnvX48gj; arc=none smtp.client-ip=209.85.216.41 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="HnvX48gj" Received: by mail-pj1-f41.google.com with SMTP id 98e67ed59e1d1-38e08baf860so2403946a91.2 for ; Mon, 10 Aug 2026 16:22:43 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1786404163; x=1787008963; darn=vger.kernel.org; h=mime-version:user-agent:content-transfer-encoding:content-type :references:in-reply-to:date:cc:to:from:subject:message-id:from:to :cc:subject:date:message-id:reply-to:content-type; bh=3sR0roWS7ay8jw9jkIlC9XLTYMTiMVpzbqbRgtEhFxM=; b=HnvX48gj+gTC5lccl2ewu0YBISb1i2fwxlC3R54THhBzaD4SakFXTiUU938tYQ2zZl cpsCnZanlARXkk2fSmGz3ydyJT5Mfg3jLIaOc6NOefN0+hnsDgTAJyQcXu60rZA4ZqNO 4XzFYsB8n4VCw8IdroVlUTsAd09l+0hDUVuyOQrHUE+qJ7ba+jSyFGc4+RpLiNRWCBWP PRJLE1awyrXkCSGJ1THSePufgAoL8mt+7EoaWokTL22M8SJZNgUv/mOPQWidkC2w1KWK zRtmUvNXarhg1qT5RKBL2qLe9J2eizRzAirb2/u3/ck4B7LOVCJhljBJUOr1R8hvN0oA YpHQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1786404163; x=1787008963; h=mime-version:user-agent:content-transfer-encoding:content-type :references:in-reply-to:date:cc:to:from:subject:message-id:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=3sR0roWS7ay8jw9jkIlC9XLTYMTiMVpzbqbRgtEhFxM=; b=DRMtri+PMU6E/s19u96v24sfMXFHtzeTGgei3wsYm5GxvwpBe/zlmZqdeQvqi7iro6 4WELpt0ZxbYVfIuCIQ6yLnqoy3ZOFZ0pNtYSg1R+ja76D03aseBIzVDWYo0yddbiL8Q+ gdHXsNwsFtkDFZDTIeU/r/HmzKE1vvooL9nmd/VMBcOM5lW0BnJQ9y2Fm8xbiLkjc+3k yVFWp4Ct6uTdd2MMWWHH02BX7ilGwE1/uYQPbwB65mc0BRBkolWYeyoKq6vN5BkICu2b snKG74fcExadWuRIPjoXEx0goplQXGFY5CDvR2dS7Q3JSf7T/3Jx4H/rz59AEbnFV2mf 2vug== X-Forwarded-Encrypted: i=1; AHgh+RpL1BLHvnx92bhLTzqVg9I98wvgendsznZrhzoZtUkvkL0C2lq9zwZRcFI5jG+DoTh2CuNABhpGPi7sGJ0=@vger.kernel.org X-Gm-Message-State: AOJu0YyyXbM7fKTjHFPEtX/jtDKNho7LKSMreI/1oMa1JpMz097qjj0l Yvkin2Qw1n/+zGs+Pe9H46/eUQsochcslENR6IejO3Xftw8f/OYrLLj8 X-Gm-Gg: AR+sD11BTO1c5av5OSCZSdJ0SszFyd11Z6RTi0l0tSOen5x7vJWEfG+Bxp5ZNSDAaf2 Xx/YqJ90l1hNK2gRHMaz6g3y2gR3KtNSxrChrY9UCtnrsDb3NDKB0k3k5fBX+ba7QrOfXTgfFqM 1p3W2VuIKtq3NtVstE9QZQ6g3Xm7HGVe8kxNylK4G3ucFwVxQ5gSWv//79rkMyP++t7qLiIfAff 8k9TJq8mc/XfsMpgnDqlVO8oTDK5Wnd9OhFjKPGdt7EQClM0cnRB8hx6X1H18QlOTtwxTfSQXsh bsOUHs9ajeYXaKjN+i8K0LL8ym8oHPEdMizQE4HdLKBWWwqVWHngFz5HZV2nw9z9bx6C/iScvkv UanwDTdi2cTa7C7JTwEje+/Oz0BUlG4UEte1R+hfVBSdsR5esVZBTNJBA7Goj9NGsWZChqUbOzy 0O2L3dzX9BT2u+/xk61FW9+9azGA8FHWz5TqnaN+T5UT5xF3VV6V8RF9Apx80IBVLpG4fAOgIzN jejzsgIsrNC413p X-Received: by 2002:a17:90b:3b52:b0:381:1c96:829b with SMTP id 98e67ed59e1d1-392cc8d043emr4789411a91.3.1786404163218; Mon, 10 Aug 2026 16:22:43 -0700 (PDT) Received: from [192.168.0.13] ([38.34.87.7]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-392d5238e07sm1164685a91.15.2026.08.10.16.22.42 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 10 Aug 2026 16:22:42 -0700 (PDT) Message-ID: <8ea2c2ef5a50333c84865d09c860a9617edbda9b.camel@gmail.com> Subject: Re: [PATCH bpf-next v11 03/10] bpf: Introduce global percpu data From: Eduard Zingerman To: Leon Hwang , bpf@vger.kernel.org Cc: Alexei Starovoitov , Daniel Borkmann , Andrii Nakryiko , Martin KaFai Lau , Kumar Kartikeya Dwivedi , Song Liu , Yonghong Song , Jiri Olsa , John Fastabend , Quentin Monnet , Shuah Khan , linux-kernel@vger.kernel.org, linux-kselftest@vger.kernel.org, kernel-patches-bot@fb.com Date: Mon, 10 Aug 2026 16:22:39 -0700 In-Reply-To: <20260806163125.11172-4-leon.hwang@linux.dev> References: <20260806163125.11172-1-leon.hwang@linux.dev> <20260806163125.11172-4-leon.hwang@linux.dev> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.56.2-10 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 On Fri, 2026-08-07 at 00:31 +0800, Leon Hwang wrote: ... > diff --git a/kernel/bpf/fixups.c b/kernel/bpf/fixups.c > index 440e73e1b11b..f2398749103b 100644 > --- a/kernel/bpf/fixups.c > +++ b/kernel/bpf/fixups.c > @@ -1817,6 +1817,43 @@ int bpf_do_misc_fixups(struct bpf_verifier_env *en= v) > =C2=A0 goto next_insn; > =C2=A0 } > =C2=A0 > + if (bpf_jit_supports_percpu_insn() && > + =C2=A0=C2=A0=C2=A0 insn->code =3D=3D (BPF_LD | BPF_IMM | BPF_DW) && > + =C2=A0=C2=A0=C2=A0 (insn->src_reg =3D=3D BPF_PSEUDO_MAP_VALUE || > + =C2=A0=C2=A0=C2=A0=C2=A0 insn->src_reg =3D=3D BPF_PSEUDO_MAP_IDX_VALUE= )) { > + struct bpf_map *map; > + > + aux =3D &env->insn_aux_data[i + delta]; > + map =3D env->used_maps[aux->map_index]; > + if (map->map_type !=3D BPF_MAP_TYPE_PERCPU_ARRAY) > + goto next_insn; > + > + prog->jit_required =3D true; > + > + /* > + * We are *skipping* first half of ld_imm64 insn > + * with 'i++;', patching over second half of it > + * with that same half + mov64_percpu_reg insn. > + * All because bpf_patch_insn_data() can only > + * replace one 8-byte insn, which does not work > + * well for ld_imm64 insn. > + */ > + > + insn_buf[0] =3D insn[1]; > + insn_buf[1] =3D BPF_MOV64_PERCPU_REG(insn->dst_reg, insn->dst_reg); > + cnt =3D 2; Hi Leon, Sorry for joining the discussion so late, but Andrii asked me to take a look at the verifier part of the changes. Could you please elaborate on what exactly does not work with 16-byte instructions and bpf_patch_insn_data()? Note that e.g. 'if (insn->imm =3D=3D BPF_FUNC_timer_= set_callback) {' case in the same bpf_do_misc_fixups() applies a patch containing BPF_LD_IMM= 64(). The rest of the patch lgtm. > + > + i++; > + new_prog =3D bpf_patch_insn_data(env, i + delta, insn_buf, cnt); > + if (!new_prog) > + return -ENOMEM; > + > + delta=C2=A0=C2=A0=C2=A0 +=3D cnt - 1; > + env->prog =3D prog =3D new_prog; > + insn=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 =3D new_prog->insnsi + i + delta; > + goto next_insn; > + } > + > =C2=A0 if (insn->code !=3D (BPF_JMP | BPF_CALL)) > =C2=A0 goto next_insn; > =C2=A0 if (insn->src_reg =3D=3D BPF_PSEUDO_CALL) ...