From: Arend van Spriel <arend.vanspriel@broadcom.com>
To: Priit Laes <plaes@plaes.org>, linux-kernel@vger.kernel.org
Cc: linux-wireless <linux-wireless@vger.kernel.org>
Subject: Re: [PATCH v2 1/3] lib: cordic: Move cordic macros and defines to header file
Date: Mon, 5 Nov 2018 23:02:35 +0100 [thread overview]
Message-ID: <8eb0e232-d14b-60d9-e3c8-008c46659a30@broadcom.com> (raw)
In-Reply-To: <3be396e01b33905e9ac5c80e7038b7aacf72eaf8.1541446422.git-series.plaes@plaes.org>
On 11/5/2018 8:37 PM, Priit Laes wrote:
> Also append CORDIC_ prefix to nonprefixed macros.
Bit annoying that you made me look at LKML for this patch. Can you just
post the entire series to linux-wireless so Kalle can take it all
through his tree. Also the commit message is a bit thin. Please explain
why these are moved to the header file.
Reviewed-by: Arend van Spriel <arend.vanspriel@broadcom.com>
> Signed-off-by: Priit Laes <plaes@plaes.org>
> ---
> include/linux/cordic.h | 9 +++++++++
> lib/cordic.c | 23 +++++++----------------
> 2 files changed, 16 insertions(+), 16 deletions(-)
next prev parent reply other threads:[~2018-11-05 22:02 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-05 19:37 [PATCH v2 0/3] wireless: Use common cordic algorithm for b43 driver Priit Laes
2018-11-05 19:37 ` [PATCH v2 1/3] lib: cordic: Move cordic macros and defines to header file Priit Laes
2018-11-05 22:02 ` Arend van Spriel [this message]
2018-11-06 7:14 ` Priit Laes
2018-11-06 12:49 ` Arend van Spriel
2018-11-05 19:37 ` [PATCH v2 2/3] brcmsmac: Use cordic-related macros from common cordic library Priit Laes
2018-11-05 19:37 ` [PATCH v2 3/3] b43: Use cordic algorithm from kernel library Priit Laes
2018-11-05 21:39 ` Michael Büsch
2018-11-05 22:11 ` Arend van Spriel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8eb0e232-d14b-60d9-e3c8-008c46659a30@broadcom.com \
--to=arend.vanspriel@broadcom.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=plaes@plaes.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox