From: Stephen Boyd <sboyd@kernel.org>
To: Arnd Bergmann <arnd@kernel.org>,
Michael Turquette <mturquette@baylibre.com>
Cc: Arnd Bergmann <arnd@arndb.de>,
stable@vger.kernel.org, kernel test robot <lkp@intel.com>,
Nathan Chancellor <nathan@kernel.org>,
Nick Desaulniers <ndesaulniers@google.com>,
Tom Rix <trix@redhat.com>,
Robert Jarzmik <robert.jarzmik@free.fr>,
linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org,
llvm@lists.linux.dev
Subject: Re: [PATCH] clk: pxa: fix NULL pointer dereference in pxa3xx_clk_update_accr
Date: Wed, 14 Jun 2023 17:22:21 -0700 [thread overview]
Message-ID: <8eceb50391ff83f598e16e0cb371fdb0.sboyd@kernel.org> (raw)
In-Reply-To: <20230511105845.299859-1-arnd@kernel.org>
Quoting Arnd Bergmann (2023-05-11 03:58:33)
> From: Arnd Bergmann <arnd@arndb.de>
>
> sparse points out an embarrasing bug in an older patch of mine,
> which uses the register offset instead of an __iomem pointer:
>
> drivers/clk/pxa/clk-pxa3xx.c:167:9: sparse: sparse: Using plain integer as NULL pointer
>
> Unlike sparse, gcc and clang ignore this bug and fail to warn
> because a literal '0' is considered a valid representation of
> a NULL pointer.
>
> Fixes: 3c816d950a49 ("ARM: pxa: move clk register definitions to driver")
> Cc: stable@vger.kernel.org
> Reported-by: kernel test robot <lkp@intel.com>
> Link: https://lore.kernel.org/oe-kbuild-all/202305111301.RAHohdob-lkp@intel.com/
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> ---
Applied to clk-fixes
prev parent reply other threads:[~2023-06-15 0:22 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-11 10:58 [PATCH] clk: pxa: fix NULL pointer dereference in pxa3xx_clk_update_accr Arnd Bergmann
2023-06-15 0:22 ` Stephen Boyd [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8eceb50391ff83f598e16e0cb371fdb0.sboyd@kernel.org \
--to=sboyd@kernel.org \
--cc=arnd@arndb.de \
--cc=arnd@kernel.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lkp@intel.com \
--cc=llvm@lists.linux.dev \
--cc=mturquette@baylibre.com \
--cc=nathan@kernel.org \
--cc=ndesaulniers@google.com \
--cc=robert.jarzmik@free.fr \
--cc=stable@vger.kernel.org \
--cc=trix@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox