From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id DB45BEB64D9 for ; Thu, 15 Jun 2023 00:22:30 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233044AbjFOAW3 (ORCPT ); Wed, 14 Jun 2023 20:22:29 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:51786 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230108AbjFOAWZ (ORCPT ); Wed, 14 Jun 2023 20:22:25 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id BCF22E3; Wed, 14 Jun 2023 17:22:24 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 58FB56203F; Thu, 15 Jun 2023 00:22:24 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id ABF0AC433C8; Thu, 15 Jun 2023 00:22:23 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1686788543; bh=pdaOGQKnCwrYyacOrxmVFnlnZMcpLs+PJTif44O1uR0=; h=In-Reply-To:References:Subject:From:Cc:To:Date:From; b=f0lLNBjNHuUdXomi5Y3CJsmSEoBOOkx/xyi3iWuNN1mKcAjsmpA/0X2PCfGKHofaW SwaDp1NHBvOBFA+dF/7JHsdd93ZLCnYhBdhPITLDmtKm86N6bta0VpyCtmIkIB2bW3 1L5TrNX77olRf92ciD3uwJIwqRz/RGvja6j5y10Yb4oAqh/RJESXiCiUfh/o1hO8bt 6wN7yqDfuqcOyJKTAV3LF/JDpI7ynqzX/Od3nuAig096IgE5YOfO/rAdByuwtDIoE2 FO0WbrVzcKib3hn1stoarPop/B2qHdptSqz9HWEP4YZl8tKv6Jj4sNkf3GBNm+qxQO txpjX4BE1jE2A== Message-ID: <8eceb50391ff83f598e16e0cb371fdb0.sboyd@kernel.org> Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable In-Reply-To: <20230511105845.299859-1-arnd@kernel.org> References: <20230511105845.299859-1-arnd@kernel.org> Subject: Re: [PATCH] clk: pxa: fix NULL pointer dereference in pxa3xx_clk_update_accr From: Stephen Boyd Cc: Arnd Bergmann , stable@vger.kernel.org, kernel test robot , Nathan Chancellor , Nick Desaulniers , Tom Rix , Robert Jarzmik , linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org, llvm@lists.linux.dev To: Arnd Bergmann , Michael Turquette Date: Wed, 14 Jun 2023 17:22:21 -0700 User-Agent: alot/0.10 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Quoting Arnd Bergmann (2023-05-11 03:58:33) > From: Arnd Bergmann >=20 > sparse points out an embarrasing bug in an older patch of mine, > which uses the register offset instead of an __iomem pointer: >=20 > drivers/clk/pxa/clk-pxa3xx.c:167:9: sparse: sparse: Using plain integer a= s NULL pointer >=20 > Unlike sparse, gcc and clang ignore this bug and fail to warn > because a literal '0' is considered a valid representation of > a NULL pointer. >=20 > Fixes: 3c816d950a49 ("ARM: pxa: move clk register definitions to driver") > Cc: stable@vger.kernel.org > Reported-by: kernel test robot > Link: https://lore.kernel.org/oe-kbuild-all/202305111301.RAHohdob-lkp@int= el.com/ > Signed-off-by: Arnd Bergmann > --- Applied to clk-fixes