From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753322AbdDCNpd (ORCPT ); Mon, 3 Apr 2017 09:45:33 -0400 Received: from mail-db5eur01on0108.outbound.protection.outlook.com ([104.47.2.108]:13136 "EHLO EUR01-DB5-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1752055AbdDCNpb (ORCPT ); Mon, 3 Apr 2017 09:45:31 -0400 Authentication-Results: linux-foundation.org; dkim=none (message not signed) header.d=none;linux-foundation.org; dmarc=none action=none header.from=virtuozzo.com; Subject: Re: [PATCH] mm/zswap: fix potential deadlock in zswap_frontswap_store() To: Vlastimil Babka References: <20170331153009.11397-1-aryabinin@virtuozzo.com> <20170403084729.GG24661@dhcp22.suse.cz> <28e47653-96d7-288a-0c9b-e065b29d7c45@suse.cz> CC: Michal Hocko , Shakeel Butt , Seth Jennings , Dan Streetman , Linux MM , LKML , Andrew Morton From: Andrey Ryabinin Message-ID: <8f29ec95-50a8-c776-30dc-e79e6b0d7349@virtuozzo.com> Date: Mon, 3 Apr 2017 16:46:52 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.7.0 MIME-Version: 1.0 In-Reply-To: <28e47653-96d7-288a-0c9b-e065b29d7c45@suse.cz> Content-Type: text/plain; charset="windows-1252" Content-Transfer-Encoding: 7bit X-Originating-IP: [195.214.232.6] X-ClientProxiedBy: DB6PR1001CA0042.EURPRD10.PROD.OUTLOOK.COM (10.168.69.156) To DB6PR0801MB2055.eurprd08.prod.outlook.com (10.168.86.136) X-MS-Office365-Filtering-Correlation-Id: e493b99e-1638-4ec9-f5e0-08d47a97b0b2 X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:(22001)(201703131423075)(201703031133081);SRVR:DB6PR0801MB2055; X-Microsoft-Exchange-Diagnostics: 1;DB6PR0801MB2055;3:vrfKg2ZU48+sR7qu20c+dwZkBK42GTJHancP4QtCDTUgAOwILgueQjYWMVwB/rvhQ5KwwaJs/WBoQj/w7y7/54aOnRciSyTMAW1VmDUzWx8OdtriUpsCSKIBFq/aNwcq7OffpfthSu6VxZT4KCXKXdG0Tik4AqZmd4v+GRsbfcuJxPFqpTI2f6hGTTo/FRnwdr+zCMoALwyt4opQ16h2L0q+OuqjP/Z7dllfE1FM06h3Cdd6iUtgIFOe7Leav+mwLuXZhHP8O1W28xFLe+URlr1Bsu4UWjuk/9ai0yBQw5ekltSTL6UWowGem40y1ulamQU8BhIrjNpY6zvJRaMo6A==;25:IsnvWLBO60BcLzFxsWy6aCQXSjsUDNDtsX2dR2G+o0qLxtj5V3ShvNRQeeeHzB705T9sE7vwwvxuzuxNXi6omnW41W6CbZLHZlXJYJY/ssH8PPL5qTzEi+ep70IV5u37PQs9cA3PRuhalErot9C8jR8n8vTGTNrgqLk5XEhveFOTQKNfZe1hhu35WTbsDAkz0+pQ/Wxia49lS10xN/1YWKICtJ8K3g09ptX/aZ+I5C7r5+0/xi59/kd0O+2OfxTvgMZHZswirXl15jLPIRmXbDkxn5fKVsSJNPVO1RxAHCzsFYQATi6KwC1lYind3+j9VpBfNoVEq8mMsfAHqh8deUrQZZSPr0db+CqGPnMr4sQ6SRJr/Th85j5s/JjtG+5MV1sxUCTmZjGfpz6t31AZSkk/JfQY57bhy+aNnPyz2i23zhhsYEHVHb6TQWjX99sUyvO3DvG0vS8CNmGCRRwwpw== X-Microsoft-Exchange-Diagnostics: 1;DB6PR0801MB2055;31:437rFjs/3V2lt1o85gTdLhG96mwbLCgQbMuPuiBigpfUYwQ9Lptxu7AMPmeCTKmGUx+TIlp4IvbLrI8UugrKjblm2DVQoeSct2giZsKe7jywRb2bY+UfQCjY3c4bJYiFEy8qxte30oCKCyQWvFIKi2WzWb2/iOtmzoYNYba9JRw6J2EfyS4qEe6iyG2DNAhpkGCGsZwX8gi5pqtaZ/GZCC9EbHFWpJUc+DrFg2rcbR8LhbluOkszhiDAZt1Fa/glLf6x9HDMiwYy6keg1B1Kng==;20:msKAzucgSeuIckjNNg/eJtpX3npuEk3dNBQkSVlYqL5Taz21Auy44GD5FC4ljBOh0EnalrosbqyQrh4tXF2X3k+ZLJoCDtZjpdT+PARZyPIAI2ELNkj+DaCM/wyaocLPf7O655YwLSB+3b/kAoQmyxFZ6jCVnmDgR6qyP/h42FDGW8qwUNpCLtKffPrb20D2bpYAX4J2UA6l2W07FzX1j3JaojUcxnGt2rRim2QA2NxxoD1qjTpW3mMpl0ii6+AD8UB/lyYiIe4qm+jJ29c6jn9OSOxriZTqN12rRXzWGiv+LplfGAV5EJs6T2+zGCv7Prm6Gb/m2ikffu/f0k0jWrDuuDcTEFagBhauGQ9q2cIfibtp1/ULZ7TWM55MQPep5fXi/V2YPXkQNxo6HKWsgWydbXQmQCu+GqROtUolYn4= X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(6040450)(601004)(2401047)(8121501046)(5005006)(10201501046)(3002001)(93006095)(93001095)(6041248)(201703131423075)(201702281528075)(201703061421075)(20161123562025)(20161123560025)(20161123555025)(20161123564025)(6072148);SRVR:DB6PR0801MB2055;BCL:0;PCL:0;RULEID:;SRVR:DB6PR0801MB2055; X-Microsoft-Exchange-Diagnostics: 1;DB6PR0801MB2055;4:Dum6LBQv1KC7SqNFMgtZM24VmhcVlWR5U34JJA/YdOrZ4ESxsplkEM73vnqFJu+A4vFUcUlJyvS51AVfvulo8ZllGBlQtKfWrzUAtIqceUWrVeXT+rslst344BRB+wHsSWxk1ezwlapiU2W3ITB1UjL5C9MR97nG47bvTF1lpgFVclNgWJL1er31YAREBeKdms0rfRmdgrsp0wv2R0fgqpv/d3xPHUxd6XMdr4QBMUevgGq5TqtURjRj6QKYJwnSyHjJ/KAEDxDj5ash06iAS3RVffMVTpZTsY4xs+nauNUYwy2Vpk4JWDJAbALVmER9J2i64wPW3sKfrQiEL4+tfI5B399Q4dkUxa1HA8xXXamgsOLFO+gugkLgbRRANsdcxXQQ8NGsuaOmR2gnDqF2QN9gADrnQ5sFhXZVrV8tjX1ePsbs5p8Wvt9Wdj31/R+wu1ylYnG0YYk6s0pMaGKfpyu9F2VNU0Nvkv+5eNBucYpcQICJKHCork7O/GSwLY0xdVIAzKTo/xBtI4kcaJ9p2vl9cGgCLJEFMqqneFlswhFvDB4GQ1Kx01o54j6tM6qwt+e0lK9MWb+f3oOnOA71f02oOPKMA/vIBgAbYhJA6bmh+O4I2ggczIjbxnLFjw3NCXQHztI1m4svUCT+850XlHIiN6nO5sZyPVB8nZzC2h8gUD9ncZIczYGtUp/UvHKNaZS5WDLXwDrJfE1MIdIbjg== X-Forefront-PRVS: 0266491E90 X-Forefront-Antispam-Report: SFV:NSPM;SFS:(10019020)(4630300001)(6009001)(6049001)(39410400002)(39400400002)(39450400003)(39840400002)(43544003)(377454003)(24454002)(189998001)(83506001)(50466002)(77096006)(6486002)(86362001)(4001350100001)(23746002)(47776003)(66066001)(31696002)(305945005)(65826007)(53546009)(5660300001)(25786009)(7736002)(3846002)(6116002)(90366009)(54906002)(4326008)(42186005)(53936002)(31686004)(2906002)(230700001)(81166006)(8676002)(6246003)(38730400002)(33646002)(229853002)(36756003)(110136004)(54356999)(2950100002)(6666003)(50986999)(76176999)(6916009);DIR:OUT;SFP:1102;SCL:1;SRVR:DB6PR0801MB2055;H:[172.16.25.12];FPR:;SPF:None;MLV:sfv;LANG:en; X-Microsoft-Exchange-Diagnostics: =?Windows-1252?Q?1;DB6PR0801MB2055;23:8qnik1WI8sYG7rnFb4FOgVnzdbDV0y/IU1w?= =?Windows-1252?Q?FFpCHE271uazWGFCs/csDwCWAmuaACqWb8UV7oJ66z312xc0oLS76TZG?= =?Windows-1252?Q?9lE9LveD5qGT/qIeWYdxenQagXmWlR9bOLYKmlI3k+swB5iSqVGx5J7E?= =?Windows-1252?Q?5hoqLjzNJQ30x9QqdcDMgt+axK81VwE3w/i7yRd5eOaTHteSFAVXDyP0?= =?Windows-1252?Q?SQrHjJF41udtGCglL84H1vf0ifnBmJQJZTY2pRMsE9WMdqcZddT0DlKM?= =?Windows-1252?Q?VgYkK0nb+ycsA5reZDdDBOBgCPGtLrXGx6rYii1X7jWf9OWthKGhC92V?= =?Windows-1252?Q?mjQ7NA9tXxOy8hrwcxfsPaHC9TCUVt5P/BwLraNM5uNqKhSQL3UsZKZx?= =?Windows-1252?Q?pwjvECnSLFJpePOfTKHdIf7L+UCBWNLuPUidtKW9lSBvPcp8kHaAhcLu?= =?Windows-1252?Q?JE31BxvG9AUBGlY4X3/IRtywlPvWS5WxFGvVVBfwZpNaB8fuhiAW9tSc?= =?Windows-1252?Q?m/A6JK9DMDqyaT9IA3ywi1tPejRc1q05nG7VmxlTraBWIlVtfiooFp+e?= =?Windows-1252?Q?J+D8Ebza/zEGTulNcaIeuD3cZMt2VSwV6DW9PGfHGdbDGNYrljVUYuyS?= =?Windows-1252?Q?PpqIXuj2ddSOtQG2Y/RKWJezOam3n9c13/5Omx8OuJctqPs68QoSUm64?= =?Windows-1252?Q?obqRPIp8osFJN38kcyOzgXYu2ybxPorfzl78oMyUugfqJz9hdxKJCRfl?= =?Windows-1252?Q?wT3h8DVfCW/jAz/EiLkMdG3smS5S1z1+4mH6q51IWvznrd7tbQH2sMFd?= =?Windows-1252?Q?MJRB1OLe9404b37loB5I0YE/Mg3qYSS1/CGfKfbOoKGgjO17oYat0CVC?= =?Windows-1252?Q?Q1xcynkVvr5TeBE+4LEeTSD3Xiq2FtKTIV0ZJJa23XlyTPxOA+62YsQj?= =?Windows-1252?Q?rr0xQpayT9BnwAUdXfdq93ntLPT/l1t5ZOSe6p8t+qIEuZeMfoSx8N/k?= =?Windows-1252?Q?8+/BhtHvdwFH5YDk0h5GIdHi0Y0/3aDSUCXtlvVMHkD/UmXGkabBG0+y?= =?Windows-1252?Q?He6fyNmepYn5lxQT75YsOc+tgHRAyGjVHAOrqwcCIjs/l8Zp7xy4k9ul?= =?Windows-1252?Q?uvFbSpkcKtCj+BYc9w8dt/+PBG7ZrOtVVDfbcP+LJuRW0OXSUhTxPPC3?= =?Windows-1252?Q?fBjyfiO1cZpEylQ8+niODHbRmkBf9iXUkgTH/OGA1qUN5ooXNnNAmxwD?= =?Windows-1252?Q?I7mCN4iNbixr9HLZuMZetfH5o3hCEo1/iAg0yFVJQ3UKeTjOTXk/709I?= =?Windows-1252?Q?+ktcZhyJvgN47jJZAoWdmIhvHfo56XwdVi0R2iR/RfLFRAJ0=3D?= X-Microsoft-Exchange-Diagnostics: 1;DB6PR0801MB2055;6:MkY1ZYLzk/c4flavS/sRYXKGB6L1w9Ut5DSEb7Myr81ZhAXlKb0EuRuQMlJScWWiFgj8ryA/In7Qz+f6a1xY3AjJtEk/qAlvBmo5SoJ32GEO2Jao+kcdriOruhDPYefaPzpnajgPPNlIAy0qZoK6JPd6s3l4SkGcFKEgdye8dPj6sM9sy6rxdr3pT7UTnyl3lgbpnKM/QttroRNiFQTbHQgdvsL7+N/THEuugnHHs/GIIFdWYtbNZGjstwTOR0DOvqIee+QY05aCmSsr3zk6qVB9KioHqW918OcdKU1TdExi9g4yjN3k8DTDw21TU1icVl0q0UuCgAd7ersXT+Eex69Yz8c/eUJLj6+z9Vb6Goq+B3VqzY8muWGeGuOHIKU7uqJb7c5VYRaBE++Iam0kqA==;5:AzXU/CPueo4fYv8Pim+sUXT61kGrko6HZWhEygjEiqhL/qOD+w+dyCClLlPELbprzzFx1vAInIeV/wXPfDfcxgIQcuLeoSQOA+Oe5kp6j3ikB0gsqirOt4IH3tM6MAuEnQwzNd5k29hYGY58lQne6Q==;24:A4CKpkLWiJTtHDJ9RXvyBjpQpxY/i/0rdDiAlfsHVnydJqgpj3Nm9D+h0LP9GhT3lIeFp6rS6pdvlfmCUQYqt+ehZx3OXrtECUn31mkj/yQ= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics: 1;DB6PR0801MB2055;7:rezb6muDjqbM6Pr2snN4gGjjD+SYFHHerkjws6EiLn5j2hh4XhLOI0Yy84TnhQiztnmWrXaEwTNtwtip48nPUpWDnCuAVnFEwTcNHVn2dcmwpQafLZURPsJ3IlzMrqQVY0K+b86ENbWA+4mdWFf8xTTPGb1WjbGr+4uaCCCo/LYk0JQiKofk+AIIeKjw258pUewflJSb0Yp8dDagS6ENPpB6N102AFbkgeIltv5rK+Wo3Dx9//dPSMOOlvoRcK8DRrYvRGgkyNvl1AfItdF2btTBmb52QHpP/ZiE/LtXe6VDX/JEgKIz4CUsV+NsYm/r/UU/ScmtakeLJT8Jhj/Zxg==;20:g8IfYDY+bkd/IZovdnjw0OZf6BB20kRFvBPtXAiv7i5YQIRStXr9BNwgEJCi3RiY86+IqnHOjyfDdM7C1xS2rO8SFM5RO1iZKBMyY9c0AMRShwFTB5xkncHxQHaEU9b1fHhBRbt4lzkTRG9+Ch8+LeTGDwGlFkVJXH9oDpV68LU= X-OriginatorOrg: virtuozzo.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 03 Apr 2017 13:45:28.3216 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB6PR0801MB2055 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 04/03/2017 04:28 PM, Vlastimil Babka wrote: >> >> >> Seems it was broken by >> >> a8161d1ed6098506303c65b3701dedba876df42a >> Author: Vlastimil Babka >> Date: Thu Jul 28 15:49:19 2016 -0700 >> >> mm, page_alloc: restructure direct compaction handling in slowpath > > Yeah, looks like previously the code subtly relied on compaction being > called only after the PF_MEMALLOC -> goto nopage check and I didn't > notice it. Tell me if I should add a check or you plan to send a patch. > Thanks! I would be glad if you could take care of this.