From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1493D1D8DFB for ; Tue, 27 Jan 2026 03:42:54 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.129.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769485376; cv=none; b=LAOovgroBpWbm6IZF5A6gfeAbEujamAXbCbVC3tI/waEoXOzSDLA2q2e9ihH/o1tE8nlQjYzfJ8w2qV0ZmULEvbpjsj1qhKjhObw4TvOPP8DpMVzLlQF/ysSlvBKB/r+4AAmY5660zU3+JswpUstr1Cad3a/tw2rbA+1ZRYKRUo= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769485376; c=relaxed/simple; bh=1rR5VwSftxPsUNlZriydxS9LQCw9a4NUzYUgfSONVoM=; h=From:Message-ID:Date:MIME-Version:Subject:To:Cc:References: In-Reply-To:Content-Type; b=cr5hntOCW1ktLhjaUyKeKr5ikehLrfZGW0I9OjV8tz7R6bzb3tHT38Uf7AZsRd3CZtRR7WNsY3Wz1ApX2+Wm1qXOoqrGyAqmKE3i2HQ8STbLGqEdnePtSTFgeSSH23B7EJ69BJmimSVDQ2hrCxD36GbITQaahDozf3J8pWXNN1k= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=e2BwTDO8; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b=NHkcbASN; arc=none smtp.client-ip=170.10.129.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="e2BwTDO8"; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b="NHkcbASN" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1769485374; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=szVnUk+QyWKBPsvsUPLU9AFVdRP9nqSD7/C4MNwYgf8=; b=e2BwTDO8SpeuYEOgmV8Mc9OjisBbvFFLc9h5w+C3OuJss4bmqzy0Ystu8qPYo5J0Ps9SFS PEeISsWaLXbbTHRjUVn7lhyvthvnUZcyxHmpL4GizQOW/T1Mrx2mJ+6wTuzv+TB/t0piw9 QTjfkj8NDoCC8Dvtp6AGoK7Pm24D1aM= Received: from mail-qt1-f198.google.com (mail-qt1-f198.google.com [209.85.160.198]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-29-StGeo-KrM6WxpTUnX1eJhg-1; Mon, 26 Jan 2026 22:42:51 -0500 X-MC-Unique: StGeo-KrM6WxpTUnX1eJhg-1 X-Mimecast-MFC-AGG-ID: StGeo-KrM6WxpTUnX1eJhg_1769485371 Received: by mail-qt1-f198.google.com with SMTP id d75a77b69052e-5015175bbb0so147739591cf.0 for ; Mon, 26 Jan 2026 19:42:51 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=google; t=1769485371; x=1770090171; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:content-language:references :cc:to:subject:user-agent:mime-version:date:message-id:from:from:to :cc:subject:date:message-id:reply-to; bh=szVnUk+QyWKBPsvsUPLU9AFVdRP9nqSD7/C4MNwYgf8=; b=NHkcbASN69G9+Tt3lDueTXbPtiMWzxZaVxIwC1TMVz4wOsABDtMTdzxWwraJttUw0W jqF874++tm+wpcWOC5NTaLRYl5oyzcx4XkLc9d72wXPp5m3d2df9tKdR8rtlRmfyU2PQ FDF5S+bpsB7xE84aD4/WspLGMj0D9hwjGJZyiEqXys8FokDK+qmxWoEVQSFVeU69KkIQ LKXAoZrSPt/exo3qPsWQRSHwE/EmGI8Oreojuv1dcZ0cEzM5SGfdsNyg1sp31hHKebyQ RnoEfbWX+IyOSNmyJC7Td6OZ0fyNxrDazHgM7kKxCkvyrmaljhbKYjJccrq2dI9OumS6 bgBQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1769485371; x=1770090171; h=content-transfer-encoding:in-reply-to:content-language:references :cc:to:subject:user-agent:mime-version:date:message-id:from:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=szVnUk+QyWKBPsvsUPLU9AFVdRP9nqSD7/C4MNwYgf8=; b=MuxsmcjUcElbim6D1MjPE8gze8IXWVZKhvPjPrPprSL7LVRZ5vRqNELpHKTvQmtfd5 pFmTCwj9SoE6sdm6W4NWH3rSHYw+v48NtahdofLe4zZ7G3Gj0rtsXfaEkrS7QvIjsbDD mD8TuPj4ugg7Segfxg0bDA5PGiJUfiYlprzdfyDmzv3KQeNR9AfWYhDurOLBTQsz4JT9 3Xbtgk1p05mqXL6Fu9vTyD1wTgYhG8fgdNuh5jpw3TynGstCWvKSQLS9rNS5g+LJDwM8 NbBJ4cr4Ci7Gbsmatbiz5HygnOXWxQH2+EnRJBleHbsTNIFzk59wcmmo0Uxr5GrS6SAP n5bQ== X-Gm-Message-State: AOJu0YyccYXcuAd3s8HeolU3UFQZNkG0NSf6dEPyUopFDc+TgQtSHHRr o1wQ3da7ijW3nKT8anL4wQseFeoJ/r7ZdJKZxIavhdbawtgnsgfCDvomyzP/wCT1uXJSnfvuEQ2 Y8flzSmLz4CHMUgbUnHHSOrwGdt8IM7kB3ltYQIncaRXe30tSnah5LbC/qK1Y7c4BCA== X-Gm-Gg: AZuq6aJRdW+YY/MKkVXIVq6UgW9i45TSu5fnzubGW6Vnr+Hu9fos4IGGnYFNx+qRf5A SosoFqN0KojKPBlEKi/BFGr+Q5Yi+HISXXpVQMaZxGTcvlRzKdmQV52y6BzMA46h93OG3SJrs07 Pus7G0RmDVWNpC63COrZRaUiTeSEuKihSuncAQfvIMdDiSBV2qj8jlxzgjc3xISxsv1+skzzAmp Z3F1BbVRsAyiWKNVfh+wEUgvW5rQwgI//gdlMSChdyNSkapIgJQn8Kne9mlhr6MmNo1OJNueDBh kaguNbmqX5y7hilD14DW/9MlJtNSbYKgJmrzfAz5Fm1W79BErvF5o7IMO7WeWzOajaNshLdJMrG eiFXK1tjsO9Q+BgtAUrWuY3RDTb36Y3JU3Q+/bZzjWbeBqfhAFA77TAAl X-Received: by 2002:ac8:5807:0:b0:501:47c4:ac8b with SMTP id d75a77b69052e-50330114e87mr2282801cf.25.1769485371294; Mon, 26 Jan 2026 19:42:51 -0800 (PST) X-Received: by 2002:ac8:5807:0:b0:501:47c4:ac8b with SMTP id d75a77b69052e-50330114e87mr2282721cf.25.1769485370948; Mon, 26 Jan 2026 19:42:50 -0800 (PST) Received: from ?IPV6:2601:188:c102:b180:1f8b:71d0:77b1:1f6e? ([2601:188:c102:b180:1f8b:71d0:77b1:1f6e]) by smtp.gmail.com with ESMTPSA id d75a77b69052e-502f8090d57sm96482311cf.6.2026.01.26.19.42.49 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 26 Jan 2026 19:42:50 -0800 (PST) From: Waiman Long X-Google-Original-From: Waiman Long Message-ID: <8f74c94a-3d53-475a-85ff-571c00029a1d@redhat.com> Date: Mon, 26 Jan 2026 22:42:49 -0500 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] locking/lockdep: Replace snprintf with strscpy in seq_stats To: Thorsten Blum , Peter Zijlstra , Ingo Molnar , Will Deacon , Boqun Feng Cc: linux-kernel@vger.kernel.org References: <20260126235456.430591-2-thorsten.blum@linux.dev> Content-Language: en-US In-Reply-To: <20260126235456.430591-2-thorsten.blum@linux.dev> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 1/26/26 6:54 PM, Thorsten Blum wrote: > Replace snprintf("%s", ...) with the faster and more direct strscpy(). > > Signed-off-by: Thorsten Blum > --- > kernel/locking/lockdep_proc.c | 5 +++-- > 1 file changed, 3 insertions(+), 2 deletions(-) > > diff --git a/kernel/locking/lockdep_proc.c b/kernel/locking/lockdep_proc.c > index 1916db9aa46b..e458fa258d05 100644 > --- a/kernel/locking/lockdep_proc.c > +++ b/kernel/locking/lockdep_proc.c > @@ -19,6 +19,7 @@ > #include > #include > #include > +#include > #include > #include > > @@ -488,9 +489,9 @@ static void seq_stats(struct seq_file *m, struct lock_stat_data *data) > const char *key_name; > > key_name = __get_key_name(ckey, str); > - snprintf(name, namelen, "%s", key_name); > + strscpy(name, key_name, namelen); > } else { > - snprintf(name, namelen, "%s", cname); > + strscpy(name, cname, namelen); > } > rcu_read_unlock_sched(); > Reviewed-by: Waiman Long