From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-ot1-f66.google.com (mail-ot1-f66.google.com [209.85.210.66]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E29B1375143 for ; Wed, 7 Jan 2026 17:28:24 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.66 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1767806910; cv=none; b=DW9BmTK5VtaKdh0XqLcF99u2cECPLtrrKAS0cpn6/WXnlMz/iVgRWJKaBXL8vDmaqtaBb/sAfbXVNZ/euYAPtgbHEuXaCidwd/U82yaG2KrfdWP5GL16E+1wWi4br5x87vTnfKQJnr94cY1UR36HZykKk8/LjfKu9WoaIhh4Hms= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1767806910; c=relaxed/simple; bh=oyXEsXlh7BGPUY9HjT3nxQ6TtZhcHPwF00+7QY+04oQ=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=YG80EXFxCLONzUitC6acY2AAb8cuWH3WoU15nu3BBEjELsfj0VYbgsFGuym21kfiCHz4DvHu0h9851V/heG6Hez2eA8RLP7bcl+5Ui6L6ZdDjEpPUJK9vEjSs/ypO7Pqqv+PVAoRQI69KSZTY7KJVQSVhjqpWmNvKpn7IiG6CpQ= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linuxfoundation.org; spf=pass smtp.mailfrom=linuxfoundation.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=e3CuH5eB; arc=none smtp.client-ip=209.85.210.66 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linuxfoundation.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linuxfoundation.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="e3CuH5eB" Received: by mail-ot1-f66.google.com with SMTP id 46e09a7af769-7cdf7529bb2so1598978a34.2 for ; Wed, 07 Jan 2026 09:28:23 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linuxfoundation.org; s=google; t=1767806899; x=1768411699; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=JFfDcQX8Wu0We08AMqEf4Lbij99od42IKWQOPTmhZ/s=; b=e3CuH5eB54kEpXUzVxTI3WU9ScfttwTCQDxzmyU1jaZd8HJLd4rvtqcUn3eG76Yr7w lqXAiWWaA3FjGD8IL2AhbQCb/pet37yxVQvtuahKyhBHLKqly5TPqI5xKAm0r6IEFjM4 mMDzc+MdHry10b8gQlBrZpE88jdf43RkzHEqU= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1767806899; x=1768411699; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=JFfDcQX8Wu0We08AMqEf4Lbij99od42IKWQOPTmhZ/s=; b=u/8r6i3/K/YA8klGeYi3vSh0J3mEvVt7Hn7Cw9UsubnMjQ4CkqZSYVHdB1FyIQRuE4 2JOchlSLsWpBXZ4WauTd2t8MynKt3oJuPZQqizloBCEJY6verR/LjmGtjU9Wdv5ECxmg wEv4L6Nwc4EO31eykY5WcMYjALPqIuP6dfK1gFaIscxpdeEDxq30sw2V75a8y2bVb35n 8+XPCepLhgXd8b8Hic+r5lOqdI/6ufO1fRYMzX+UpfnisHYOxMkHMnWoTXzUbd6XGvEB 98Eju7rJUSrXF9lnta5fb6pBBtCtNRgceHZ0GXJhYlNRHPTUwyHvSmGAnL6lf2cCCKyz CX3Q== X-Forwarded-Encrypted: i=1; AJvYcCUspliMHb5ckRpkfNCurto5bw2YvTwGrpichEdpLAVC/dV3T63z4psM/G9IwAOb6xiBslzZVSQBXLVQYtk=@vger.kernel.org X-Gm-Message-State: AOJu0YwmI+UxU/tFXerYBxzX+WyBmVvjDlO3z28P7Aq0McehUloVi2z+ N2ZftOYpEcn9byttGdm2qTaXLl6/b+EWN+p+6UVtAycptNtxOXilb+zy/OWechrgpzg= X-Gm-Gg: AY/fxX4UU/G8KtcXxw2melHoGO4FLlVGq+CEodMNoKA9221LT5GKEaIwVEXF/g9IFV1 L9andLxq2dJ41dPtXZxHcKwPUfctY33dzfmKiMPVomX89lvf3GnnBy/tS67iLpQsxHowDqW5d6g 5Pc8yplEE/J+PraFhgpLo3WCJVBIeXAsdc8gwbnzQLMEsMX5SOD0cQp/XHW3s/2pOkXTBX4RLdw QLx22zDOIRJzPryQAzjTjUFFTAXT9RX7eA6Q7I5N+NzwT1mxD7UuIAQFRmCspVoyYSefJ29SwQu Dab3YPa8EDkcIFtNAbynOHxSUsHo/DuOQPmknlkgbQh9lFegMt6nbcnYt/YN7s9cPv5MHDqgMuR IAzUgCwY6IPYKhoCyhrLJIc4pB3HU0X8/ZK+/ukyHITqfWqz27feqOXlOeXH1uqdkefg4W06/eQ hIwOuYGtg2ec7UQ20e3NUhbfE= X-Google-Smtp-Source: AGHT+IGY01vSxeVDGeg8pnh4TwvBfewX0HCW4RQqLDBrFqGx39ZRnomVQXopJ3yhbzyX7t84YcdlrA== X-Received: by 2002:a05:6830:411f:b0:7c7:6850:81a2 with SMTP id 46e09a7af769-7ce50b57c2cmr1792295a34.24.1767806898931; Wed, 07 Jan 2026 09:28:18 -0800 (PST) Received: from [192.168.1.14] ([38.175.187.108]) by smtp.gmail.com with ESMTPSA id 46e09a7af769-7ce4762eefbsm4098985a34.0.2026.01.07.09.28.18 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 07 Jan 2026 09:28:18 -0800 (PST) Message-ID: <8f7a03a1-7c5a-4a98-978d-e5ae9c926036@linuxfoundation.org> Date: Wed, 7 Jan 2026 10:28:17 -0700 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 1/2] kunit: tool: test: Rename test_data_path() to _test_data_path() To: David Gow , shuah@kernel.org, =?UTF-8?Q?Thomas_Wei=C3=9Fschuh?= , Brendan Higgins , Rae Moar Cc: linux-kselftest@vger.kernel.org, kunit-dev@googlegroups.com, linux-kernel@vger.kernel.org, Shuah Khan References: <20260107015936.2316047-1-davidgow@google.com> Content-Language: en-US From: Shuah Khan In-Reply-To: <20260107015936.2316047-1-davidgow@google.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit On 1/6/26 18:59, David Gow wrote: > From: Thomas Weißschuh > > Running the KUnit testsuite through pytest fails, as the function > test_data_path() is recognized as a test function. Its execution fails > as pytest tries to resolve the 'path' argument as a fixture which does > not exist. > > Rename the function, so the helper function is not incorrectly > recognized as a test function. > > Signed-off-by: Thomas Weißschuh > Reviewed-by: David Gow > Signed-off-by: David Gow > --- > > Changes since v1: > https://lore.kernel.org/linux-kselftest/20251230-kunit-pytest-v1-1-e2dae0dae200@linutronix.de/ > - Rebase on top of "kunit: tool: Add test for nested test result > reporting" > https://git.kernel.org/pub/scm/linux/kernel/git/shuah/linux-kselftest.git/commit/?h=kunit&id=0c5b86c67fb6898d02c8f92de884186297fd302f > Thank you. Applied to linux kselftest kunit repo for Linux 6.20-rc1 thanks, -- Shuah