From: Jens Axboe <axboe@kernel.dk>
To: Xianting Tian <xianting_tian@126.com>, tj@kernel.org
Cc: cgroups@vger.kernel.org, linux-block@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] blkcg: add plugging support for punt bio
Date: Thu, 6 Aug 2020 09:16:34 -0600 [thread overview]
Message-ID: <8f84e1fe-9fa5-b7e7-1f2f-b0c4a40614e2@kernel.dk> (raw)
In-Reply-To: <1596722082-31817-1-git-send-email-xianting_tian@126.com>
On 8/6/20 7:54 AM, Xianting Tian wrote:
> Try to merge continuous bio to current task's plug fisrt.
The patch looks fine to me, but I'd really like to see a bit more
changelog here. The commit message should explain why the change
is made, rather it's a very brief explanation of what it does.
If the bio list is contiguous, then we do the plugging to improve
merging at the lower level. You probably ran into a case where
you saw sub-optimal merging? And now the performance is better
with the patch? How much?
--
Jens Axboe
next prev parent reply other threads:[~2020-08-06 17:36 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-06 13:54 [PATCH] blkcg: add plugging support for punt bio Xianting Tian
2020-08-06 14:30 ` Tejun Heo
2020-08-06 15:16 ` Jens Axboe [this message]
[not found] ` <42b939c2.e08.173c6f79af9.Coremail.xianting_tian@126.com>
[not found] ` <1ded6246.2c67.17458ce4300.Coremail.xianting_tian@126.com>
[not found] ` <65e1e040da644ed9a05edd166d06b5e3@h3c.com>
2020-09-08 18:03 ` Tejun Heo
2020-09-09 1:22 ` Tianxianting
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8f84e1fe-9fa5-b7e7-1f2f-b0c4a40614e2@kernel.dk \
--to=axboe@kernel.dk \
--cc=cgroups@vger.kernel.org \
--cc=linux-block@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=tj@kernel.org \
--cc=xianting_tian@126.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox