From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753487AbdJPPCJ (ORCPT ); Mon, 16 Oct 2017 11:02:09 -0400 Received: from mail-pg0-f67.google.com ([74.125.83.67]:55028 "EHLO mail-pg0-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753139AbdJPPCH (ORCPT ); Mon, 16 Oct 2017 11:02:07 -0400 X-Google-Smtp-Source: AOwi7QC0GCQnUNSpZaQKvzlHSH/dhdqkzUGdGmqWlXb/HlFHjnwMvIz/4YXMRjHvLXxTeaU6eM4fDg== Subject: Re: [PATCH v5 7/7] soc: mediatek: pwrap: fixup warnings from coding style To: sean.wang@mediatek.com, robh+dt@kernel.org, mark.rutland@arm.com, devicetree@vger.kernel.org, linux-mediatek@lists.infradead.org Cc: chen.zhong@mediatek.com, chenglin.xu@mediatek.com, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org References: From: Matthias Brugger Message-ID: <8fa7858f-7a73-1275-f345-24efa48e957c@gmail.com> Date: Mon, 16 Oct 2017 17:02:02 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.4.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 10/16/2017 09:07 AM, sean.wang@mediatek.com wrote: > From: Sean Wang > > fixup those warnings such as lines over 80 words and parenthesis > alignment which would be complained by checkpatch.pl. > > Signed-off-by: Sean Wang > --- I already took this patch, please drop from series. Thanks > drivers/soc/mediatek/mtk-pmic-wrap.c | 20 +++++++++++++------- > 1 file changed, 13 insertions(+), 7 deletions(-) > > diff --git a/drivers/soc/mediatek/mtk-pmic-wrap.c b/drivers/soc/mediatek/mtk-pmic-wrap.c > index 9ac304a..51b8894 100644 > --- a/drivers/soc/mediatek/mtk-pmic-wrap.c > +++ b/drivers/soc/mediatek/mtk-pmic-wrap.c > @@ -1101,7 +1101,8 @@ static int pwrap_init_cipher(struct pmic_wrapper *wrp) > /* wait for cipher data ready@PMIC */ > ret = pwrap_wait_for_state(wrp, pwrap_is_pmic_cipher_ready); > if (ret) { > - dev_err(wrp->dev, "timeout waiting for cipher data ready@PMIC\n"); > + dev_err(wrp->dev, > + "timeout waiting for cipher data ready@PMIC\n"); > return ret; > } > > @@ -1496,23 +1497,27 @@ static int pwrap_probe(struct platform_device *pdev) > if (IS_ERR(wrp->bridge_base)) > return PTR_ERR(wrp->bridge_base); > > - wrp->rstc_bridge = devm_reset_control_get(wrp->dev, "pwrap-bridge"); > + wrp->rstc_bridge = devm_reset_control_get(wrp->dev, > + "pwrap-bridge"); > if (IS_ERR(wrp->rstc_bridge)) { > ret = PTR_ERR(wrp->rstc_bridge); > - dev_dbg(wrp->dev, "cannot get pwrap-bridge reset: %d\n", ret); > + dev_dbg(wrp->dev, > + "cannot get pwrap-bridge reset: %d\n", ret); > return ret; > } > } > > wrp->clk_spi = devm_clk_get(wrp->dev, "spi"); > if (IS_ERR(wrp->clk_spi)) { > - dev_dbg(wrp->dev, "failed to get clock: %ld\n", PTR_ERR(wrp->clk_spi)); > + dev_dbg(wrp->dev, "failed to get clock: %ld\n", > + PTR_ERR(wrp->clk_spi)); > return PTR_ERR(wrp->clk_spi); > } > > wrp->clk_wrap = devm_clk_get(wrp->dev, "wrap"); > if (IS_ERR(wrp->clk_wrap)) { > - dev_dbg(wrp->dev, "failed to get clock: %ld\n", PTR_ERR(wrp->clk_wrap)); > + dev_dbg(wrp->dev, "failed to get clock: %ld\n", > + PTR_ERR(wrp->clk_wrap)); > return PTR_ERR(wrp->clk_wrap); > } > > @@ -1557,8 +1562,9 @@ static int pwrap_probe(struct platform_device *pdev) > pwrap_writel(wrp, wrp->master->int_en_all, PWRAP_INT_EN); > > irq = platform_get_irq(pdev, 0); > - ret = devm_request_irq(wrp->dev, irq, pwrap_interrupt, IRQF_TRIGGER_HIGH, > - "mt-pmic-pwrap", wrp); > + ret = devm_request_irq(wrp->dev, irq, pwrap_interrupt, > + IRQF_TRIGGER_HIGH, > + "mt-pmic-pwrap", wrp); > if (ret) > goto err_out2; > >