public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: "Jin, Yao" <yao.jin@linux.intel.com>
To: Jiri Olsa <jolsa@redhat.com>
Cc: acme@kernel.org, jolsa@kernel.org, peterz@infradead.org,
	mingo@redhat.com, alexander.shishkin@linux.intel.com,
	Linux-kernel@vger.kernel.org, ak@linux.intel.com,
	kan.liang@intel.com, yao.jin@intel.com
Subject: Re: [PATCH v2] perf stat: Disable NMI watchdog message on hybrid
Date: Thu, 10 Jun 2021 09:04:57 +0800	[thread overview]
Message-ID: <8faa16cf-561e-cd31-7fb2-bfad3ae27782@linux.intel.com> (raw)
In-Reply-To: <YMEj6vuPcEnCz6tr@krava>

Hi Jiri,

On 6/10/2021 4:26 AM, Jiri Olsa wrote:
>> +static bool is_mixed_hybrid_group(struct evsel *counter)
>> +{
>> +	struct evlist *evlist = counter->evlist;
>> +	struct evsel *pos;
>> +
>> +	evlist__for_each_entry(evlist, pos) {
>> +		if (perf_pmu__is_hybrid(pos->pmu_name))
>> +			return true;
>> +	}
> so we care if there's at least one hybrid event in the list right?
> it can be all full with just hybrid events, but the function name
> suggests it's mixed with normal events
> 
> jirka
> 

Yes, that's right. We only care there is at least one hybrid event in the evlist.

So do we change the function name to evlist__has_hybrid_event?

Thanks
Jin Yao

  reply	other threads:[~2021-06-10  1:05 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-06-09  5:06 [PATCH v2] perf stat: Disable NMI watchdog message on hybrid Jin Yao
2021-06-09 20:26 ` Jiri Olsa
2021-06-10  1:04   ` Jin, Yao [this message]
2021-06-10  9:51     ` Jiri Olsa

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=8faa16cf-561e-cd31-7fb2-bfad3ae27782@linux.intel.com \
    --to=yao.jin@linux.intel.com \
    --cc=Linux-kernel@vger.kernel.org \
    --cc=acme@kernel.org \
    --cc=ak@linux.intel.com \
    --cc=alexander.shishkin@linux.intel.com \
    --cc=jolsa@kernel.org \
    --cc=jolsa@redhat.com \
    --cc=kan.liang@intel.com \
    --cc=mingo@redhat.com \
    --cc=peterz@infradead.org \
    --cc=yao.jin@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox