From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.3 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id ADE6AC48BCF for ; Thu, 10 Jun 2021 01:05:22 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 880B76140D for ; Thu, 10 Jun 2021 01:05:22 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229845AbhFJBHQ (ORCPT ); Wed, 9 Jun 2021 21:07:16 -0400 Received: from mga07.intel.com ([134.134.136.100]:17980 "EHLO mga07.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229557AbhFJBHP (ORCPT ); Wed, 9 Jun 2021 21:07:15 -0400 IronPort-SDR: 4g45bOFFpf2ukfila0IlkaaM5hWYyJhGEfsDq9y4q9SaX8AJw4CzOc0JCzby0jKBHK2fUP7RBZ lHL/cO2SdyiA== X-IronPort-AV: E=McAfee;i="6200,9189,10010"; a="269056843" X-IronPort-AV: E=Sophos;i="5.83,262,1616482800"; d="scan'208";a="269056843" Received: from fmsmga008.fm.intel.com ([10.253.24.58]) by orsmga105.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 09 Jun 2021 18:05:11 -0700 IronPort-SDR: FuCH7fvRVZblQBb315e+9uLrgPuoXS33u99nMBJkUVpAdhQotEkj2u4gMBhAahgYBsU/eW123G FuVx4HhttYYw== X-IronPort-AV: E=Sophos;i="5.83,262,1616482800"; d="scan'208";a="450144864" Received: from yjin15-mobl1.ccr.corp.intel.com (HELO [10.238.4.82]) ([10.238.4.82]) by fmsmga008-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 09 Jun 2021 18:05:00 -0700 Subject: Re: [PATCH v2] perf stat: Disable NMI watchdog message on hybrid To: Jiri Olsa Cc: acme@kernel.org, jolsa@kernel.org, peterz@infradead.org, mingo@redhat.com, alexander.shishkin@linux.intel.com, Linux-kernel@vger.kernel.org, ak@linux.intel.com, kan.liang@intel.com, yao.jin@intel.com References: <20210609050600.7308-1-yao.jin@linux.intel.com> From: "Jin, Yao" Message-ID: <8faa16cf-561e-cd31-7fb2-bfad3ae27782@linux.intel.com> Date: Thu, 10 Jun 2021 09:04:57 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.11.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Jiri, On 6/10/2021 4:26 AM, Jiri Olsa wrote: >> +static bool is_mixed_hybrid_group(struct evsel *counter) >> +{ >> + struct evlist *evlist = counter->evlist; >> + struct evsel *pos; >> + >> + evlist__for_each_entry(evlist, pos) { >> + if (perf_pmu__is_hybrid(pos->pmu_name)) >> + return true; >> + } > so we care if there's at least one hybrid event in the list right? > it can be all full with just hybrid events, but the function name > suggests it's mixed with normal events > > jirka > Yes, that's right. We only care there is at least one hybrid event in the evlist. So do we change the function name to evlist__has_hybrid_event? Thanks Jin Yao