public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Dragan Simic <dsimic@manjaro.org>
To: Andy Yan <andyshrk@163.com>
Cc: heiko@sntech.de, krzysztof.kozlowski+dt@linaro.org,
	robh+dt@kernel.org, devicetree@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org, linux-rockchip@lists.infradead.org
Subject: Re: [PATCH 2/4] arm64: dts: rockchip: aliase sdmmc as mmc1 for Cool Pi CM5 EVB
Date: Sat, 27 Jan 2024 14:07:36 +0100	[thread overview]
Message-ID: <8fbc0caf535e24e86c8b2458b63a130c@manjaro.org> (raw)
In-Reply-To: <20240127092034.887085-2-andyshrk@163.com>

On 2024-01-27 10:20, Andy Yan wrote:
> Follow others rk3588 based boards, and u-boot only use mmc0/1
> as mmc boot targets, so aliase sdmmc as mmc1.
> 
> Fixes: 791c154c3982 ("arm64: dts: rockchip: Add support for rk3588
> based board Cool Pi CM5 EVB")
> Signed-off-by: Andy Yan <andyshrk@163.com>

Makes sense to me.

Reviewed-by: Dragan Simic <dsimic@manjaro.org>

> ---
> 
>  arch/arm64/boot/dts/rockchip/rk3588-coolpi-cm5.dtsi | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/arch/arm64/boot/dts/rockchip/rk3588-coolpi-cm5.dtsi
> b/arch/arm64/boot/dts/rockchip/rk3588-coolpi-cm5.dtsi
> index 0b02f4d6e003..cce1c8e83587 100644
> --- a/arch/arm64/boot/dts/rockchip/rk3588-coolpi-cm5.dtsi
> +++ b/arch/arm64/boot/dts/rockchip/rk3588-coolpi-cm5.dtsi
> @@ -16,8 +16,8 @@ / {
> 
>  	aliases {
>  		mmc0 = &sdhci;
> -		mmc1 = &sdio;
> -		mmc2 = &sdmmc;
> +		mmc1 = &sdmmc;
> +		mmc2 = &sdio;
>  		serial2 = &uart2;
>  	};

  reply	other threads:[~2024-01-27 13:07 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-01-27  9:20 [PATCH 1/4] arm64: dts: rockchip: aliase sdmmc as mmc1 for Cool Pi 4B Andy Yan
2024-01-27  9:20 ` [PATCH 2/4] arm64: dts: rockchip: aliase sdmmc as mmc1 for Cool Pi CM5 EVB Andy Yan
2024-01-27 13:07   ` Dragan Simic [this message]
2024-01-27  9:20 ` [PATCH 3/4] arm64: dts: rockchip: rename vcc5v0_usb30_host regulator " Andy Yan
2024-01-27 10:36   ` Heiko Stübner
2024-01-27 12:15     ` Andy Yan
2024-01-27 13:09       ` Dragan Simic
2024-01-31 12:21         ` Andy Yan
2024-01-31 14:24           ` Heiko Stübner
2024-01-27  9:20 ` [PATCH 4/4] arm64: dts: rockchip: Fix the num-lanes of pcie3x4 on " Andy Yan
2024-01-27 13:07 ` [PATCH 1/4] arm64: dts: rockchip: aliase sdmmc as mmc1 for Cool Pi 4B Dragan Simic

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=8fbc0caf535e24e86c8b2458b63a130c@manjaro.org \
    --to=dsimic@manjaro.org \
    --cc=andyshrk@163.com \
    --cc=devicetree@vger.kernel.org \
    --cc=heiko@sntech.de \
    --cc=krzysztof.kozlowski+dt@linaro.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-rockchip@lists.infradead.org \
    --cc=robh+dt@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox