From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5C09735C189 for ; Fri, 14 Nov 2025 21:41:20 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763156480; cv=none; b=r7XmPfHaZo9vAFFfheRTghEfn0WU71ifFC/vuFyLwcDAR4PvfpkGI0CWOnnS2Wm7t+BDWnzV8O5uCminbH9Zqh5f0OAM6Jca90bdzcVWpv97uyNhrAVW6CVHJO9R5TDQH7OxqR3PF2gCu8X5aLCh8SO0sB4JV7xq1JmQYwQzXyo= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763156480; c=relaxed/simple; bh=r/3bQC+Fa/Fl2KnhgQsGNYnj9x+ETYs0SgCfPzMeYmE=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=bmtPLcpO+61+ifFm4Wk12tYK2hus3zcr6PEeXRQ4Y6iGQcPCvtdejktBEUz2X2wwIjbyjV6tLgC7UJ6UftE+KRA3XYo0H1uu36NwqBePpGBW0SBz4IqnvK9SQQ4ZPlQmGsAehbfABZ2fRIRCBtxnKZk322WxPwUMMh5jBwyfBh0= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=QdXrkXUT; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="QdXrkXUT" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 5D5C6C4CEF8; Fri, 14 Nov 2025 21:41:17 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1763156480; bh=r/3bQC+Fa/Fl2KnhgQsGNYnj9x+ETYs0SgCfPzMeYmE=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=QdXrkXUTFiJSyLN4SHcg0P/gy8sF6UNTHdASril5X6uMgNJyr6adWwNUgis72mojo Cp9Un/q/K/PAMM30CS4hdqKAYz/ZhetnWR6AiDiE88X0IWP+3wnKIUlAGUvtRXZj7b 0vFJysyhKzkn4kty44Sw1yxFoSDJ1IZ8tCrlHl0swyYBrWnINxNVsjviuDT4AGaQ6E olg4nGOzna/Ie8r8BCXQDpFWbgZ2wy4I/7nRYUVKfvtMnvdajZKe1sSB/aAb7gKn4d WennIqwg3ZfIMKy93u6ydUPTRPn96cNKzUsvmQr2yJNM0gTTlzAL/Gps5g8e6Yq6JB i9sanebc/LKug== Message-ID: <8fd2def3-addd-4abb-976a-857611871d1d@kernel.org> Date: Fri, 14 Nov 2025 22:41:15 +0100 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 2/2] Fix the source file annotation information for the "FOLL_WRITE" macro copied. To: John Hubbard , peng8420.li@gmail.com, linux-mm@kvack.org, akpm@linux-foundation.org Cc: osalvador@suse.de, jgg@ziepe.ca, peterx@redhat.com, linux-kernel@vger.kernel.org, dan.j.williams@intel.com References: <20251114161127.193707-1-peng8420.li@gmail.com> <20251114161127.193707-2-peng8420.li@gmail.com> <70d7ef58-8556-4aa4-86c8-b7ed79505471@nvidia.com> From: "David Hildenbrand (Red Hat)" Content-Language: en-US In-Reply-To: <70d7ef58-8556-4aa4-86c8-b7ed79505471@nvidia.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 14.11.25 21:26, John Hubbard wrote: > On 11/14/25 8:11 AM, peng8420.li@gmail.com wrote: >> From: "peng8420.li" > > Please see my reply to patch 1/1, about the real name, and the > From: item too. > >> >> The 'FOLL_RITE' of the copied source is located in mm_types. h of mm, not mm. h, so fix it. > > "FOLL_WRITE" > > Also, please wrap to 72 columns. > >> >> Suggested-by: "David Hildenbrand (Red Hat)" >> Signed-off-by: peng8420.li >> --- >> tools/testing/selftests/mm/gup_test.c | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/tools/testing/selftests/mm/gup_test.c b/tools/testing/selftests/mm/gup_test.c >> index 75f7134d529d..40c1538a17b4 100644 >> --- a/tools/testing/selftests/mm/gup_test.c >> +++ b/tools/testing/selftests/mm/gup_test.c >> @@ -17,7 +17,7 @@ >> >> #define MB (1UL << 20) >> >> -/* Just the flags we need, copied from mm.h: */ >> +/* Just the flags we need, copied from the kernel internals. */ >> #define FOLL_WRITE 0x01 /* check pte is writable */ >> >> #define GUP_TEST_FILE "/sys/kernel/debug/gup_test" > > With the commit log fixed up, please feel free to add: > > Reviewed-by: John Hubbard And here the subject should likely be: "selftests/mm: gup_test: fix comment regarding origin of FOLL_WRITE" It's usually a good idea to take a look at "git log -s $FILE" to see how previous commits came up with a subject. -- Cheers David