Re: [PATCH 2/7] msm: Physical offset for MSM8960

David Brown
2010-12-15T13:55:12Z

On Wed, Dec 15, 2010 at 04:17:48PM +0300, Sergei Shtylyov wrote:

> On 15-12-2010 6:49, Stepan Moskovchenko wrote:
>
> > Add the physical memory offset value for the Qualcomm
> > MSM8960 chip.
>
> > Signed-off-by: Stepan Moskovchenko<stepanm@codeaurora.org>
> [...]
>
> > diff --git a/arch/arm/mach-msm/include/mach/memory.h b/arch/arm/mach-msm/include/mach/memory.h
> > index 070e17d..014bbd3 100644
> > --- a/arch/arm/mach-msm/include/mach/memory.h
> > +++ b/arch/arm/mach-msm/include/mach/memory.h
> > @@ -25,6 +25,8 @@
> > #define PHYS_OFFSET UL(0x00200000)
> > #elif defined(CONFIG_ARCH_MSM8X60)
> > #define PHYS_OFFSET UL(0x40200000)
> > +#elif defined(CONFIG_ARCH_MSM8960)
> > +#define PHYS_OFFSET UL(0x40200000)
>
> Why not:
>
> -#elif defined(CONFIG_ARCH_MSM8X60)
> +#elif defined(CONFIG_ARCH_MSM8X60) || defined(CONFIG_ARCH_MSM8960)

I guess it's a matter of style, and what one is trying to emphasize.
Having each one listed makes it easier to change them individually.
The file is just a listing of the addresses of each chip, so I don't
see much reason to try and compact it.

Thanks,
David