Re: [PATCH v2 01/11] msm: Add CPU queries

David Brown
2011-01-25T00:20:18Z

On Mon, Jan 24 2011, Daniel Walker wrote:

> On Wed, 2011-01-19 at 12:25 -0800, David Brown wrote:
>> +#define cpu_is_msm7x01() 0
>> +#define cpu_is_msm7x30() 0
>> +#define cpu_is_qsd8x50() 0
>> +#define cpu_is_msm8x60() 0
>
> Now that I look at this again, why not drop the "x" all together ?

That might be better for the 8x60. The complexity is that most of the
MSM chips have some variants, where the CPU running Linux isn't changed,
but the modem CPU is different (think CDMA/UMTS). Until 8960, that was
distinguished by the second letter.

Either way doesn't quite match reality, unfortunately. There are
devices using a MSM7201 and others using a MSM7601. As far as Linux is
concerned, there isn't any difference between them. If someone wanted
to try and identify the device they have with the code, it could be
confusing for either name chosen.

I was planning on turning msm8x60 into msm8660, since that seems to be
the most common one. Perhaps the decoder ring should be put into the
help text for the options so people can at least figure out which is
which.

David