From: David Brown <davidb@codeaurora.org>
To: Daniel Walker <dwalker@codeaurora.org>
Cc: Stepan Moskovchenko <stepanm@codeaurora.org>,
linux-arm-msm@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/3] msm: iommu: Create a Kconfig item for the IOMMU driver
Date: Tue, 15 Feb 2011 11:35:54 -0800 [thread overview]
Message-ID: <8yar5b9850l.fsf@huya.qualcomm.com> (raw)
In-Reply-To: <1297456729.4852.9.camel@m0nster> (Daniel Walker's message of "Fri, 11 Feb 2011 12:38:49 -0800")
On Fri, Feb 11 2011, Daniel Walker wrote:
> On Fri, 2011-02-11 at 12:28 -0800, Stepan Moskovchenko wrote:
>> +config MSM_IOMMU
>> + bool "MSM IOMMU Support"
>> + depends on ARCH_MSM8X60
>> + select IOMMU_API
>> + default n
>> + help
>> + Support for the IOMMUs found on certain Qualcomm SOCs.
>> + These IOMMUs allow virtualization of the address space used by most
>> + cores within the multimedia subsystem.
>> +
>> + If unsure, say N here.
>
> I think you should just make this a hidden option, unless there is a
> good reason why any given users might want to turn this off.
In this particular case, the driver is optional, even devices that use
it will be able to work both with and without it. It makes sense to be
able to decide whether to have it or not.
David
--
Sent by an employee of the Qualcomm Innovation Center, Inc.
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum.
next prev parent reply other threads:[~2011-02-15 19:35 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-02-11 20:28 [PATCH 1/3] msm: iommu: Create a Kconfig item for the IOMMU driver Stepan Moskovchenko
2011-02-11 20:28 ` [PATCH 2/3] msm: iommu: Generalize platform data for multiple targets Stepan Moskovchenko
2011-02-11 20:42 ` Daniel Walker
2011-02-11 20:51 ` Steve Muckle
2011-02-11 20:58 ` Daniel Walker
2011-02-11 21:00 ` Steve Muckle
2011-02-11 21:03 ` Daniel Walker
2011-02-11 21:03 ` David Brown
2011-02-11 21:14 ` Daniel Walker
2011-02-11 21:53 ` David Brown
2011-02-11 22:00 ` Daniel Walker
2011-02-11 22:12 ` Daniel Walker
2011-02-11 22:37 ` David Brown
2011-02-11 22:47 ` Daniel Walker
2011-02-11 23:16 ` David Brown
2011-02-11 23:35 ` Daniel Walker
2011-02-11 20:28 ` [PATCH 3/3] msm: iommu: Enable IOMMU support for MSM8960 Stepan Moskovchenko
2011-02-11 20:38 ` [PATCH 1/3] msm: iommu: Create a Kconfig item for the IOMMU driver Daniel Walker
2011-02-15 19:35 ` David Brown [this message]
2011-02-15 19:49 ` Daniel Walker
2011-02-25 0:12 ` David Brown
2011-02-16 0:36 ` Daniel Walker
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8yar5b9850l.fsf@huya.qualcomm.com \
--to=davidb@codeaurora.org \
--cc=dwalker@codeaurora.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=stepanm@codeaurora.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox