Re: [PATCH 2/2] MN10300: Fix MTD JEDEC probe so that the ASB2303 bootprom can be detected

[David Howells <dhowells@redhat.com>]

David Howells <dhowells@redhat.com> wrote:

> Fix MTD JEDEC probe so that the ASB2303 bootprom can be accessed.  This is
> presumably required because the bootprom is normally write-protected and so
> the normal flash probes don't work as they require the ability to write to the
> flash to send it commands.

Actually, on re-checking the documentation, this particular board doesn't
appear to have a write-enable for the flash, but rather an access-enable
(which is obviously installed).  Furthermore, the probe does seem to manage to
work out that the chip is an MBM29LV800TA, so write is apparently possible.

So the problem appears to be something other than what I thought.

Without the patch, the kernel log shows:

| physmap platform flash device: 00200001 at a0000000
| physmap-flash physmap-flash.0: map_probe failed
| physmap platform flash device: 02000001 at a4000000
| physmap-flash.1: Found 4 x16 devices at 0x0 in 32-bit bank
|  Amd/Fujitsu Extended Query Table at 0x0040
| physmap-flash.1: Swapping erase regions for broken CFI table.
| number of CFI chips: 1
| cfi_cmdset_0002: Disabling erase-suspend-program due to code brokenness.
| cmdlinepart partition parsing not available
| Searching for RedBoot partition table in physmap-flash.1 at offset 0xfc0000
| 4 RedBoot partitions found on MTD device physmap-flash.1
| Creating 4 MTD partitions on "physmap-flash.1":
| 0x00000000-0x00040000 : "RedBoot"
| mtd: Giving out device 0 to RedBoot
| 0x00040000-0x00fc0000 : "unallocated"
| mtd: Giving out device 1 to unallocated
| 0x00fc0000-0x00fff000 : "FIS directory"
| mtd: partition "FIS directory" doesn't end on an erase block -- force read-only
| mtd: Giving out device 2 to FIS directory
| 0x00fff000-0x01000000 : "RedBoot config"
| mtd: partition "RedBoot config" doesn't start on an erase block boundary -- force read-only
| mtd: Giving out device 3 to RedBoot config
| 

With the patch, it shows:

| physmap platform flash device: 00200001 at a0000000
| CFI: Found no physmap-flash.0 device at location zero
| MTD: ASB2303: uaddr=1

(Note I added a printk to display uaddr if it reached this point.)

| Found: Fujitsu MBM29LV800TA
| MTD: ASB2303: uaddr=1
| physmap-flash.0: Found 1 x16 devices at 0x0 in 16-bit bank
| physmap-flash.0: Found an alias at 0x100000 for the chip at 0x0
| number of JEDEC chips: 1
| cfi_cmdset_0002: Disabling erase-suspend-program due to code brokenness.
| cmdlinepart partition parsing not available
| Searching for RedBoot partition table in physmap-flash.0 at offset 0xf0000
| 4 RedBoot partitions found on MTD device physmap-flash.0
| Creating 4 MTD partitions on "physmap-flash.0":
| 0x00000000-0x00040000 : "RedBoot"
| mtd: Giving out device 0 to RedBoot
| 0x00040000-0x000f0000 : "unallocated"
| mtd: Giving out device 1 to unallocated
| 0x000f0000-0x000ff000 : "FIS directory"
| mtd: partition "FIS directory" doesn't end on an erase block -- force read-only
| mtd: Giving out device 2 to FIS directory
| 0x000ff000-0x00100000 : "RedBoot config"
| mtd: partition "RedBoot config" doesn't start on an erase block boundary -- force read-only
| mtd: Giving out device 3 to RedBoot config
| physmap platform flash device: 02000001 at a4000000
| physmap-flash.1: Found 4 x16 devices at 0x0 in 32-bit bank
| physmap-flash.1: Found an alias at 0x1000000 for the chip at 0x0
|  Amd/Fujitsu Extended Query Table at 0x0040
| physmap-flash.1: Swapping erase regions for broken CFI table.
| number of CFI chips: 1
| cfi_cmdset_0002: Disabling erase-suspend-program due to code brokenness.
| cmdlinepart partition parsing not available
| Searching for RedBoot partition table in physmap-flash.1 at offset 0xfc0000
| 4 RedBoot partitions found on MTD device physmap-flash.1
| Creating 4 MTD partitions on "physmap-flash.1":
| 0x00000000-0x00040000 : "RedBoot"
| mtd: Giving out device 4 to RedBoot
| 0x00040000-0x00fc0000 : "unallocated"
| mtd: Giving out device 5 to unallocated
| 0x00fc0000-0x00fff000 : "FIS directory"
| mtd: partition "FIS directory" doesn't end on an erase block -- force read-only
| mtd: Giving out device 6 to FIS directory
| 0x00fff000-0x01000000 : "RedBoot config"
| mtd: partition "RedBoot config" doesn't start on an erase block boundary -- force read-only
| mtd: Giving out device 7 to RedBoot config

David