Re: [PATCH 1/3] drm/exynos/dsi: Use common error handling code in exynos_dsi_enable()

SF Markus Elfring
2017-10-24T09:09:11Z

>> @@ -1401,11 +1400,14 @@ static void exynos_dsi_enable(struct drm_encoder *encoder)
>> dsi->state &= ~DSIM_STATE_ENABLED;
>> exynos_dsi_set_display_enable(dsi, false);
>> drm_panel_unprepare(dsi->panel);
>> - pm_runtime_put_sync(dsi->dev);
>> - return;
>> + goto put_sync;
>> }
>>
>> dsi->state |= DSIM_STATE_VIDOUT_AVAILABLE;
>> + return;
>> +
>> +put_sync:
>> + pm_runtime_put_sync(dsi->dev);
>> }
>
> No, this does not simplify the code.

How do you think about to check a bit more if there are desired effects to consider
when the shown function call is stored only once at the end of this function implementation?

> Stop using coccinelle.

This will not happen for a while. - There are so many source code places left over
where you might care more for similar software improvements.

Regards,
Markus