Re: [PATCH] dt-bindings: interrupt-controller: Convert snps,archs-intc to DT schema

[Vineet Gupta <vgupta@kernel.org>]

On 5/5/25 07:48, Rob Herring (Arm) wrote:
> Convert the ARC-HS incore interrupt controller binding to schema format.
> It's a straight-forward conversion of the typical interrupt controller.
>
> Signed-off-by: Rob Herring (Arm) <robh@kernel.org>



Acked-by: Vineet Gupta <vgupta@kernel.org>

Thx,
-Vineet

> ---
>  .../interrupt-controller/snps,archs-intc.txt  | 22 ---------
>  .../interrupt-controller/snps,archs-intc.yaml | 48 +++++++++++++++++++
>  2 files changed, 48 insertions(+), 22 deletions(-)
>  delete mode 100644 Documentation/devicetree/bindings/interrupt-controller/snps,archs-intc.txt
>  create mode 100644 Documentation/devicetree/bindings/interrupt-controller/snps,archs-intc.yaml
>
> diff --git a/Documentation/devicetree/bindings/interrupt-controller/snps,archs-intc.txt b/Documentation/devicetree/bindings/interrupt-controller/snps,archs-intc.txt
> deleted file mode 100644
> index 69f326d6a5ad..000000000000
> --- a/Documentation/devicetree/bindings/interrupt-controller/snps,archs-intc.txt
> +++ /dev/null
> @@ -1,22 +0,0 @@
> -* ARC-HS incore Interrupt Controller (Provided by cores implementing ARCv2 ISA)
> -
> -Properties:
> -
> -- compatible: "snps,archs-intc"
> -- interrupt-controller: This is an interrupt controller.
> -- #interrupt-cells: Must be <1>.
> -
> -  Single Cell "interrupts" property of a device specifies the IRQ number
> -  between 16 to 256
> -
> -  intc accessed via the special ARC AUX register interface, hence "reg" property
> -  is not specified.
> -
> -Example:
> -
> -	intc: interrupt-controller {
> -		compatible = "snps,archs-intc";
> -		interrupt-controller;
> -		#interrupt-cells = <1>;
> -		interrupts = <16 17 18 19 20 21 22 23 24 25>;
> -	};
> diff --git a/Documentation/devicetree/bindings/interrupt-controller/snps,archs-intc.yaml b/Documentation/devicetree/bindings/interrupt-controller/snps,archs-intc.yaml
> new file mode 100644
> index 000000000000..9d248ef7fe3d
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/interrupt-controller/snps,archs-intc.yaml
> @@ -0,0 +1,48 @@
> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/interrupt-controller/snps,archs-intc.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: ARC-HS incore Interrupt Controller
> +
> +maintainers:
> +  - Vineet Gupta <vgupta@kernel.org>
> +
> +description:
> +  ARC-HS incore Interrupt Controller provided by cores implementing ARCv2 ISA.
> +  intc accessed via the special ARC AUX register interface, hence "reg" property
> +  is not specified.
> +
> +properties:
> +  compatible:
> +    const: snps,archs-intc
> +
> +  interrupt-controller: true
> +
> +  '#interrupt-cells':
> +    const: 1
> +
> +  interrupts:
> +    description: List of IRQ numbers between 16 and 256
> +    items:
> +      items:
> +        - minimum: 16
> +          maximum: 256
> +
> +required:
> +  - compatible
> +  - interrupt-controller
> +  - '#interrupt-cells'
> +  - interrupts
> +
> +additionalProperties: false
> +
> +examples:
> +  - |
> +    interrupt-controller {
> +        compatible = "snps,archs-intc";
> +        interrupt-controller;
> +        #interrupt-cells = <1>;
> +        interrupts = <16>, <17>, <18>, <19>, <20>, <21>, <22>, <23>, <24>, <25>;
> +    };