From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.1 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,NICE_REPLY_A, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7DEEEC433FE for ; Fri, 3 Sep 2021 20:41:29 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 62F43610C8 for ; Fri, 3 Sep 2021 20:41:29 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S240885AbhICUm2 (ORCPT ); Fri, 3 Sep 2021 16:42:28 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:40296 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231956AbhICUm1 (ORCPT ); Fri, 3 Sep 2021 16:42:27 -0400 Received: from mail-pl1-x630.google.com (mail-pl1-x630.google.com [IPv6:2607:f8b0:4864:20::630]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 029AAC061575 for ; Fri, 3 Sep 2021 13:41:27 -0700 (PDT) Received: by mail-pl1-x630.google.com with SMTP id n4so232694plh.9 for ; Fri, 03 Sep 2021 13:41:26 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel-dk.20150623.gappssmtp.com; s=20150623; h=subject:to:references:from:message-id:date:user-agent:mime-version :in-reply-to:content-language:content-transfer-encoding; bh=dkiYCFVjwmJybf5JwViF3SzBrvupFdjsBCuydcFWyT8=; b=vgK43H1zn6Xvy5dwhpNC/VIfid81C34dA7jP6x0dx4VWZVYxTAsw1irYJkp+WF/sK8 yq3JZRiFW3C+LGeziU41xfq1Cwd2PAI/npDO62tX1B2ptn9NEsMw9qO7HbWrddX6e8Ok x/9FisOn8rKwPKPe3xmsAoJ2LCRe3KFJ1fV9Fuip3SpssZ5abF9FbNzzIl3QIbg688BI CdQ3u6MOTnqIENG/Oe8AELp8NvkyNl4ZiFQVH9dyK3XzhDm+ljnZZmch0wQxspQAPxjz dCqsNDUYxpqvh0/bG1Y6Y0P3r+wCyRmzGibchEAkUkTcZK3Ocw6G8vDz5SlEoeSZenBZ YFHQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=dkiYCFVjwmJybf5JwViF3SzBrvupFdjsBCuydcFWyT8=; b=SLCNW6PZRW5grpEVzdazWp3XaiFlhseDwZ6lKx2RWzdBoyMsdU6BEYChg/YS40Goyc GZ5QEZM3bmKBGFPeP14yQsxxMCiwkbjH5/6itUVWpKCZmyYSwRhTTUwH8SqiIUnFrfv9 RJKVzwj53g2t9jf+tcaH6lz8Thb7bZYJ9mc1MA3HnnXoS+JV+V5cwQxSAlDYnABE96Lv pjnc8/PPZe+ZGsFKxi67vQEpgfhRMDha+Bg89X+PCso6Ytn5f1XMqUJyDcAwzdKZB9bZ hwCm9SopyWcDNZJyE+d87fxETasPB3tk6w7Ujzl6ivgu4wuofreTJDwlgQz4BvbsGE69 gBzA== X-Gm-Message-State: AOAM5305tnf9FLaJk3PMxHT256bYtF22Em+9BWiXYhTFxSUiosh81kjs SKLompIaOXdZFJDxm6JRNCJzdA== X-Google-Smtp-Source: ABdhPJzOOBaBftmLG3TgPcPUZNEjVQbPQAW4pR5s9MLa9p52tQlyZwiCWH7JEtNWCFCR3DMPX5Aypg== X-Received: by 2002:a17:90b:116:: with SMTP id p22mr687216pjz.67.1630701686473; Fri, 03 Sep 2021 13:41:26 -0700 (PDT) Received: from ?IPv6:2600:380:7567:4da9:ea68:953f:1224:2896? ([2600:380:7567:4da9:ea68:953f:1224:2896]) by smtp.gmail.com with ESMTPSA id b5sm247811pfr.26.2021.09.03.13.41.24 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 03 Sep 2021 13:41:25 -0700 (PDT) Subject: Re: Bug: d0e936adbd22 crashes at boot To: Srinivas Pandruvada , LKML , "Rafael J. Wysocki" , Len Brown , linux-pm@vger.kernel.org References: <942f4041-e4e7-1b08-3301-008ab37ff5b8@kernel.dk> <3ac87893-55ba-f2d4-bb1e-382868f12d4c@kernel.dk> <7f115f0476618d34b24ddec772acbbd7c0c4a572.camel@linux.intel.com> <767fe00f-bf31-1eb0-09cc-1be91c633bb4@kernel.dk> From: Jens Axboe Message-ID: <903f2e71-983f-39b8-dd0b-d697616ab63e@kernel.dk> Date: Fri, 3 Sep 2021 14:41:23 -0600 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 9/3/21 12:00 PM, Srinivas Pandruvada wrote: > Hi Axobe, > > On Fri, 2021-09-03 at 09:00 -0600, Jens Axboe wrote: >> On 9/3/21 8:38 AM, Srinivas Pandruvada wrote: >>> On Fri, 2021-09-03 at 08:15 -0600, Jens Axboe wrote: >>>> On 9/3/21 8:13 AM, Srinivas Pandruvada wrote: >>>>> Hi Axboe, >>>>> >>>>> Thanks for reporting. >>>>> On Fri, 2021-09-03 at 07:36 -0600, Jens Axboe wrote: >>>>>> Hi, >>>>>> >>>>>> Booting Linus's tree causes a crash on my laptop, an x1 gen9. >>>>>> This >>>>>> was >>>>>> a bit >>>>>> difficult to pin down as it crashes before the display is up, >>>>>> but I >>>>>> managed >>>>>> to narrow it down to: >>>>>> >>>>>> commit d0e936adbd2250cb03f2e840c6651d18edc22ace >>>>>> Author: Srinivas Pandruvada < >>>>>> srinivas.pandruvada@linux.intel.com> >>>>>> Date:   Thu Aug 19 19:40:06 2021 -0700 >>>>>> >>>>>>     cpufreq: intel_pstate: Process HWP Guaranteed change >>>>>> notification >>>>>> >>>>>> which crashes with a NULL pointer deref in >>>>>> notify_hwp_interrupt() - >>>>>>> >>>>>> queue_delayed_work_on(). >>>>>> >>>>>> Reverting this change makes the laptop boot fine again. >>>>>> >>>>> Does this change fixes your issue? >>>> >>>> I would assume so, as it's crashing on cpudata == NULL :-) >>>> >>>> But why is it NULL? Happy to test patches, but the below doesn't >>>> look >>>> like >>>> a real fix and more of a work-around. >>> > > Please try the attached. I'll give it a test spin right now. Please do add a Reported-by tag, though. That's always prudent. -- Jens Axboe