From: Neil Armstrong <narmstrong@baylibre.com>
To: Jerome Brunet <jbrunet@baylibre.com>
Cc: Kevin Hilman <khilman@baylibre.com>,
linux-amlogic@lists.infradead.org, linux-clk@vger.kernel.org,
linux-kernel@vger.kernel.org,
Dmitry Shmidt <dimitrysh@google.com>
Subject: Re: [PATCH] clk: meson: g12a: fix missing uart2 in regmap table
Date: Fri, 13 Dec 2019 11:34:28 +0100 [thread overview]
Message-ID: <904df8d1-e975-b493-ca6f-88b8547de84d@baylibre.com> (raw)
In-Reply-To: <20191213103304.12867-1-jbrunet@baylibre.com>
On 13/12/2019 11:33, Jerome Brunet wrote:
> UART2 peripheral is missing from the regmap fixup table of the g12a family
> clock controller. As it is, any access to this clock would Oops, which is
> not great.
>
> Add the clock to the table to fix the problem.
>
> Fixes: 085a4ea93d54 ("clk: meson: g12a: add peripheral clock controller")
> Reported-by: Dmitry Shmidt <dimitrysh@google.com>
> Tested-by: Dmitry Shmidt <dimitrysh@google.com>
> Signed-off-by: Jerome Brunet <jbrunet@baylibre.com>
> ---
> drivers/clk/meson/g12a.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/clk/meson/g12a.c b/drivers/clk/meson/g12a.c
> index 66cf791bfc8c..cd1de3e004e4 100644
> --- a/drivers/clk/meson/g12a.c
> +++ b/drivers/clk/meson/g12a.c
> @@ -4692,6 +4692,7 @@ static struct clk_regmap *const g12a_clk_regmaps[] = {
> &g12a_bt656,
> &g12a_usb1_to_ddr,
> &g12a_mmc_pclk,
> + &g12a_uart2,
> &g12a_vpu_intr,
> &g12a_gic,
> &g12a_sd_emmc_a_clk0,
>
Acked-by: Neil Armstrong <narmstrong@baylibre.com>
next prev parent reply other threads:[~2019-12-13 10:34 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-13 10:33 [PATCH] clk: meson: g12a: fix missing uart2 in regmap table Jerome Brunet
2019-12-13 10:34 ` Neil Armstrong [this message]
2019-12-13 16:44 ` Kevin Hilman
2019-12-16 9:30 ` Jerome Brunet
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=904df8d1-e975-b493-ca6f-88b8547de84d@baylibre.com \
--to=narmstrong@baylibre.com \
--cc=dimitrysh@google.com \
--cc=jbrunet@baylibre.com \
--cc=khilman@baylibre.com \
--cc=linux-amlogic@lists.infradead.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox