From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-il1-f176.google.com (mail-il1-f176.google.com [209.85.166.176]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C3251145B00 for ; Thu, 26 Dec 2024 20:43:18 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.166.176 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1735245801; cv=none; b=e/mrSDx5gOBJoPUpLjFjbYpcqCmFuyhzON89Uc13Nsuf02tnGQfVUJ2M6i7Shmlg1eCuYPRo3wimGt2FkZ/aQhBBTS9+UspFKxjSHQNz+Z4U2gzQfIQC0GYyKtGUAHZn+5DHlXfSgXBmnws4YEAy+LD3fcyCjT0w9ojDMx5MrSg= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1735245801; c=relaxed/simple; bh=EVB/z94Z/cUpmZl3sx8QihHRwdbPYViMl+801MhowsU=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=eqvKzcchMk1rlUucpyh0iUal1r1tK3gdJ8hcGbqDLROnsE7eJDKqAbHPLLVhb5yThqSR3SHcJ5Nxa/h0hzj/cOqPp/auy0UvXqbnj6EPyu3nphmN6kkx4N7IIQ6fAY3d/uoZu/XbhUg4iHRXrYk/XqozzK2vP0h9TNrB1c3g6/Q= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linuxfoundation.org; spf=pass smtp.mailfrom=linuxfoundation.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=Ox2q/OgN; arc=none smtp.client-ip=209.85.166.176 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linuxfoundation.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linuxfoundation.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="Ox2q/OgN" Received: by mail-il1-f176.google.com with SMTP id e9e14a558f8ab-3ab2f414695so24460795ab.0 for ; Thu, 26 Dec 2024 12:43:18 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linuxfoundation.org; s=google; t=1735245798; x=1735850598; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=qlbero79GqIXgnhR5M62NzRENxRkrfULP9LT/QfVE4c=; b=Ox2q/OgN0yci387ifCHi42Gu0xWgSsiDBooQnSmRWwWrr3Ja7i3nTQTjlaWvW8mLjV XQFEVpxFHRjRR1EKkSjkHNV2iMRygFKZrcpleCD3BxvmsiVApsA2fdSP72EuT594HkSr T3W/sdLPuN/NSHjvgdub2DYtgGdbgdqjOGZUM= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1735245798; x=1735850598; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=qlbero79GqIXgnhR5M62NzRENxRkrfULP9LT/QfVE4c=; b=L09rV6p0cR7el9uK8skuDsmGRSjp2wGDbyXrMIk9d8sR5dyh+7mYlqUgQgYt5XcfWc gwN71nWIO9n8LSyS20CYaMLDswVJ1kgzXc1WOQzbnyqnTe3GB2GYMgGcLvBOctJFrhRb Ad1guzlAQPPZ97p5eK7KREOI5eYQMuk05kb4IF50lAgqDEaTn3CtDFV5deAaFOTnTTfn V8P71zm6WSxYUp268bxNzmlBIFSvsvhg27wmQhe2nip8WeM/9yvzNo6GTmzmue2baWaz p9+gAibLY3ptEqJIipwW4brAzYSkC6EGF4gc+U6oq7/C+rJf2C2Bw2Ywe2i+38ynlobv gRjg== X-Forwarded-Encrypted: i=1; AJvYcCWssja+7HaKkF7kchSh42CkRj1Dd2LkNIhlldaeKMdN5vgl1c0BBu5pB4/kLmgM6slYAcck7087OjSgF+c=@vger.kernel.org X-Gm-Message-State: AOJu0YzQncdDFVYuJpl6yEV5T7Wz1LzmZmO1ILpycSOXzkMq/P4ow8j1 VVdY6Goy9/Cta/1e+7W8fRMmYPkW8x7SS+5FeGwFyRlflEELHsqFGcJlExW37wc= X-Gm-Gg: ASbGncv79CrIG8dQof/SczjaYrvmVWNjAboJpH5QFuLdKow1mwfNe/JLgx0blFBSNKl 4Bo+ed4GiPAe9k9ulCZ/XfxI7BOxSAGb/gRh1GDKKWec6g5mbEXN0qS4Wojhl8uQFEWZSfngiSi c1Cs4CBIA/HxdEb0FXtFaFq+R6u/RR+ldL9ffld8T13Kl9TRDLWLDpzozNDNYRxa8uXj/M3dDEI DojM84srr9HKdlWbV0qn5eySaAf8sFwtcVfU2XvyXASRqKJnpSb9VBgqg22AT41Lk2V X-Google-Smtp-Source: AGHT+IEgiHnypDUme0HyThlW1l7V+XNsgLos1jQDwGQcqUYckzI7qAkEvzXJfG5JG0fIDbI8yRYPQA== X-Received: by 2002:a05:6e02:1d0d:b0:3a7:e528:6ee6 with SMTP id e9e14a558f8ab-3c2d2783efdmr165797935ab.13.1735245797776; Thu, 26 Dec 2024 12:43:17 -0800 (PST) Received: from [192.168.1.128] ([38.175.170.29]) by smtp.gmail.com with ESMTPSA id 8926c6da1cb9f-4e68c1de6e0sm3838301173.127.2024.12.26.12.43.16 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 26 Dec 2024 12:43:17 -0800 (PST) Message-ID: <9058432a-a00c-49c3-824b-dd296970986a@linuxfoundation.org> Date: Thu, 26 Dec 2024 13:43:16 -0700 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v4 02/15] staging: gpib: agilent_82350b: Handle gpib_register_driver() errors To: Nihar Chaithanya , dpenkler@gmail.com, gregkh@linuxfoundation.org Cc: dan.carpenter@linaro.org, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, Shuah Khan References: <20241226193637.241049-1-niharchaithanya@gmail.com> <20241226193637.241049-3-niharchaithanya@gmail.com> Content-Language: en-US From: Shuah Khan In-Reply-To: <20241226193637.241049-3-niharchaithanya@gmail.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 12/26/24 12:36, Nihar Chaithanya wrote: > The function gpib_register_driver() can fail which can result in > semi-registered module. > > In case gpib_register_driver() fails unregister the previous > gpib and pci registering functions, return the error value. > > Signed-off-by: Nihar Chaithanya > --- > .../gpib/agilent_82350b/agilent_82350b.c | 21 ++++++++++++++----- > 1 file changed, 16 insertions(+), 5 deletions(-) > > diff --git a/drivers/staging/gpib/agilent_82350b/agilent_82350b.c b/drivers/staging/gpib/agilent_82350b/agilent_82350b.c > index 53006d0cc79c..39420f2b0b32 100644 > --- a/drivers/staging/gpib/agilent_82350b/agilent_82350b.c > +++ b/drivers/staging/gpib/agilent_82350b/agilent_82350b.c > @@ -909,14 +909,25 @@ static int __init agilent_82350b_init_module(void) > int result; > > result = pci_register_driver(&agilent_82350b_pci_driver); > - if (result) { > - pr_err("agilent_82350b: pci_driver_register failed!\n"); Is there a reason to delete this message? > + if (result) > return result; > - } > > - gpib_register_driver(&agilent_82350b_unaccel_interface, THIS_MODULE); > - gpib_register_driver(&agilent_82350b_interface, THIS_MODULE); > + result = gpib_register_driver(&agilent_82350b_unaccel_interface, THIS_MODULE); > + if (result) > + goto err_unaccel; > + > + result = gpib_register_driver(&agilent_82350b_interface, THIS_MODULE); > + if (result) > + goto err_interface; > + > return 0; > + > +err_interface: > + gpib_unregister_driver(&agilent_82350b_unaccel_interface); > +err_unaccel: > + pci_unregister_driver(&agilent_82350b_pci_driver); > + > + return result; > } > > static void __exit agilent_82350b_exit_module(void) thanks, -- Shuah